Re: [Discuss] separate ML for PR and build notification?

2015-07-13 Thread Wido den Hollander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13-07-15 10:11, Rene Moser wrote: Hey Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120883355 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [Discuss] separate ML for PR and build notification?

2015-07-13 Thread Rohit Yadav
On 13-Jul-2015, at 1:41 pm, Rene Moser m...@renemoser.netmailto:m...@renemoser.net wrote: Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications about

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120906494 test logic makes sense; LGTM waiting for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-120903118 @karuturi @DaanHoogland Added unit tests for CPVM allocation. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120897166 Thanks both, I pushed another UI change. Please see it too. This change allows admins to say if they want usernames with a domain (extracted from the IDP server).

[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/573#issuecomment-121137019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: simulator-singlerun #1361

2015-07-13 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1361/ -- Started by upstream project build-master-simulator build number 2178 originally caused by: Started by an SCM change Started by an SCM change Started by upstream project build-master

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-121131795 Squashing and merging commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121133952 Although RAT build status is showing ABORTED, the report is clean. Also the build failed due to some random test failure. Since travis is green, I am going

[GitHub] cloudstack pull request: Coverity resource leaks

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/578#issuecomment-121138178 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: capitalized method name

2015-07-13 Thread Jayapal Reddy Uradi
Hi Daan, Please go ahead and change the name. Thanks for notifying. -Jayapal On 13-Jul-2015, at 8:45 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Jayapal, I didn't notice this before but in PR 568, in commit 638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name starting

Build failed in Jenkins: simulator-4.5-singlerun #253

2015-07-13 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/253/ -- Started by upstream project build-4.5-simulator build number 308 originally caused by: Started by upstream project build-4.5 build number 498 originally caused by: Started by an SCM

[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...

2015-07-13 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/571#issuecomment-121138730 Manually closing PR. I did a rebase to do away with unnecessary merge commit. --- If your project is set up for it, you can reply to this email and have your

New Defects reported by Coverity Scan for cloudstack

2015-07-13 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 3 new defect(s) introduced to cloudstack found with Coverity Scan. 32 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New

Build failed in Jenkins: simulator-singlerun #1360

2015-07-13 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1360/ -- Started by upstream project build-master-simulator build number 2177 originally caused by: Started by an SCM change Started by an SCM change Started by an SCM change Started by upstream

[GitHub] cloudstack pull request: CLOUDSTACK-8623: CPVM fails to start afte...

2015-07-13 Thread koushik-das
Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [2/3] git commit: updated refs/heads/master to 63688e7

2015-07-13 Thread Wido den Hollander
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/13/2015 05:30 PM, Daan Hoogland wrote: LGTM but what PR did I miss here, Wido? Uh, oops. None. I completely forgot! Won't happen again :) Wido On Mon, Jul 13, 2015 at 4:59 PM, wid...@apache.org wrote: kvm: Write Libvirt instead of

Build failed in Jenkins: simulator-singlerun #1359

2015-07-13 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1359/ -- Started by upstream project build-master-simulator build number 2176 originally caused by: Started by upstream project build-master build number 2462 originally caused by: Started by an

Re: [2/3] git commit: updated refs/heads/master to 63688e7

2015-07-13 Thread Daan Hoogland
LGTM but what PR did I miss here, Wido? On Mon, Jul 13, 2015 at 4:59 PM, wid...@apache.org wrote: kvm: Write Libvirt instead of LibVirt Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/24f8e66e Tree:

capitalized method name

2015-07-13 Thread Daan Hoogland
Jayapal, I didn't notice this before but in PR 568, in commit 638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name starting with capital 'A' to citrixrecource base. Is this on purpose and can we change it to adhere to convention? public boolean

Build failed in Jenkins: simulator-singlerun #1358

2015-07-13 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1358/ -- Started by upstream project build-master-simulator build number 2175 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

2015-07-13 Thread Sanjeev N
LGTM On Mon, Jul 13, 2015 at 11:02 AM, nitt10prashant g...@git.apache.org wrote: GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/579 CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p… …s_max_limits.py for lxc

RE: [PROPOSAL] Commit to master through PR only

2015-07-13 Thread Paul Angus
I agree with Daan, Lazy consensus QA is not going to improve code quality. If anything we're highlighting a structural issue with the amount of resource available to review these PRs - which is a different issue and would need looking at as such as it is fundamental to our push for improved

[Discuss] separate ML for PR and build notification?

2015-07-13 Thread Rene Moser
Hey Since we rebuild our communication stack (slack, irc, ML, ...) I would bring up some discussion about the noise in the dev ML. I like to be in dev ML but I am not that interested in notifications about builds on PR, PR comments, and Jenkins builds. I am suggest to make a seprate ML for

LAST CHANCE - speaker submissions for CCCEU15

2015-07-13 Thread Giles Sirett
All We've had some great talks submitted for Dublin so should now be able to put together a really exciting agenda , but we still have room on the schedule for some more, so... Please consider submitting a talk: The CFP closes in 2 days

[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

2015-07-13 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-120846548 @runseb Sorry for delayed response, I was away for two weeks. As said by Sanjeev, the tests were wrongly tagged. required_hardware = true implies test