[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128284375 @koushik-das I've backported your fix from master to 4.5 using the PR #263, please review --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

2015-08-06 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128293184 ok. There are lot of ifs in that part of the code which makes it difficult to read. I will have to try it to understand fully for which I dont have time now. So, I

[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...

2015-08-06 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/662 CLOUDSTACK-8711: public_ip type resource count for an account is not decremented upon IP range deletion Probleam: -- When you add an IP range and associate it

[GitHub] cloudstack pull request: CLOUDSTACK-8638: install update_host_pass...

2015-08-06 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/663 CLOUDSTACK-8638: install update_host_passwd.sh in cloudstack-common installation You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] 4.5.2 bugfix sprint

2015-08-06 Thread Daan Hoogland
Rajani, Wido, I think what Rohit says makes sense. If we put it in 451to452 and release 4.5.2 in the coming week and 4.6.0 at the end of the month we are alright. Except for Wido that is, he will have to fix his DB's removing the autoincrement in the id of regions by hand. On Thu, Aug 6, 2015 at

Re: Super trivial code change and PR

2015-08-06 Thread Remi Bergsma
We'll live with it this time I'd say ;-) Thanks for bringing it up! Regards, Remi On 06 Aug 2015, at 08:09, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Fair enough Do you want me to revert this one or are we OK to just live with it? On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/547#discussion_r36490405 --- Diff: engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java --- @@ -53,6 +53,7 @@ protected

[GitHub] cloudstack pull request: Fixed Coverity issue Dereference null re...

2015-08-06 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-128602113 @mike-tutkowski I did not find any other possibility where createPhysicalDisk would return null unless is called from NfsManagedStorageAdaptor class.Please

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-128594438 Aside from a couple minor comments, LGTM. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Fixed Coverity issue Dereference null re...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-128604281 That is very well true, but I worry that a comment that specific would not be updated should the time come when another adaptor does, in fact, return null

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/547#discussion_r36490618 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java --- @@ -71,6 +74,17 @@ public

Re: Vr not working in master

2015-08-06 Thread Jayapal Reddy Uradi
Can you please share the MS logs ? I think the VR might failed on configuring rules due to this VR stop. Observe the MS from the VR start onwards to VR stop. Thanks, Jayapal On 07-Aug-2015, at 3:18 AM, Pierre-Luc Dion pd...@cloudops.com wrote: Hi, We wanted to do some tests against master

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/547#discussion_r36490233 --- Diff: core/src/com/cloud/agent/api/ModifyStoragePoolAnswer.java --- @@ -26,6 +26,7 @@ public class ModifyStoragePoolAnswer extends Answer

[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36490932 --- Diff: services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java --- @@ -50,26 +52,27 @@ public void

[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36490966 --- Diff: utils/src/com/cloud/utils/nio/NioConnection.java --- @@ -334,6 +333,7 @@ protected void processTodos() { try

[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-12859 Aside from my break question and indentation request, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed medium dictionary from test_dat...

2015-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Super trivial code change and PR

2015-08-06 Thread Mike Tutkowski
Fair enough Do you want me to revert this one or are we OK to just live with it? On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma rberg...@schubergphilis.com wrote: Hi Mike, Yes, I want everything to go through a PR. Otherwise: - there are no Travis CI and other tests run - we need to

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-06 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128337719 I will merge this to master and keep the bug open so that it can be fixed in 4.5.2 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128342511 Changes LGTM. Make sure travis is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128347115 @koushik-das thanks, looks like Travis failed due to some timeout issue and in other case due to dependency/jar issue. Will force push again to re-kick the travis

[GitHub] cloudstack pull request: CLONE - Restore VM (Re-install VM) with e...

2015-08-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/659#issuecomment-128469563 LGTM. I tested it on a VM running on KVM and it works fine now with enable.storage.migration=false. The VM restore itself also still works. Please see

Re: [DISCUSS][PROPOSAL] Support for standard metadata/userdata URL

2015-08-06 Thread Chiradeep Vittal
The Apache web server listens only on the eth0 IP. I added the 169.* address to eth0 and changed the Apache config to listen on that IP as well. While the Apache Webserver now receives the request, it returns a 404. Fiddling with the .htaccess file could fix that, but now that’s a bigger change

Re: [DISCUSS][PROPOSAL] Support for standard metadata/userdata URL

2015-08-06 Thread Chiradeep Vittal
Excellent tip! Didn’t notice this in the docs before: http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.5/virtual_machines/user-data.html From: Carlos Reategui car...@reategui.commailto:car...@reategui.com Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

2015-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Super trivial code change and PR

2015-08-06 Thread Mike Tutkowski
How's about this: Super-Trivial: :) On Thu, Aug 6, 2015 at 2:34 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Mike, If you find a good title for such a trivial change bucket pr it makes creating release notes easier as well. Try to group them by mental state or character (can you say

[GitHub] cloudstack pull request: CLOUDSTACK-8698: Retrieve a new device ID...

2015-08-06 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/660#issuecomment-128443925 Sounds good, @karuturi I'll go ahead and check the code in. Thanks for the comments. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128373260 Looks like some confusion is going on here; the changes need to go into: setup/db/db/schema-451to452.sql that I had suggested earlier. If you do that, then people

[GitHub] cloudstack pull request: CLOUDSTACK-8638: install update_host_pass...

2015-08-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/663#issuecomment-128386362 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-06 Thread devdeep
Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-128292255 @DaanHoogland When prepareTemplate is called, it either falls into prepareTemplateInOneStoragePool if one primary has to be seeded with the template; or

Re: Super trivial code change and PR

2015-08-06 Thread Daan Hoogland
H Mike, If you find a good title for such a trivial change bucket pr it makes creating release notes easier as well. Try to group them by mental state or character (can you say that in English?) On Thu, Aug 6, 2015 at 8:31 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Sounds good I

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128300894 Did functional testing with two KVM hosts, across two Advance Zones with VLAN isolation: ![screen shot 2015-08-06 at 2 34 24

Re: [DISCUSS] 4.5.2 bugfix sprint

2015-08-06 Thread Wido den Hollander
On 05-08-15 18:37, Rohit Yadav wrote: On 05-Aug-2015, at 11:01 am, Rajani Karuturi raj...@apache.org mailto:raj...@apache.org wrote: Hi Rohit, Any update on the release timelines for 4.5.2? I think based on the current upgrade path, we have to do 4.5.2 before 4.6.0. Else upgrade path

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/661 CLOUDSTACK-8301: Enable configuring local storage use for system VMs … …at zone level Backported from #263 for 4.5 branch More information on

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128280936 Created PR, still testing on KVM/4.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-06 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128306138 LGTM if 4.5.2 is released before 4.6.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Super trivial code change and PR

2015-08-06 Thread Mike Tutkowski
Sounds good I could always cache those kinds of trivial changes and create a single PR for them later, too. On Thu, Aug 6, 2015 at 12:29 AM, Remi Bergsma rberg...@schubergphilis.com wrote: We'll live with it this time I'd say ;-) Thanks for bringing it up! Regards, Remi On 06 Aug 2015, at

Re: [DISCUSS][PROPOSAL] Support for standard metadata/userdata URL

2015-08-06 Thread Carlos Reategui
BTW you can speed up cloud-init to look for CloudStack first/only by overriding the datasource_list. The way I do it is by adding a file in my templates to the /etc/cloud/cloud.cfg.d directory with only CloudStack in it: echo datasource_list: [ CloudStack ]

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-08-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/661#issuecomment-128288397 Tests fixed, hoping this will pass Travis now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-06 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-128293895 I read it as this PR is good for master. If thats the case, can I get some +1s please. --- If your project is set up for it, you can reply to this email and have

Re: [DISCUSS][PROPOSAL] Support for standard metadata/userdata URL

2015-08-06 Thread Erik Weber
Would it not work to assign the address 169.254.169.254 on the VR? Erik Den torsdag 6. august 2015 skrev Chiradeep Vittal chiradeep.vit...@citrix.com følgende: Today the metadata / userdata server is retrieved by the guest from http://address of DHCP server/latest/meta-data and