[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135307448 I like having tools that help us do the job right, and equally, every time. However, if we were to choose an official tool for the job it should be usable by

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135299382 @terbolous yes, if you're a PMC you can run this by logging into people.apache.org; https://people.apache.org/~bhaisaab/cloudstack/makewholist.sh thi

[GitHub] cloudstack pull request: messages: fix string in pt_BR translation...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/749 messages: fix string in pt_BR translation file The string error caused JS error that failed translation on the UI Signed-off-by: Rohit Yadav You can merge this pull request into a Git

[GitHub] cloudstack pull request: messages: fix string in pt_BR translation...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/748 messages: fix string in pt_BR translation file The string error caused JS error that failed translation on the UI Signed-off-by: Rohit Yadav You can merge this pull request into a Git

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38060134 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

Re: [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

The class is in cloud-utils package. ~Rajani On 26-Aug-2015, at 11:18 pm, Rafael Weingärtner wrote: > Hi folks, > > I am getting an error with a Travis build of a PR that we have done: > > > log4j:ERROR Could not create the ThrowableRenderer. Reported error follows. > > java.lang.ClassNo

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38059425 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache S

[GitHub] cloudstack pull request: fix debian package after addition of lice...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/746#issuecomment-135204602 @pdion891 If you force push your commits, Travis will run again. It will then probably pass and we can merge it. Thanks! --- If your project is set up for it, y

Build failed in Jenkins: build-4.5 #519

See Changes: [Rohit Yadav] CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template listing -- [...truncated 2824 lines...] [INFO] This project has been banned from the build due to p

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-135201859 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-135201596 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135177633 I didn't take it as a -1, or I would have reverted my change. I just finished pushing the change and didn't want you to think I was ignoring your comment. It is va

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135171873 It wasn't meant as a -1 vote really, just a note that there's a discrepancy that should be settled. Remi does after all belong in the PMC table :-) --- If your

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user ke4qqq closed the pull request at: https://github.com/apache/cloudstack-www/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135171269 Well I just committed this change, prior to seeing @terbolous comment. - so I'll close this, but we do indeed need to figure out how we want to do this. --- If y

[GitHub] cloudstack pull request: Removing unit test that was failing to co...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/747 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removing unit test that was failing to co...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/747#issuecomment-135167089 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135166727 There's a small discrepancy about how to list PMC members. Previous to this[1] commit, they were listed in a separate table (moved from committers to pmc upo

[GitHub] cloudstack pull request: Removing unit test that was failing to co...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/747#issuecomment-135165251 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135163200 LGTM ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

FYI: MariaDB upgrade on CentOS 7 breaks install

Hi all, Not sure if MariaDB is even supported, but for those who use it: Today I run into an issue with the latest MariaDB on CentOS7 (it was upgraded from 5.5.41 -> 5.5.44). After the upgrade I could no longer install CloudStack due to the following error (traced it to this file by executing a

[GitHub] cloudstack-www pull request: Updated PMC

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-www/pull/12#issuecomment-135159546 Merged this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack-www pull request: Updated PMC

Github user ke4qqq closed the pull request at: https://github.com/apache/cloudstack-www/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135159647 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

On Aug 26, 2015, at 7:08 PM, David Nalley wrote: > +1 (binding) > > sigs and hashes look good. > builds fine > no binaries present. > A few files seem to be missing license headers, but I don't think it's > a blocker. > License and NOTICE appear to be correct. > > I wish we pointed to the clou

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-135142435 Hi folks, Sorry the double post, I replyed an asf bot mail and it seems tha the message was not properly relayed. I am getting an error with a

[GitHub] cloudstack pull request: Removing unit test that was failing to co...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/747#issuecomment-135133597 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: Removing unit test that was failing to co...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/747 Removing unit test that was failing to cover the resolution of the nano time - The difference between 2 consecutive calls to System.nanoTime() returns a resolution that depends on the

Re: [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Hi folks, I am getting an error with a Travis build of a PR that we have done: log4j:ERROR Could not create the ThrowableRenderer. Reported error follows. java.lang.ClassNotFoundException: com.cloud.utils.log.CglibThrowableRenderer at java.net.URLClassLoader$1.run(URLClassLoader.java:3

Re: [DISCUSS] Improving community experience for (new) contributors

Hello, I think that the stability of the master (and other living branches) is (very) important too. The 2 LGTM requirement can be annoying but if it's permit to have less (regression) bugs and better stability then we can continue in this way IMHO. That said, perhaps we need update this pag

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

GitHub user thinktwo opened a pull request: https://github.com/apache/cloudstack-www/pull/13 Moved Remi to PMC list You can merge this pull request into a Git repository by running: $ git pull https://github.com/thinktwo/cloudstack-www patch-8 Alternatively you can review and

Re: [DISCUSS] Improving community experience for (new) contributors

On Wed, Aug 26, 2015 at 12:09 PM, Rajani Karuturi wrote: > A stable master is very important for new contributors to feel welcomed. This > also saves lot of time for devs who work on acs. > We do not have good test coverage (and we do not have infra to even run the > existing tests against real

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

+1 (binding) sigs and hashes look good. builds fine no binaries present. A few files seem to be missing license headers, but I don't think it's a blocker. License and NOTICE appear to be correct. I wish we pointed to the cloudstack docker hub account rather than the runseb account, but don't thin

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-135085249 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-www pull request: Updated PMC

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-www/pull/12#issuecomment-135084679 LGTMBTW, the github notifications were not going to dev@, that's why we did not see it. It's fixed now. --- If your project is set up for it, you can reply to

RE: [DISCUSS] Improving community experience for (new) contributors

A stable master is very important for new contributors to feel welcomed. This also saves lot of time for devs who work on acs. We do not have good test coverage (and we do not have infra to even run the existing tests against real hardware and hypervisors). Once we have that, we can accept anyth

[GitHub] cloudstack pull request: fix debian package after addition of lice...

Github user ke4qqq closed the pull request at: https://github.com/apache/cloudstack/pull/746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: fix debian package after addition of lice...

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack/pull/746#issuecomment-135080603 LGTM - I am going to close and open to see if Travis will pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: fix debian package after addition of lice...

GitHub user pdion891 reopened a pull request: https://github.com/apache/cloudstack/pull/746 fix debian package after addition of license header in pom.xml PR#737 add lines in pom.xml which break debian build. This fix debian package build issue. You can merge this pull request

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-135079970 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-www pull request: Updated PMC

Github user ke4qqq commented on the pull request: https://github.com/apache/cloudstack-www/pull/12#issuecomment-135079648 @thinktwo Sorry this has languished so long. This LGTM +1@runseb mind giving another +1? --- If your project is set up for it, you can reply to this email an

Re: [DISCUSS] Improving community experience for (new) contributors

On Wed, Aug 26, 2015 at 10:03 AM, Wido den Hollander wrote: > > > On 08/26/2015 03:53 PM, Remi Bergsma wrote: >> Hi Rohit, >> >> Thanks for sharing your observations. I agree with you that anybody that >> contributes (or uses) Apache CloudStack should feel welcome in the community. >> >> In the p

[GitHub] cloudstack pull request:

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/commit/1eb6f929abc3c0e2e2b98da2f0128d637dd0d86e#commitcomment-12905367 In .travis.yml: In .travis.yml on line 28: ping @abhinandanprateek I'm trying to understand the purpo

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135038349 lets just hope we keep this approach from now on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135037251 @miguelaferreira it seems the default directory name 'cloudstack' (which matches the repo name) makes sense to most people, whereas remotes are defined manually

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135033195 @DaanHoogland: @wilderrodrigues will make a PR to remove it --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: [DISCUSS] Improving community experience for (new) contributors

On 08/26/2015 03:53 PM, Remi Bergsma wrote: > Hi Rohit, > > Thanks for sharing your observations. I agree with you that anybody that > contributes (or uses) Apache CloudStack should feel welcome in the community. > > In the past weeks I tried to respond to as many PRs as I could and merge them

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135032095 @miguelaferreira it is proven to be of no use. For what I am concerned we should remove it totally. We can not guarantee any kind of realtime result in/with thi

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135030089 Then everyone should align in the name of the repository directory, while having people align in the name of the remotes was too much to ask. O the irony

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135029036 @miguelaferreira Yes, this is used for the cloudstack-docs project and such. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: unittesting: test resolution is not guara...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/633#issuecomment-135028483 @DaanHoogland @wilderrodrigues @bhaisaab What's the purpose of having this unit test? I've just seen this unit test fail in a travis build

Re: [DISCUSS] Improving community experience for (new) contributors

Hi Rohit, Thanks for sharing your observations. I agree with you that anybody that contributes (or uses) Apache CloudStack should feel welcome in the community. In the past weeks I tried to respond to as many PRs as I could and merge them as soon as it met the requirements. When I can not revie

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-135005019 @miguelaferreira good to know it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: fix debian package after addition of lice...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/746#issuecomment-134991229 Verified that the command works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Re: [DISCUSS] Improving community experience for (new) contributors

Guys, Rafael was slowed down by a new absorbing $dayjob. His contributions have remained a hot item and yes, we shouldn't close anything that is being discussed. As for 2 LGTM being discouraging for new contributors; I think that is up to us. They need one reviewer even without defined process to

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37976062 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- @pdion891 good fix. I would very much more rather relying on the x

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/688#issuecomment-134983872 Sanjeev, thanks! Can you please use the git merge script located in ./tools/git/git-pr? See: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=613

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/688#issuecomment-134972409 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37973943 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- Quick hotfix is in here: https://github.com/apache/cloudstack/pull/74

Re: [GitHub] cloudstack pull request: verify that when createTemplate is ued to...

LGTM!! On Wed, Aug 26, 2015 at 3:01 PM, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/688#issuecomment-134918074 > > LGTM > > > --- > If your project is set up for it, you can reply to this email and have your > reply

[GitHub] cloudstack pull request: fix debian package after addition of lice...

GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/746 fix debian package after addition of license header in pom.xml PR#737 add lines in pom.xml which break debian build. This fix debian package build issue. You can merge this pull request in

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/684#discussion_r37973579 --- Diff: test/integration/smoke/test_routers.py --- @@ -796,3 +830,122 @@ def test_09_reboot_router(self): "Router response after reboo

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/684#discussion_r37973474 --- Diff: test/integration/smoke/test_routers.py --- @@ -796,3 +830,122 @@ def test_09_reboot_router(self): "Router response after reboo

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-134964553 @bhaisaab @remibergsma : Rohit has some good points there and some that can be avoided. Noticably a PR that hasn't gotten any attention from the community shoul

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/684#discussion_r37973271 --- Diff: test/integration/smoke/test_routers.py --- @@ -796,3 +830,122 @@ def test_09_reboot_router(self): "Router response after reboo

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/684#discussion_r37972977 --- Diff: test/integration/smoke/test_routers.py --- @@ -796,3 +830,122 @@ def test_09_reboot_router(self): "Router response after reboo

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134952809 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134952038 @bvbharatk The rebase is needed due to the 'PEP8' style fix that has been done on CsRedundant.py Let me know if you need help :-) --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37968584 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- @pdion891 @miguelaferreira This change broke the debian packaging , be

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134941139 @bhaisaab Yes, willing to do so. I even think that I started to work on this some time ago, but never finished it. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134940325 ah, I see merging now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: [DISCUSS] Improving community experience for (new) contributors

> On Aug 26, 2015, at 12:20 PM, Rohit Yadav wrote: > > Hi all, > > I’ve identified few issues around the recent changes that I don’t know > how we can fix or improve but I hope to get feedback from the > community. > > I understand that you may disagree with what I’m sharing which is > alright

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134938776 @remibergsma @bhaisaab Remi has already tested this and has given the LGTM. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134936732 @insom that was for Wido since he has experience in writing bindings in libvirt-java etc. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134936442 @koushik-das thanks for replying. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134936210 @anshul1886 the only concern here is that this sort of breaks the API behaviour as in the past the details would set details (removing old details). LGTM; w

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134935544 Cool! I would that that once @miguelaferreira is done with the tests and the PR of PR, we can give a 2nd LGTM and then merge it. Thanks, Miguel!

[DISCUSS] Improving community experience for (new) contributors

Hi all, I’ve identified few issues around the recent changes that I don’t know how we can fix or improve but I hope to get feedback from the community. I understand that you may disagree with what I’m sharing which is alright, even in your disagreement I hope that you don’t take an offence on tha

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934893 @ustcweizhou good catch! The idea of that script was to be a simple collection of git commands and assumed that people already understood git. But th

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934361 @remibergsma @karuturi @miguelaferreira The 730.json is empty. I finally find the repoName (folder name) should be "cloudstack". In my env, it it not. I will

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134933068 Thanks @miguelaferreira. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134932710 verified that conntrackd starts on redundant vpc routers. LGTM in that respect. Design wise i feel we need to refactor this, naming of copy_if_ne

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134932108 Not sure if @bhaisaab's comment about improvement is directed at me or @wido. If it was at me, I'd prefer if this could be merged (as it's in the current style and I b

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134931329 @bhaisaab Lost in discussion and got only end result that all we need is here. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964980 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws Resource

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134930757 @karuturi Just tried the code you posted, and this was the result: ```zsh jsonTmp=pr.json prAuthor=$(cat ${jsonTmp} | python -c " try:

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134930046 @bhaisaab I am not sure what was the exact purpose of these agent commands. I believe these existed even before the code was donated to Apache. But if you look a

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929897 We should keep it open though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929830 @bhaisaab this came out from a roadmap item suggested by @pyr, but it seems he has not had time to review and comment. So this is a bit stuck I am afraid. --- If you

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964142 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() { r

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134928152 anyone working on progressing this PR, I really like it and it has some good things; if no one is I can help take over some things in future (cc @rsafonseca) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134929360 @anshul1886 can you read and reply to some of the comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/548#issuecomment-134926126 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

  1   2   >