[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-04 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/775 CLOUDSTACK-8805: Domains become inactive automatically. Handled the '%' case by replacing that with a literal character rather than a wildcard character. You can merge this pull request

Re: Usage Job failed

2015-09-04 Thread mvs babu
Thank you Abhinandan, I will try this. Thank you, Suneel Mallela From: Abhinandan Prateek Sent: ‎Thursday‎, ‎September‎ ‎3‎, ‎2015 ‎9‎:‎42‎ ‎PM To: us...@cloudstack.apache.org Cc: dev@cloudstack.apache.org This support article may help: http://support.citrix.com/article/CTX139043

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-04 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-137719672 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-09-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-137691079 As @DaanHoogland suggested, if one should not see the Netscaler option, then I fix should be put in place where a condition is checked and upon that the

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-09-04 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-137720078 @wilderrodrigues, this change doesn't remove the Netscaler support for VPCs from the UI. The actual Public Load Balancer provider is derived from the VPC offering,

[GitHub] cloudstack pull request: Quota

2015-09-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-137703173 Coverage information of the usage package - usage/src/org/apache/cloudstack/quota: ![screenshot from 2015-09-04 16 13

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/777 config: doc: add default value 10 in description for vm.network.nic.m… …ax.secondary.ipaddresses value hardcoded by commit 4925b9f6a126454215531998c461bf376ac6ab67 You can merge this

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/755#issuecomment-137758483 I am merging this as there are two :+1: Let me know if there are any objections. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/777#issuecomment-137753131 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread vincentbernat
GitHub user vincentbernat opened a pull request: https://github.com/apache/cloudstack/pull/776 sysctl: don't modify /etc/sysctl.conf To configure firewall rules, CloudStack modifies `/etc/sysctl.conf` and execute those modifications. This may be harmful for several reasons:

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137753484 Use a cloud(stack).conf file under /etc/sysctl.d/ seems better and follow the distro philosophy. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137751754 Salut Vincent I agree, but AFAIK there is a `/etc/sysctl.d` directory intended for persistent sysctl configs. What about adding a `cloud.conf` to

Re: Dynamic Scalable Template issue

2015-09-04 Thread Todd Pigram
Ok. After rebooting the instance still no change after disabling globally. I modified all my templates to remove ‘Dynamic Scalable’, then I have to shutdown every instance and unselect ‘Dynamic Scalable’, then restart for it to be correct. This may need to be looked at closer for a

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread vincentbernat
Github user vincentbernat commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137765042 @resmo Yes, it could be in `/etc/sysctl.d` instead (and no sysctl call would be needed). I don't have a strong opinion on this (except in this case, the code

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137813369 Hey...I just noticed something. I have a datastore that I manually added to my ESXi hosts (shared storage) that is based on an iSCSI target.

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137815613 OK, I mainly remembered the issue correctly, but not entirely. The way we avoid this problem (usually) is by looking to see if the datastore starts with

RE: Usage Job failed

2015-09-04 Thread Somesh Naidu
I wrote that article, it was for DB cleanup for 3.x version. I have updated it here for latest versions and added more tables - http://support.citrix.com/article/CTX200918. I believe the error suggests that duplicate entries found when parsing records in table user_statistics for network

[GitHub] cloudstack pull request: Jira ticket CLOUDSTACK-8750

2015-09-04 Thread rafaelweingartner
GitHub user rafaelweingartner opened a pull request: https://github.com/apache/cloudstack/pull/778 Jira ticket CLOUDSTACK-8750 Re-pushing PR 714 (https://github.com/apache/cloudstack/pull/714). We had forgotten a class behind which generated a blocker issue on master (my bad,

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137820920 I see we already do this: dsSummary.isMultipleHostAccess() == false But that doesn't seem to work the way we thought. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137816233 We need a more robust solution. Does anyone know how to detect that a datastore does not reside on the local storage of the host in question? ---

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137816807 Here is the relevant code (in HostMO.java): public List> getLocalDatastoreOnHost() throws Exception {

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-09-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-137843740 Created issue for it: CLOUDSTACK-8811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Heads-up: Serious investigator issue in 4.4

2015-09-04 Thread Remi Bergsma
Hi all, This brought me some serious headaches this week. HA in 4.4.4 (and any 4.4.x version would have this) doesn't do investigations properly due to the Hyper-V investigator returning false instead of null. So, it confirms any VM as down whereas it may be running. Yes, this becomes a mess

[GitHub] cloudstack pull request: Jira ticket CLOUDSTACK-8750

2015-09-04 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-137835347 Something seems to have crashed the JVM during Jenkins build; can someone with access to the server get some extra log files? --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/766#issuecomment-137854742 LGTM Tested it, works great (even without single change to agent.properties). It will reserve 1GB by default. ![before]

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-slowbuild #2230

2015-09-04 Thread jenkins
See Changes: [Rajani Karuturi] CLOUDSTACK-8647: added cmd and response class for the new api [Rajani Karuturi] CLOUDSTACK-8647 added new api linkLdapToDomain [Rajani Karuturi] CLOUDSTACK-8647 changed the authentication

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-09-04 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-137821588 I found an old e-mail from me on this:

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137877024 +1 for /etc/sysctl.d/cloudStack.conf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-04 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-137878960 Is there such case in which domains names have special characters like %? The way you explained the problem it would generate an SQL like this:

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/777#issuecomment-137879562 I do not know if I can give LGTM (I am not a committer), but if I can +1 LGTM. Errors in Jenkins are not related to this commit. --- If your project

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38727056 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/755#issuecomment-137664209 LGTM based on the tracking bugs for addressing some of the issues. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8759 - Destroying VPC router r...

2015-09-04 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/773#issuecomment-137664614 Guys, any other LGTM for this PR? @remibergsma @karuturi @bhaisaab @DaanHoogland Cheers, Wilder --- If your project is set up for it,

Re: Weird Eclipse Issues around com.cloud.utils

2015-09-04 Thread Boris Schrijver
Hi Mike, I had the same problem a couple of days ago, it was due to a refactor of the utils package: https://github.com/apache/cloudstack/commit/83fd8f60f3c503cf6fda7833b0f45c23a215f559 Removing the utils project and importing it again would have solved the issue. Removing all project wasn't

[GitHub] cloudstack pull request: CLOUDSTACK-8690:Added remote access vpn a...

2015-09-04 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/772#issuecomment-137662114 I have step 1 automated, but unfortunately that's the only one. I will keep this PR on my list to test, but other for which the testing is fully automated

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38726623 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + *

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38726468 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38726691 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38731619 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public LdapAuthenticator(final

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-04 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38732126 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: CLOUDSTACK-8759 - Destroying VPC router r...

2015-09-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/773#issuecomment-137682596 code :+1: (Busy with something else and cannot test right now) --- If your project is set up for it, you can reply to this email and have your reply appear on