RE: Blameless post mortem

Thanks for the update Remi! -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Saturday, September 26, 2015 1:21 AM To: dev@cloudstack.apache.org Subject: Blameless post mortem Hi all, This mail is intended to be blameless. We need to learn something from

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445748 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -151,4 +182,38 @@ public void testApplyFWRules() { }

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/890 [4.6]CLOUDSTACK-8912: Fixed listGuestOsMapping doesn't list by id or ostypeid. How to test: 1. Try to listGuestOsMapping by id -> should return the correct entry. 2. Try to

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445206 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh --- @@ -93,4 +93,15 @@ done < $cfg #remove the configuration file, log file

RE: BVT report 9/23

Yes Remi... I will look into the failures and report. -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Friday, September 25, 2015 12:48 PM To: dev@cloudstack.apache.org Subject: Re: BVT report 9/23 Hi Raja, Thanks for the report. Can you please add

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445960 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -123,6 +153,7 @@ public void testApplyRules() { }

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445955 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -100,9 +109,30 @@ public void testInjected() { }

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40446163 --- Diff: server/src/com/cloud/network/firewall/FirewallManagerImpl.java --- @@ -426,7 +426,8 @@ public void detectRulesConflict(FirewallRule newRule)

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445904 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -71,6 +79,7 @@ //super.setUp(); //} +

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40445876 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -52,9 +60,9 @@ import com.cloud.network.rules.FirewallRuleVO;

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40449936 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -71,6 +79,7 @@ //super.setUp(); //}

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40450520 --- Diff: server/src/com/cloud/network/firewall/FirewallManagerImpl.java --- @@ -426,7 +426,8 @@ public void detectRulesConflict(FirewallRule newRule)

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user Pradeepgjain commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-143280968 The NuageVsp plugin functionality is extensively test automated and under daily CI at Nuage Networks. For more info, pls contact prad...@nuagenetworks.net (QA)

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40454232 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -52,9 +60,9 @@ import com.cloud.network.rules.FirewallRuleVO;

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40455108 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -71,6 +79,7 @@ //super.setUp(); //}

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-143352749 @nitin-maharana, you have to create (write) a test case for that. I do not mean to be rude, but those SS do not prove much. You should write a test case

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143353564 ping @remibergsma @karuturi @borisroman @miguelaferreira I executed a few Marvin tests but some manual tests. The changes are working fine and will

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40449738 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -151,4 +182,38 @@ public void testApplyFWRules() {

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40450962 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh --- @@ -93,4 +93,15 @@ done < $cfg #remove the configuration file, log file

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/890#issuecomment-143290823 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Blameless post mortem

Hi all, This mail is intended to be blameless. We need to learn something from it. That's why I left out who exactly did what because it’s not relevant. There are multiple examples but it's about the why. Let's learn from this without blaming anyone. We know we need automated testing. We have

Zone in RegisterTemplateCmd API

Hey guys/gals, I am using Swift as secondary storage, which is cross zones. To register templates, there is a mandatory zoneid field. I have found that if i put zoneid=-1, it will work (mark the templates as cross zones), but it is very unintuitive. This also causes problems using a tool like

Re: Zone in RegisterTemplateCmd API

Hi Patrick, We're using S3 and are facing the same issues. This would indeed be a very good idea. Though I think it will also remove a kind of safety check by making it optional. The solution would be to make zoneId optional and add a optional boolean variable crossZones. If zoneId is empty

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40450212 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -151,4 +182,38 @@ public void testApplyFWRules() { }

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40450011 --- Diff: server/src/com/cloud/network/firewall/FirewallManagerImpl.java --- @@ -426,7 +426,8 @@ public void detectRulesConflict(FirewallRule

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40449856 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -52,9 +60,9 @@ import

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-143282229 @Pradeepgjain can you please provide information about how members of the community can independently test the plugin's functionality? --- If your project is set

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40451212 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -52,9 +60,9 @@ import com.cloud.network.rules.FirewallRuleVO;

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40454164 --- Diff: server/src/com/cloud/network/firewall/FirewallManagerImpl.java --- @@ -426,7 +426,8 @@ public void detectRulesConflict(FirewallRule newRule)

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40454206 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -71,6 +79,7 @@ //super.setUp(); //} +

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/887#discussion_r40450393 --- Diff: server/test/com/cloud/network/firewall/FirewallManagerTest.java --- @@ -52,9 +60,9 @@ import com.cloud.network.rules.FirewallRuleVO;

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143140589 @jayapalu @SudharmaJain can you check this asap, as it merges all your past PRs in one and rebases with master. thanks --- If your project is set up for it, you can

Re: BVT report 9/23

> On Sep 25, 2015, at 8:14 AM, Sebastien Goasguen wrote: > > >> On Sep 25, 2015, at 3:25 AM, Raja Pullela wrote: >> >> Please see inline comments.. >> >>> On Sep 25, 2015, at 1:47 AM, Sebastien Goasguen wrote: >>> >>> On

Re: BVT report 9/23

Hi Raja, Thanks for the report. Can you please add details, so we can see what tests exactly fail? We can then try to reproduce / root cause. Regards, Remi > On 24 Sep 2015, at 21:09, Raja Pullela wrote: > > BVT report 09/23 > > simulator basic - 30% , earlier

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

GitHub user svenvogel opened a pull request: https://github.com/apache/cloudstack/pull/888 Jira: CLOUDSTACK-8812 / CentOS 7 shapeblue upstream 4.5.2 repository - corrected systemd service file You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/889 CLOUDSTACK-8879: Depend in rados-java 0.2.0 This should fix the CloudStack Agent from crashing when it has to handle more then 16 RBD snapshots on one Volume. You can merge this pull request

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143153417 @wido I've force pushed my last commit to let Travis rerun the tests. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143160853 @wido Travis passing fine now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143148262 Seems good to me, in Basic Networking it's not always required. I see that Travis CI timed out, any reason for that? Based on the code a LGTM from me,

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-143194191 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143227931 I successfully tested the patch on 4.5.2: ~~~ 2015-09-25 15:38:11,953 WARN [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-7:ctx-65344d8a)

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-143175301 @remibergsma Oops! I missed that e-mail while working on it this morning. I'll stay off master :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-143175003 Hi @wido please don't merge stuff right now (see http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201509.mbox/browser) It also broke the build, but it

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-143177747 @wido Great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-143233801 Hi @pdion891 Can you let me know what you tested please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-143234582 This broke VPC default gateways, which was fixed in #738. Looking into a solution now. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143237173 @wilderrodrigues and me fixed the default route on VPCs as well. Now doing final testing --- If your project is set up for it, you can reply to this email and