[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172192646 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: build-master-slowbuild #2999

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: [DISCUSS][PROPOSE] use of optional instead of null

Daan, I completely agree that returning null is bad. Not only does it yield a ton of useless null checks, it creates leaky abstractions by spreading the handling of the missing case out beyond the boundary of the class/subsystem. As a big proponent of the Null Object Pattern [1], I really

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r49930246 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -479,13 +479,13 @@ def process(self): def

Build failed in Jenkins: build-master-slowbuild #2998

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-172181790 @nitin-maharana Love you PR details, dude! That's how a PR should be created. :) Ping @remibergsma LGTM, please proceed with

Re: svn commit: r977802 - /websites/production/cloudstack/content/

sad, melancholic moment. On Fri, Jan 15, 2016 at 8:06 PM, wrote: > Author: jlk > Date: Fri Jan 15 19:06:50 2016 > New Revision: 977802 > > Log: > Removing Stratosec from users list > > Added: > websites/production/cloudstack/content/ > - copied from r977801,

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-172188453 LGTM based on code and function- manual test (see screen print) ![screen shot 2016-01-16 at 12 02

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-172191812 @wido @remibergsma Can we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-172196150 @DaanHoogland, I reviewed your code and I have a few suggestions/questions. Are we really going to use final in all of our

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1296#issuecomment-172180650 Ping @remibergsma LGTM, please proceed with merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1291#issuecomment-172181142 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-172197923 Ping @agneya2001 let's get this resolved soon :-) All those build failure mails hurt my eyes.. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-172203787 @DaanHoogland I lost track of the mailing list thread until this PR. In summary, I am -1 on the use Optional based on past experiences. Please see my

Re: [PROPOSAL] LTS Release Cycle

+0, John, I admire your efforts but I would like to see a proposal more in line with our present process for PR merging and releasing. For 4.5 we have a bootstrap problem, here so that would reauire a transistion period (unless we start branding our LTS on 4.7) I also don see the neccesity for

200 PRs open

Please all come to arms. We are in a release phase again since yesterday, with only one RM and 200 PRs open. Please go through your PRs and see if - any improvement is needed - more reviewer are needed - testing is needed - whether it can be closed. A lot of coding is happening and not enough QA

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-172191645 @wido is that a LGTM @schubergphilis ? @rafaelweingartner or any of the other brazilian colleagues? @shapeblue ? --- If your project is set up for

Re: 200 PRs open

Glad to see some movement today! If you want to focus, see my e-mail with ~20 PRs I think should have prio to get in. Will spend some time tonight to browse through them and merge those that are ready. Regards, Remi Sent from my iPhone > On 16 Jan 2016, at 11:57, Daan Hoogland

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1298#issuecomment-172181476 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1276#issuecomment-172181356 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1299#issuecomment-172181534 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9216: Fix DHCP lease removal l...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1318#issuecomment-172181655 Sat together with @borisroman when he was working on it. LGTM Ping @remibergsma Please proceed with merge. Cheers, Wilder

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-172191471 @wilderrodrigues @remibergsma I stopped using xen at this point. Do I keep this PR open. To me it is to much of a hobby project to invest in it atm. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9120 READ.ME files describing ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1202#issuecomment-172191512 @remibergsma do I need to promote this? it is purely to describe what is in the test dirs and holds no execution value. --- If your project is set up for it,

Build failed in Jenkins: build-master-slowbuild #3003

See Changes: [miguelferreira] Prevent NullPointerException when host does not belong to a pod [miguelferreira] Fix log message that refers to agent, not host [miguelferreira] Implement CheckHealthCommand for NSX

Build failed in Jenkins: build-master-slowbuild #3004

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-172176953 Ping @remibergsma If you get a second LGTM, feel free to merge. Cheers, Wilder --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

GitHub user wilderrodrigues reopened a pull request: https://github.com/apache/cloudstack/pull/1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188 This PR applies the same fixes as in the PR #1259, but against branch 4.7. Please

[GitHub] cloudstack pull request: [4.7] ADD Force UDP encapsulation option ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1317#issuecomment-172181688 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-172182133 No, these are disposible test enviroments. They are at two different companies (Schuberg Philis and Leasweb) but as the test code has no relation to the change

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-172191244 pinging possibly other interested parties @jburwell @wido @jlk @bhaisaab I think we want to use the java optionals instead but interested in opinions on

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1288#discussion_r49930663 --- Diff: ui/plugins/plugins.js --- @@ -16,7 +16,7 @@ // under the License. (function($, cloudStack) { cloudStack.plugins = [ -

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172191734 @bhaisaab we do not have anything better the sonarqube atm. so let's listen to it. --- If your project is set up for it, you can reply to this email and have

Re: svn commit: r977802 - /websites/production/cloudstack/content/

Should be done in git though, no? Erik Den lørdag 16. januar 2016 skrev Daan Hoogland følgende: > sad, melancholic moment. > > On Fri, Jan 15, 2016 at 8:06 PM, > wrote: > > > Author: jlk > > Date: Fri Jan 15 19:06:50 2016 > > New

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-172194485 Based on the code yes, @DaanHoogland . Couldn't run any tests on it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-172241961 @ustcweizhou @DaanHoogland Will test this soon. Can you please add that the size that one needs to specify is in GB? Didn't look so I had to look that up ;-)

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-172234191 @rafaelweingartner @DaanHoogland, Personally, I don't see a problem using final declarations for those attributes. They all do seem to contain information

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1342#issuecomment-172243612 LGTM, the UI shows fine and the value is passed to the API as shown in screenshot. See comment above, please add "GB" after the field.

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-172245080 @DaanHoogland Did I miss the integration tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-172214758 @DaanHoogland That's a really interesting feature which I wasn't aware of. I'm afraid I'll be out of commission for most of today but I'd love to try it out

Build failed in Jenkins: build-master-slowbuild #3000

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-172246077 @koushik-das @DaanHoogland You both reviewed this PR. What do we need to do to get it in? Those are critical fixes I want in the next releases. Thanks! --- If

Build failed in Jenkins: build-master-slowbuild #3001

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: [4.7] ADD Force UDP encapsulation option ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-172245992 @DaanHoogland Can't test it as we don't use security groups. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-172240147 @DaanHoogland @syed I've opened a pull request containing some simple javadocs to @syed's swift-restart-fix branch. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-172244406 This page has some interesting background: http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers It

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1293#issuecomment-172247195 Tested it and works well in our environment. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172247247 Haven't seen the issue in our production cloud since we run with this fix. Thanks! LGTM. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9120 READ.ME files describing ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1202#issuecomment-172248713 @DaanHoogland I'm OK with putting them there, but please make them consistent. Add header on top, then the message on the bottom. --- If your project is set

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1293#issuecomment-172248684 LGTM :+1: Been running in beta for a couple of weeks now, no problems! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-172259203 Thanks @remibergsma ! That is the same reasoning as @kevindierkx and me had while looking into this. We went for 2k for now as it seems to match almost 100%

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-172261361 btw it also is based on exoscale production code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-172261313 @remibergsma the api was tested in sg. We can run a full regression suit if you feel it is needed. I don't feel we need to test anything but the call with

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-172261703 LGTM, based on manual functional testing in advanced zone with security groups. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-172248830 @pvr9711 I guess you know what we need before merge, don't you? ;-) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-172254915 @jayapalu That didn't help unfortunately. Also, there is now a conflict. Can you resolve it please? --- If your project is set up for it, you can reply to this

Re: Pull Requests we should include in 4.7.1 / 4.8.0

Update: We managed to get several PRs merged today thanks to a series of reviews. Great! I updated the list below in the original mail. I do want to point some attention to these PRs: #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188

Build failed in Jenkins: build-master-slowbuild #3002

See Changes: [Remi Bergsma] CLOUDSTACK-9202 Bump ssh timeout [Remi Bergsma] CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh [Remi Bergsma] make both check lines consistent [Remi Bergsma] CLOUDSTACK-9204 Do not

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-172259457 @remibergsma We have this one running in production right now and it is working as expected. I spent some time in trying to get a test-case up and running,

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-172250734 @remibergsma @DaanHoogland This PR doesn't contain the commit that @koushik-das voted -1. So, it's good to go. I just double checked in

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-172250789 Thanks @wilderrodrigues happy we can move on now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-172260184 looked at the code. python LGTM. The reformat seems unneeded, it seems the java code does not contain any change but reformat and making stuff final. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1329#issuecomment-172247093 LGTM :+1: delaycompress isn't usefull. The VR has limited space, so delaying the compression of the logfiles won't help! --- If your project is set

[GitHub] cloudstack pull request: NicProfileHelperImpl NullpointerException...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1328#issuecomment-172247094 Just did a code review, but I also pointed @borisroman to the test code when he was working on it. LGTM... please, proceed with the merge

[GitHub] cloudstack pull request: CLOUDSTACK-9222 Prevent cloud.log.1 filli...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1329#issuecomment-172247143 Cool! Finally we got it! LGTM! Please, merge it @remibergsma ! Cheers, Wilder --- If your project is set up for it, you can

[GitHub] cloudstack pull request: NicProfileHelperImpl NullpointerException...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9216: Fix DHCP lease removal l...

Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-172261610 I agree we need to fix some issues like this , which is difficult to be reproduced but it is obviously an issue from code view. --- If your project is set up

Build failed in Jenkins: build-master-slowbuild #3005

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check