[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-208676729 @kiwiflyer woohoo!!! thank you for all the support on this. i will merge this in the morning with my next batch. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-208661647 @swill - I force pushed it again and Jenkins is finally passing. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-208652206 Does the “CsHelper.execute” logs the commands being executed and their outputs? If not, what about adding logs to show the routes that are being

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1470#discussion_r59294770 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -300,6 +303,8 @@ public ExecutionResult

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1470#discussion_r59294795 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1470#discussion_r59294765 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -292,6 +292,9 @@ public ExecutionResult

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1470#discussion_r59294640 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Remove unused images

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208591476 Can you either close and reopen or do a `push -f` to try to kick off travis. I am confident in this PR, but I want everything green before we merge... Thank you

[GitHub] cloudstack pull request: Handle private gateways more reliably

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-208590690 I will add this to my CI queue. Do we want to maintain commit history for the two commits in this case? Also, I am looking for code reviews on this one.

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1470#discussion_r59290164 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-208581097 This seems like a reasonable change to me. I am guessing 2 seconds is long enough, but I don't really understand what other variables could add contention and could

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-208579371 @remibergsma can you give me a `push -f` on this to try to kick off Jenkins again. Thx... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-208579265 Can I get one more person to give me a LGTM on this? I am confident with the tests provided for this change and I will count my LGTM review on this PR. --- If your

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-208578340 Can I get some code reviews on this PR? I have added it to my CI queue... --- If your project is set up for it, you can reply to this email and have your reply

Re: Travis Failing

Hmmm. I am unable to reproduce this locally. I need to look deeper. Rohit, do you have any ideas on this? *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Mon, Apr 11, 2016 at 4:13 PM,

Re: Travis Failing

Could this be related to the following test errors? Tests run: 13, Failures: 0, Errors: 13, Skipped: 0, Time elapsed: 0.055 sec <<< FAILURE! - in com.cloud.api.ApiServletTest *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208535036 @GabrielBrascher yes, this is something that we are trying to work through. We have updated the source to give more verbose logging so we can better understand the

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208533273 Travis keeps with the issue *missing file/directory '/home/travis/build/apache/cloudstack/tools/marvin/dist/Marvin-***.tar.gz*'. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-208522087 @remibergsma Is this exactly the same PR as the one Wilder closed last week, or does it have some changes in it? Also, there are some comments

Re: Re. ACS PRs Status - 2016/04/11

Yep, no problem. Thanks for the heads up... *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Mon, Apr 11, 2016 at 10:49 AM, Lv Haijiao wrote: > Hi, Will > > Can you

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-208521278 We still need LGTM code reviews for this PR and I will add this to my queue for CI. Thanks... --- If your project is set up for it, you can reply to this email and

Re. ACS PRs Status - 2016/04/11

Hi, Will Can you put #1410 'fix issue disk I/O throttling not applied' (CLOUDSTACK-6928) on your radar too ? thanks!

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208506356 new integration run pending --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: speedup iptables setup

Github user kollyma commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-208506127 During commit squashing something went wrong.. i could not revert. Here a new Pull request with exactly the same changes. Sorry for any inconvenience caused.. and

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-208504591 So my understand is there was a FindBugs issue originally. In the process of fixing the issue, some logic was changed to introduce an issue. This commit is to

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

GitHub user kollyma opened a pull request: https://github.com/apache/cloudstack/pull/1487 speedup iptables by prefetching the variables -- This PR is replacing speedup iptables setup #1449 -- Squashing commits and cleanup PR against 4.7 as discussed with Remi Bergsma.

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208486444 Based on the tests I see above LGTM. A new PR afterwards to rename seems good. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208484921 I'm not sure of the history for that particular file, but I believe it would be better named DefaultSnapshotStrategy. Does anyone else have a better

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208484491 @wido Yes, the name is no longer valid, but it should work just fine for KVM. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-208477870 ### CI bubble run **Commit Reference: 30741a3309da346f324a8f365cb6ef8e1aab39d8** Looks good to me --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-208475514 @jburwell I am not saying FindBugs issues should be suppressed in general. As part of fixing FindBugs issues some functionality got regressed (refer PR

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208439532 LGTM based on hardware lab testing of feature on 4.8 branch with PR applied. Wido, As far as I can tell, the changes to

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208438657 Lab testing of feature: Cloudstack RBD snapshot job: 2016-04-11 11:26:22,955 DEBUG [c.c.a.t.Request] (Work-Job-Executor-1:ctx-5ac9d6c8

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user GabrielBrascher closed the pull request at: https://github.com/apache/cloudstack/pull/1263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

GitHub user GabrielBrascher reopened a pull request: https://github.com/apache/cloudstack/pull/1263 Removed unused code from com.cloud.api.ApiServer **Removed “\_” from variables names**: private variables with “\_” at the beginning is common in C++ but not in Java.

[GitHub] cloudstack pull request: Remove unused params from NetworkHelperIm...

Github user GabrielBrascher closed the pull request at: https://github.com/apache/cloudstack/pull/1484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Remove unused params from NetworkHelperIm...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1484#issuecomment-208435439 @GabrielBrascher I think it is better to close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-208431289 +1 based on code review and test results posted by @bvbharatk. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1287#discussion_r59233185 --- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java --- @@ -200,52 +167,43 @@ public String getSecIpsString() { return

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1287#discussion_r59231793 --- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java --- @@ -200,52 +167,43 @@ public String getSecIpsString() { return

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-208421003 @mike-tutkowski I will re-review the patch later today (11 April 2015). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-208417118 @mike-tutkowski ``null`` values in a ``Map`` are extremely ugly. It seems like filtering them at the time a ``Map`` is created would make things simpler overall

[GitHub] cloudstack pull request: Remove unused params from NetworkHelperIm...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1484#issuecomment-208411575 Thanks for noting @pedro-martins. As you stated this issue before, I will close mine PR. Unless you think that another of proposed modifications are

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-208410974 @koushik-das I am a hard -1 to a ``@SupressWarnings`` because it will never get fixed. Was the FindBugs issue present before this patch? If so, it would be

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-208405525 How about suppressing the findbug issue (using something like @SuppressWarnings) till someone comes up with a proper fix? In that case there won't be any mails

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208402795 Thanks @serg38 @rafaelweingartner. I rebased master branch and pushed again --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208401827 @DaanHoogland, @swill commits squashed. I preserved the @cristofolini commit, though. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208397525 @DaanHoogland, I agree with Will. The last commit should be squashed. I will do that. @swill I would not like to give an LGTM here, because

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208393777 @serg38 thanks, now it is clear to me. Thanks for the great job. BTW: it seems that travis is with problems again. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208387324 @rafaelweingartner. That's correct. 3 indexes: 1 - primary + 2 unique indexes, all based on ID column. Those 2 unique indexes are not needed and only consume disk

Re: ACS PRs Status - 2016/04/11

Hey Will, Jenkins seems to be broken currently for the 4.7 branch: FATAL: Could not checkout 4.7 with start point origin/4.7 hudson.plugins.git.GitException: Could not checkout 4.7 with start point origin/4.7 at

Re: ACS PRs Status - 2016/04/11

Yes, we saw something similar on master as well. Daan was looking at it. He thinks there is likely a problem with the checkout directory. I will be monitoring this and working to get Jenkins back to good. I require Jenkins and Travis to be green for all merges, so this being broken will stop me

ACS PRs Status - 2016/04/11

Here is this Monday's weekly status update. Jenkins and Travis were a bit flaky last week, so I will be keeping an eye on that and will be doing what I can to get those environment stabilized. Please note that I am trying to keep up on the statusus, but if I am wrong, I appologize... ACS PRs

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208361233 @NuxRo asked that I review this. @DaanHoogland I see you opened this, would you mind rebasing. I suspect it is still valid considering the fact that not a huge

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208347246 Some history is fine, but we don't need the whole history for every change in master. I don't think this adds much by adding it to the master commit tree:

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-208344314 Squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1066 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts:

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208339528 @GabrielBrascher could you please close and re-open this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208332183 can be a polution of the workspace (I'll clean it) or a jenkins having a different git loaded then is on disk. I've seen the last one once before on an

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1458#issuecomment-208331373 HI, Thanks for your review comment and i ran the few tests on the created setup even though it won't impact the any testcases but for your request i

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208330435 @DaanHoogland do you know what is going on with jenkins in this case? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208329721 Will, I don't like manic squashing, why not preserve history. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208328877 Can I get the commits squashed and repushed with `push -f`. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208327658 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-208326140 I am going to add this to my CI queue. Please reconfirm the LGTM's votes based on the updated code. Thanks... --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-208322941 @kiwiflyer Sorry to do this to you, but would you mind squashing your commits and doing a `push -f` again? Thanks... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1441 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9343 Removed unused parameters...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1447#issuecomment-208320181 @pedro-martins I noticed you updated this PR with a Jira ticket. Could you elaborate a little bit more on how you found these unused variables?

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208319965 @nux, it probably doesn't apply anymore. This PR is 4 months old :( --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1462 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: travis: increase build verbosity

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-208318739 @syed, you can change the method to be protected. IMO every single method that has some logic in it should be tested without any discrimination among

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208318271 Daan, How did you test? I'm trying to apply the patch to either 4.8.0 or master and on neither it does so cleanly: Hunk #7 FAILED at 467. 1

Re: PRs for 4.9 Release

Yes I can do that. I will write that this week. On Apr 11, 2016 5:27 AM, "chunfeng tian" wrote: > hi Will, > > I have free hardware( mini centos 7 cluster ) , and I want to help improve > the CI process . > > Could you write a how-to step by step document on this topic

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208285159 Thanks @serg38, You answer helped a lot. I just do not fully understand the deletion of the indexes, for instance, you delete index “id” and

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r59177413 --- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java --- @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF)

Re: PRs for 4.9 Release

hi Will, I have free hardware( mini centos 7 cluster ) , and I want to help improve the CI process . Could you write a how-to step by step document on this topic and post on http://cwiki.apache.org/confluence/display/CLOUDSTACK/ ? thanks On Sun, Apr 10, 2016 at 6:36 AM, Nux!

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-208196999 @mike-tutkowski @kiwiflyer So, it is just the class which has a incorrect name? The code is good? --- If your project is set up for it, you can reply to this email

RE: Travis Failing

The failure suggests some unit test might have failed causing the build to fail, causing Marvin distribution to be not built. I have sent a PR that adds verbosity to the Travis build. Regards. Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden,

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-208176655 @rafaelweingartner Updated the comment as a javadoc. For the test. I am not sure what the best strategy is. Maybe you can help me understand better. Would

Re: [DISCUSS] Request for comments : VPC Inline LoadBalancer (new plugin)

Kris and Nick Noticed an update in the FS: >> The VPC Inline LB appliance therefore is a regular System VM, exactly the same as the Internal LB appliance today. Meaning it has 1 guest nic and 1 control (link-local / management) nic. This should be ok. The premise behind my concern was - if LB