Github user jburwell commented on the pull request:

    https://github.com/apache/cloudstack/pull/1363#issuecomment-208410974
  
    @koushik-das I am a hard -1 to a ``@SupressWarnings`` because it will never 
get fixed.  Was the FindBugs issue present before this patch?  If so, it would 
be unfair to block it because developers could be forced to fix a pile of 
preexisting and nothing would more forward.  However, if this FindBugs issue 
was introduced by this patch, then it needs to be fixed before it can be 
merged.  The whole point of the static analysis checks is prevent new issues 
from entering master.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to