[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76496565 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76496527 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76494735 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76494274 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76494135 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76493975 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76493886 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @jburwell some of them skipped due to missing hardware or conditions (as tests ran on KVM which has no gpu support etc), the failed tests are failing in general on master. I'll review and

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76484499 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76484431 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76484318 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76482524 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76482410 --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py --- @@ -0,0 +1,887 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1659#discussion_r76481464 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -884,6 +884,13 @@ def processStaticNatRule(self, rule): device =

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1660 @nvazquez the Jenkins build failed. Could you please investigate and fix any issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1660#discussion_r76476168 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String user,

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1638 @rhtyd have you had a chance to review the test cases with errors and skips? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1660#discussion_r76477326 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String user,

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1660 I looked at the class, while it can have further refactoring improvements, fwiw LGTM. /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1660 Done, thanks @rhtyd for your help, it was really useful! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Martin, I checked my openssl connect output and my management server on port 8250 was indeed returning valid certificates. On further investigation, when connections to management server (NioServer, handled by Link class that reads /etc/cloudstack/management/cloudmanagementserver.keystore)

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Martin, Alright based on the logs, the error 'possible truncation attack?' along with openssl connect output hints at SSL keystore/encryption issue. Can you try what Simon suggests? Alternatively, while searching for this error some people have reported that their error went away when

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 Alright, given the reviews and that all changes have been incorporated with exhaustive testing with Ubuntu and CentOS I'll proceed with merging this without blocking 4.9.1.0 RC much further.

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1663 CLOUDSTACK-6432: Prevent DNS reflection attacks CLOUDSTACK-6432: Prevent DNS reflection attacks DNS on VR should not be publically accessible as it may be prone to DNS

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1660 @nvazquez okay, there are many ways to do this. Here's how you can do it fairly easily without merge conflicts: git checkout git format-patch -1 # this will create a .patch

Re: CS 4.9 NIO Selector wait time PR-1601

I wonder whether your ssl keystore is corrupt or just missing. Does /etc/cloudstack/management/cloudmanagementserver.keystore exist? If I remember correctly, you can remove this and also remove ssl.keystore from the configuration table and restart the management to have them regenerated. I

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1660 Hi @rhtyd, it would be nice to include it in 4.9. I tried rebasing branch 4.9 but it tries to update poms to 4.10 version, what do you suggest me to do? --- If your project is set up for it,

Re: Virtual Router : Marvin test gap analysis

Raja, Thanks for sharing insightful automation analysis. We are trying to figure out how to convert our efforts in to actionable items. As community we can work on them to get good automated test suite for VR. Will be sharing details early next week. Thanks. On 19/08/16, 2:25 PM, "Raja

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 LGTM for testing Before sshClient: DEBUG: {Cmd: ping -c 3 8.8.8.8 via Host: 10.140.12.103} {returns: [u'PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.', u'64 bytes from 8.8.8.8:

Re: CS 4.9 NIO Selector wait time PR-1601

good point, thanks Simon! with openssl we receive a response on port 8250. # telnet 10.100.12.10 8250 Trying 10.100.12.10... Connected to 10.100.12.10. Escape character is '^]'. Connection closed by foreign host. # nc -zv 10.100.12.10 8250 Connection to 10.100.12.10 8250 port [tcp/*] succeeded!

Re: CS 4.9 NIO Selector wait time PR-1601

Martin, Are you able to actually telnet to 8250 from the host to the mgmt server? - Si From: martin kolly Sent: Friday, August 26, 2016 9:41 AM To: dev@cloudstack.apache.org Subject: Re: CS 4.9 NIO Selector wait time PR-1601 Hi

Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit We highly appreciate your efforts! Unfortunately it still does not work. - ulimit is increased on mgmt server - jar file replaced - we confirm that cloudstack-agent 4.9.0 is installed *MGMT Server* # wget

[GitHub] cloudstack issue #1663: CLOUDSTACK-6432: Prevent DNS reflection attacks

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1663 New smoke test result: $ nosetests --with-xunit --xunit-file=integration-test-results.xml --with-marvin --marvin-config=/home/bhaisaab/Lab/apache/marvin-cfgs/adv-kvm.cfg -s -a

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1645 @jburwell @si @wido Here are the results of the nosetests. One test did throw an exception during teardown, but I am not sure that this is anything to be concerned about.

[GitHub] cloudstack pull request #1663: CLOUDSTACK-6432: Prevent DNS reflection attac...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1663 CLOUDSTACK-6432: Prevent DNS reflection attacks At least in SG zones DNS on the VR is publicly accessible and as such susceptible to DNS amplification/reflection attacks. This fixes it as per

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1660 @nvazquez @serg38 does this also affect 4.9, if so please edit the base branch to 4.9. We should have this in 4.9/lts release. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1643 Thanks @abhinandanprateek LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76393992 --- Diff: packaging/systemd/cloudstack-agent.default --- @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1643 @rhtyd rebased with 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

Github user vincentbernat commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1647#discussion_r76392345 --- Diff: packaging/systemd/cloudstack-agent.default --- @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...

GitHub user milamberspace reopened a pull request: https://github.com/apache/cloudstack/pull/1636 Fix a quote issue with Spanish L10N (from transifex translation) This fix is for the 4.8 branch. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request #1636: Fix a quote issue with Spanish L10N (from tra...

Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/1636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido @vincentbernat and others -- any objections, this is good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1643 @abhinandanprateek please edit the base branch to 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not