Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1957
tested. LGTM
btw, you can use "git push --force" to overwrite the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Will, any specific use-case? For a live running cloudstack an apidocs plugin
could also be written that displays apidocs for a role/user-account consuming
from listApis.
Regards.
From: williamstev...@gmail.com on behalf of Will
Stevens
Sent: 21 February 2017
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
I'll try to make my point clearer with a better use case. Let say you were
running version ACS 4.4.2 and wish to upgrade to 4.7.1. After installing the
4.7.1, when ACS starts for the first ti
GitHub user Ashadeepa opened a pull request:
https://github.com/apache/cloudstack/pull/1959
CLOUDSTACK-9786:API reference guide entry for associateIpAddress needs
additional information
Going through the code & implementation, it seems like either of the
parameters are not required
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1958
CLOUDSTACK-5806: add presetup to storage types that support over provâ¦
â¦isioning
Ideally this should be configurable via global settings
You can merge this pull request i
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1935
Trillian test result (tid-876)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35807 seconds
Marvin logs:
https://github.com/blueoranguta
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@serg38 Not sure to understand what you mean with:
> If I get it right with your proposed changes, upgrade scripts become
obsolete since all the changes can be done in upgrade scripts.
Github user Ashadeepa commented on the issue:
https://github.com/apache/cloudstack/pull/1957
@rafaelweingartner : This is due to the change in my remote urls. Closing
the old PR https://github.com/apache/cloudstack/issues/1910.
---
If your project is set up for it, you can reply to t
Github user Ashadeepa closed the pull request at:
https://github.com/apache/cloudstack/pull/1910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner I think I got your point, I tried to keep code as
similar as it was before, by declaring `rollBackState` as static class variable
on line 114. This way inner `finally` block
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Trillian test result (tid-877)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26001 seconds
Marvin logs:
https://github.com/blueoranguta
Sergey Levitskiy wrote:
> Actually, minor correction. When adding to VM/templates the name of the
> detail is rootDiskController for Root controller and dataDiskController
> for additional disks.
> Also, if you want to make changes on a global scale the changes need to
> go to vm_template_d
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
There are not failed test cases on CI run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Actually, minor correction. When adding to VM/templates the name of the detail
is rootDiskController for Root controller and dataDiskController for additional
disks.
Also, if you want to make changes on a global scale the changes need to go to
vm_template_details and user_vm_details tables respe
Sergey Levitskiy wrote:
> Here it is the logic.
> 1. Default value is taken from a global configuration
> vmware.root.disk.controller
> 2. To override add the same config to template or VM (starting from 4.10
> UI allows adding advanced settings to templates and/or VMs). If added to
> a
Here it is the logic.
1. Default value is taken from a global configuration
vmware.root.disk.controller
2. To override add the same config to template or VM (starting from 4.10 UI
allows adding advanced settings to templates and/or VMs). If added to a
template all VMs deployed from it wil
Sergey Levitskiy wrote:
> On vmware rootdiskcontroller is passed over to the hypervisor in VM start
> command. I know for the fact that the following rootdiskcontroller option
> specified in template/vm details work fine:
> ide
> scsi
> lsilogic
> lsilogic1068
>
> In general, any scsi control
On vmware rootdiskcontroller is passed over to the hypervisor in VM start
command. I know for the fact that the following rootdiskcontroller option
specified in template/vm details work fine:
ide
scsi
lsilogic
lsilogic1068
In general, any scsi controller option that vmware recognizes should work
Wido den Hollander wrote:
>
>> Op 25 januari 2017 om 4:44 schreef Simon Weller :
>>
>>
>> Maybe this is a good opportunity to discuss modernizing the OS
>> selections so that drivers (and other features) could be selectable per
>> OS.
>
> That seems like a good idea. If you select Ubuntu 16.0
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1861
ping @karuturi @koushik-das
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102342529
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -584,18 +584,36 @@ public void defFileBasedDisk(Stri
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102336557
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1875
@sateesh-chodapuneedi @rhtyd Please review the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1875
@rhtyd Thanks for running tests. The test failures/errors above are failing
in other PRs as well, not related to the changes in this PR.
---
If your project is set up for it, you can rep
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1954
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@remibergsma Same MAC for RVR has been re-introducted as part of
[CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It
confirms that peer NICs of RVRs should have sam
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut Can you do a force push to kick off jenkins again. I'm guessing
Jenkins just had an issue and not the PR.
---
If your project is set up for it, you can reply to this email and have you
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@nvazquez great work.
However, there is a catch there that I think you might have overlooked.
This problem is caused by the method extraction I suggested.
If you take a loo
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sateesh-chodapuneedi @rhtyd Please review the code changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd Thanks for running these test. The failures/errors are not related
to this PR changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@jburwell That was default behavior for few years to allow deletion of the
template even if active VMs exist. Deletion of the template on secondary
doesn't remove the template copy on primary sto
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner thanks for reviewing! I extracted code to new methods
and also added unit tests for them
---
If your project is set up for it, you can reply to this email and have your
repl
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1897
@koushik-das @kishankavala Please review the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1897
@ramkatru Checked and addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Packaging result: âcentos6 âcentos7 âdebian. JID-521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@marcaurele I tend to agree with @rhtydthat it could break some of the
upgrades. If I get it right with your proposed changes, upgrade scripts become
obsolete since all the changes can be done in
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102310842
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1875
Trillian test result (tid-867)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48400 seconds
Marvin logs:
https://github.com/blueoranguta
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@borisstoyanov Can you kick off Jenkins job on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102311697
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -716,11 +734,6 @@ public DiskFmtType getDiskFor
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@remibergsma @borisstoyanov Updated the KVM code to generate the valid
device name above id 25.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102310032
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102309898
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102309517
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102309146
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1879
Trillian test result (tid-869)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46839 seconds
Marvin logs:
https://github.com/blueoranguta
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102308166
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102305779
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Trillian test result (tid-875)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27492 seconds
Marvin logs:
https://github.com/blueoranguta
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303566
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303488
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303229
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Trillian test result (tid-874)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34092 seconds
Marvin logs:
https://github.com/blueoranguta
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102302052
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301869
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301645
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1935
Packaging result: âcentos6 âcentos7 âdebian. JID-520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102300083
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102298974
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1861
yes @sateesh-chodapuneedi this failure has been a pain for a while... it'll
be good to invest some time in fixing it..
---
If your project is set up for it, you can reply to this email an
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102295771
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102294407
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102292787
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102291066
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102290456
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final V
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102289931
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(fina
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
@Ashadeepa why do we have 2 PRs for the same problem?
It seems that one of them can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@sureshanaparti why do the mac addresses need to be the same on both
routers? We're also executing arpings to update our neighbours. Networking wise
there is no need for them to be the same.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1878
Trillian test result (tid-873)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33766 seconds
Marvin logs:
https://github.com/blueoranguta
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102264841
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup) {
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102265306
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup) {
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102265150
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup) {
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1948
@ProjectMoon may I ask you a question?
The "net" object is already an array/map, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1949
Trillian test result (tid-872)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29754 seconds
Marvin logs:
https://github.com/blueoranguta
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1948
Trillian test result (tid-870)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33543 seconds
Marvin logs:
https://github.com/blueoranguta
Ah, great.
Thanks for clarifying that for me.
On Tue, Feb 21, 2017 at 11:44 AM, Daan Hoogland
wrote:
> No Rafael the other way around,
>
> The first time you call it it might change things, but no matter how
> often you call it it will have changed in exactly the same way.
>
> On Tue, Feb 21, 2
No Rafael the other way around,
The first time you call it it might change things, but no matter how
often you call it it will have changed in exactly the same way.
On Tue, Feb 21, 2017 at 5:41 PM, Rafael Weingärtner
wrote:
> I think this might be others doubt as well. Sorry if it seems a naïve/
I think this might be others doubt as well. Sorry if it seems a naïve/silly
question.
By idempotent, I understand something that you can make as many operations
as possible and it does not change (broadly speaking). For example, (in
theory), when you do an HTTP Get requests, the response would be
On Tue, Feb 21, 2017 at 3:19 PM, Marc-Aurèle Brothier wrote:
>
> Daan, the project maintainers should enforce that. I also posted another
> finding that the upgrade path are not identical due to the order in which
> upgrade files are executed, see (https://github.com/apache/
> cloudstack/pull/1768
Github user serbaut commented on the issue:
https://github.com/apache/cloudstack/pull/1915
Ok. I removed it from rsyslog since it should be safe there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/1915
We always want `compress` ... but the only time you need or want
`delaycompress` is if you can't be sure that the program writing to the log can
be successfully told to stop appending to that
Github user serbaut commented on the issue:
https://github.com/apache/cloudstack/pull/1915
Is it safe to remove delaycompress across the board, I assume it is there
for a reason?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r102226833
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2071,6 +2120,14 @@ protected StartA
I'm also in favor of Liquibase.
Hibernate might be smart enough to add new columns,
but to be able to for example change the type of a column,
more complex data migration might be necessary.
Liquibase preconditions, combined with good identifiers
make up that upgrades will be more granular.
*Fran
Is there any chance we can fix the 'roles' issue with the API doc so we can
get the docs split into the 'Admin', 'Domain Admin' and 'User' again? The
introduction of the dynamic roles broke the generation of the API docs with
the different roles and I was not able to figure out how to fix it. Any
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1955
We are deploying this to our QA environment right now and hope to have it
tested in a few days. Great work @kiwiflyer and @nathanejohnson.
---
If your project is set up for it, you can reply to
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut I agree with @ustcweizhou. Please remove delaycompress and up to
10. I'd like to get this PR in as it is the second part of the problem
resolution for my issue. After that LGTM.
---
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1957#discussion_r10411
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -621,6 +627,10 @@ public void
doInTransactionWithoutResult(Transact
Github user Ashadeepa commented on the issue:
https://github.com/apache/cloudstack/pull/1957
@ustcweizhou : My bad. Amended the changes . Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Jeff, I do wonder the same thing about the ORM... I hit the ORM limitation
in many places now without being able to do joins on the same table
specifically for capacity check, and you can see in the code many hand made
SQL query on that part. I think the views came into the pictures for the
same re
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@rhtyd Changing the sequence is only idempotent if you have been upgrading
to each new versions step by step. If you jumped other versions, then the path
is different for each original versio
http://stackoverflow.com/questions/10895969/can-newer-jre-versions-run-java-programs-compiled-with-older-jdk-versions
You can run code compiled by the java 1.7 or 1.6 or earlier SDKs on a
Java 8 JVM.
This gets you the improved speed of the Java 8 JVM even if you do not
rebuild the code.
If
1 - 100 of 139 matches
Mail list logo
