Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435795
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -131,54 +127,55 @@ public static void publishUsageEvent
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435785
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -38,44 +34,37 @@
import
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164178352
@bhaisaab @priyankparihar what is the verdict on this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164178250
@nitin-maharana @bhaisaab both I and @remibergsma don't work with vmware as
part of our cloudstack installs, can you do testing and preferably write tests
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-164177131
@priyankparihar these are nice results but I have no way of verifying the
latter is actually the good result. can you write a test that proves proper
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164176274
As an operator I want this in :p have only read the feature description in
jira and the diff but lgtm based on that and @remibergsma his test results
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164159535
40G sounds like an old fs limit. doesn't make sense nowadays.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164159167
@milamberspace Dutch complemented
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47431643
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java
---
@@ -0,0 +1,35 @@
+package
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-164150715
code LGTM and @remibergsma his test succeed, as this is in 4.5 I think it
must go in 4.6 as well, however it contains way to little tests and can not be
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164148706
lgtm, doing a test build, now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1211#issuecomment-164148314
LGTM, thanks for testing @remibergsma. I am going to trust on sight and as
this as it is a port from the custom leaseweb code in 4.2.1.
---
If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1227#issuecomment-164147061
LGTM, this is why we want to be merging code instead of rebasing, no more
commits on master! only merges!
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1182#issuecomment-164146578
LGTM based on the code. It does implement a use case that should be tested.
not sure if we need it in this PR
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164069434
did a test build:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/859#issuecomment-164062856
@kishankavala in your test case you are creating two UsageNetworkOfferings
and then assure that two are persisted. How does this test two nics being
created
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164016942
This where and why the vpc vr refactor started, isn't it? code lgtm, let's
have a regression test and put it in!
---
If your project is set up f
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-164013935
code lgtm and @remibergsma ran the regression tests. If people complain we
have a a regression to decide on but it seems ok to me.
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163988697
@wilderrodrigues did run the add commands in an old setup, will run the
integration/regression suits and the cloudmonkey commands. code lgtm
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163930683
@agneya2001 please expand on *what* LGTY, the titel of the PR, the commit
message, your test results?
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163927873
@agneya2001 What made you LGTM this? the titel of the PR? The description
of the feature in the ticket? code review? testing?
---
If your project is set up
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1219
CLOUDSTACK-9139 make zwps default when defined on zone level
When a marvin definition contains a primary storage definition at zone
level it will default to zone scope. A test run is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-163903617
@priyankparihar please expand on testing that can prove prior and new
behaviour.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163883953
Guys, I think (and hate myself for bringing it up again despite my
intentions not to) you are giving an argument to merge MCT-shared#20 I use the
merge
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163579922
I reran the test and it failed again:
```
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163579051
Had a look at the code and trusting @remibergsma his test work: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163574449
I like angry fruit salads, how about a grey icon that colours all up on
hovering?
serious? ok, i'm fine with both.
---
If your project is set u
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163554166
@ustcweizhou, @wilderrodrigues is right to ask for a retest anyway, will do
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163542373
@harikrishna-patnala This is reverted because of the lack of test report,
not the logic of your code. If you feel it must go in anyway please rebase the
code
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163539316
Did the regression tests:
[1197.network.results.txt](https://github.com/apache/cloudstack/files/57825/1197.network.results.txt)
[1197.vpc.results.txt
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163537454
@wilderrodrigues it was merged before the freeze so I didn't revert it as
RM. But you are right about the not being tested.
---
If your project is set u
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1202
CLOUDSTACK-9120 READ.ME files describing the purpose of test directories
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-163283297
@wilderrodrigues can you have a look? you rmoved the code that is
reintroduced with this PR.
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-163212979
@nitin-maharana : Then you are saying it must be an exact match. Now a
compute offering that had (x,y) can be replaced with one that has (x,y,z) while
the VM
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1195#issuecomment-163140684
fine by me. I will get soem time to add a PR with read.me files per
directory indicating what type of test should go where.
LGTM pending the outcome
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-162869020
@kansal looks good, but for a change like this I would like a marvin test
to prove it and guarantee it's continued functioning/functionality Do you see
c
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46947731
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java ---
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46947711
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java ---
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1187#discussion_r46934510
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java
---
@@ -106,6 +104,8 @@ private void
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162624037
agree with @bhaisaab , @nlivens this will certainly decrease the failure
rate ;)
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162614546
Went through the code. Looks Good To Me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162498348
@nlivens there are several tests like this bugging us. Do you know an
alternative for this one?
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162497602
it is the NetUtilsTest.test31BitPrefix...() family of tests that are failing
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162484552
@sureshanaparti How do we force such a situation to occur?
It seems to me that should be guarded on input and alerted on on output
instead of silently
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162480371
Not sure if it is related but
```
Running com.cloud.utils.net.NetUtilsTest
2015-12-07 11:33:08,471 INFO [utils.net.NetUtils] (main:) Invalid
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46805977
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-162476357
regression tests executed:
[1044.network.results.txt](https://github.com/apache/cloudstack/files/53778/1044.network.results.txt)
[1044.vpc.results.txt
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162474888
LGTM
I will run a test build on this
also github reports conflicts on this branch, did you fork this of master?
and when? It may need a rebase to merge
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162472783
Thanks for picking this up, guys.
I still think there is calling code that should not be allowed to call
start twice. It should skip the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162464916
@terbolous your real question is: Can we get this in 4.6/4.7? right? I
sugest you start a discuss thread on dev@ if you feel it should.
---
If your project is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162464615
Guys, this got merged on only code review. No tests are described showing
the old and new behaviours. No unit tests are added. No regression tests are
added
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-162455918
Does what it says but probably more. Do we not mind any other version?
@priyankparihar can you show how ACS doesn't allow invalid migrations, &qu
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-162454833
The code looks good but I am wondering about the functionality. The prior
situation was that the new offering should have a subset of the old one. Now it
has
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162453199
Though I would like to see how this situation is reproduced, the code is
fine and sensible.
LGTM
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162345306
@rafaelweingartner you better read #1177, part of #1124 will no longer
merge cleanly because of the ovm3 changes.
---
If your project is set up for it, you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-162344831
@wenwenxiong can you add tests and or test data to this? any combination of
- unit tests
- marvin tests
- test procedure
thanks
---
If
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
--- Diff: ui/scripts/instanceWizard.js ---
@@ -731,25 +746,33 @@
//step 1 : select zone
$.extend
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-162342597
@kansal looking forward to your update. your intended change makes sense
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46775072
--- Diff: api/src/com/cloud/user/AccountService.java ---
@@ -136,4 +140,6 @@ void checkAccess(Account account, AccessType
accessType, boolean
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1162#issuecomment-162341391
lgtm
@remibergsma can you schedule a regression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162341273
@priyankparihar I do not know any vmware users
@bhaisaab Do you have any insight on this change? or do you know any
candidate reviewer for this?
---
If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162340165
lgtm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1060#issuecomment-162339782
@rafaelweingartner we still allow for 1.7 so no 1.8 only features for now
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162339708
#1177 obsoleted this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-162337898
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162337123
lgtm, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1168#issuecomment-162336441
code lgtm and since @ustcweizhou and @anshul1886 agree on how to solve this
and @remibergsma did the tests, i am merging this
---
If your project is set up
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1161#issuecomment-162336211
lgtm, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1154#issuecomment-162336048
code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-162335446
two lgtm, no response to the the answers on reviews so merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162334352
@wido any reason we shouldn't merge this in before 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162332724
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46773579
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331667
@snuf are you, as the author of the ovm3 hypervisor plugin, alright with
this?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331595
lgtm, but can you squash these commits to no longer include a revert,
@ustcweizhou ? thanks
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162324443
@remibergsma I think I am being captain obvious (as my new colleagues like
to call each other) but let's add them to the standard run.
---
If your proje
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46771839
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46769041
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46767881
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162243277
@anshul1886 I trust you are alright with this change in comment, are you?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162243159
Wilder can this one be on 4.6 please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761996
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761989
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761973
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761967
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761965
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -765,18 +773,23 @@ public boolean saveSSHKey(final Network network
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761941
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761920
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -509,10 +512,11 @@ public boolean applyIps(final Network network
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761845
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761835
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -445,13 +446,14 @@ public boolean applyIps(final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162237710
I like the scrum style title but just to be nitpicking: isn't this more of
a network engineer feature instead of a developer tool?
---
If your project i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162234338
Yes we do, it might not be the final solution as per the discussion above
but it is an improvement.
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1173#discussion_r46698656
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1173#discussion_r46687151
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161981047
Based on code review I can live with this, though I am not happy with
wiki-links in javadoc. wiki links may change independant of versions of the
code
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/809#issuecomment-161980229
@sanju1010 can you add a run output to the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1013#issuecomment-161948346
LGTM @jharshman can you make sure to add tests in follow-ups (both unit and
integration)?
---
If your project is set up for it, you can reply to this email
801 - 900 of 1880 matches
Mail list logo
