RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-19 Thread Gabor Apati-Nagy
it would be nice if we could sort by clicking a column header in a table...maybe some reasonable column header would be selected by default for each table) On Thursday, December 18, 2014, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: My point here is: unless the API supported sorting

RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Gabor Apati-Nagy
Hi, I think sorting would be good to have, but I would not change the display format because that would remove hierarchy (as a sorting criteria). Wouldn't it be good to sort just by path? (To me sorting looks like an improvement, changing the format is more like a change that may cause

RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Gabor Apati-Nagy
in current situation... On 18 December 2014 at 11:35, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: Hi, I think sorting would be good to have, but I would not change the display format because that would remove hierarchy (as a sorting criteria). Wouldn't it be good to sort just

RE: Development environment

2014-12-12 Thread Gabor Apati-Nagy
Hi Ramzi, Are you developing an UI plugin? That is a different case. For some references go to: https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial The good news is that (for UI development) you can avoid rebuilding/deploying with maven. So once your managent server is up

RE: Development environment

2014-12-12 Thread Gabor Apati-Nagy
No problem. I forgot to mention that there are compressed version for each file there, those are needed to be deleted first. rm -r *.gz Gabor -Original Message- From: Ramzi Youssefi [mailto:ryouss...@gmail.com] Sent: 12 December 2014 15:42 To: dev Subject: Re: Development environment

RE: Development environment

2014-12-12 Thread Gabor Apati-Nagy
Apati-Nagy gabor.apati-n...@citrix.com wrote: No problem. I forgot to mention that there are compressed version for each file there, those are needed to be deleted first. rm -r *.gz Gabor -Original Message- From: Ramzi Youssefi [mailto:ryouss...@gmail.com] Sent: 12 December 2014 15

Review Request 27863: CLOUDSTACK-7875: [UI] Wrong format check is being made on Create VPC box - DNS domain Information

2014-11-11 Thread Gabor Apati-Nagy
/scripts/network.js 501fb50c99c2e6c611d56f30325e6208cd06b4ac Diff: https://reviews.apache.org/r/27863/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 27727: CLOUDSTACK-3528: [UI]list calls are in the processing state forever with invalid name provided with Account name search filter

2014-11-07 Thread Gabor Apati-Nagy
/storage.js 90720ac991470c6b8efef2a24c53b9595b88de79 Diff: https://reviews.apache.org/r/27727/diff/ Testing --- Tested all the affected Advanced Search features. Thanks, Gabor Apati-Nagy

Review Request 27581: CLOUDSTACK-7838: UI - Update category names on Resources tab of a Zone

2014-11-04 Thread Gabor Apati-Nagy
/zoneChart.js ac3c0e475a5f2edf951adba20aeb06429107ed73 Diff: https://reviews.apache.org/r/27581/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 27583: CLOUDSTACK-7840: UI control tip for 'Add Primary Storage' - 'Provider' seems wrong

2014-11-04 Thread Gabor Apati-Nagy
--- Thanks, Gabor Apati-Nagy

Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP

2014-11-03 Thread Gabor Apati-Nagy
field) Diffs - ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c Diff: https://reviews.apache.org/r/27527/diff/ Testing --- Thanks, Gabor Apati-Nagy

RE: UI: where has Acquire new IP button disappeared?

2014-10-30 Thread Gabor Apati-Nagy
Could someone cherry-pick this to 4.4? That would fix CLOUDSTACK-7782. Cheers, Gabor -Original Message- From: Brian Federle Sent: 27 October 2014 17:58 To: Gabor Apati-Nagy; dev@cloudstack.apache.org Subject: RE: UI: where has Acquire new IP button disappeared? Gabor, yes

Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules

2014-10-29 Thread Gabor Apati-Nagy
--- On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27300

Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields

2014-10-29 Thread Gabor Apati-Nagy
ui/scripts/sharedFunctions.js e044d24fc8221aec23e9f140b6c391bf85c88f3a Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy

RE: Edit rights to Wiki

2014-10-28 Thread Gabor Apati-Nagy
Apati-Nagy gabor.apati-n...@citrix.com wrote: Hi, I'd like to update UI section of Browser-based Template / Volume uploadhttps://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237 on wiki [1]. Could someone please grant me the permissions needed? Thanks, Gabor [1] https

RE: Edit rights to Wiki

2014-10-28 Thread Gabor Apati-Nagy
Works fine. Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: 28 October 2014 11:13 To: dev Subject: Re: Edit rights to Wiki On Tue, Oct 28, 2014 at 12:11 PM, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: gabora :) was hidden but i found

Review Request 27296: CLOUDSTACK-7764: No IP Address Validations when Adding Networks

2014-10-28 Thread Gabor Apati-Nagy
- ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549 Diff: https://reviews.apache.org/r/27296/diff/ Testing --- Tested validation on these fields. Thanks, Gabor Apati-Nagy

Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules

2014-10-28 Thread Gabor Apati-Nagy
Thanks, Gabor Apati-Nagy

Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields

2014-10-28 Thread Gabor Apati-Nagy
8ec88b392eefd35c1d0b133097d17c82c3d65549 Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy

Review Request 27302: CLOUDSTACK-7808: Typo in Zone Creation Wizard

2014-10-28 Thread Gabor Apati-Nagy
Diff: https://reviews.apache.org/r/27302/diff/ Testing --- Thanks, Gabor Apati-Nagy

RE: UI: where has Acquire new IP button disappeared?

2014-10-27 Thread Gabor Apati-Nagy
Message - From: Gabor Apati-Nagy gabor.apati-n...@citrix.com To: dev@cloudstack.apache.org Sent: Friday, 24 October, 2014 14:26:40 Subject: RE: UI: where has Acquire new IP button disappeared? Hi Lucian, The View secondary IP button should be displayed next to the IP Address

Edit rights to Wiki

2014-10-27 Thread Gabor Apati-Nagy
Hi, I'd like to update UI section of Browser-based Template / Volume uploadhttps://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237 on wiki [1]. Could someone please grant me the permissions needed? Thanks, Gabor [1]

RE: UI: where has Acquire new IP button disappeared?

2014-10-27 Thread Gabor Apati-Nagy
: Monday, 27 October, 2014 10:24:14 Subject: Re: UI: where has Acquire new IP button disappeared? Please check similar bug fix https://issues.apache.org/jira/browse/CLOUDSTACK-6590 -Jayapal On 27-Oct-2014, at 3:40 PM, Gabor Apati-Nagy gabor.apati-n...@citrix.com wrote: I mean gridview

Re: Review Request 26053: UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.

2014-10-27 Thread Gabor Apati-Nagy
/ Testing --- Tested that the validation is still working as expected. Thanks, Gabor Apati-Nagy

RE: UI: where has Acquire new IP button disappeared?

2014-10-24 Thread Gabor Apati-Nagy
Hi Lucian, The View secondary IP button should be displayed next to the IP Address in the gridview. Clicking on that this page should display the Acquire new secondary IP button. I have tested this in master and we seem to have the same code in 4.4. Could you double check this? It could be

RE: i18n issues in (master) GUI

2014-10-15 Thread Gabor Apati-Nagy
Hi, I think there was work in that area, the dictionary file was split into to two, it seems like one of them has not been loaded on time or not loaded at all in some cases. Could someone file a bug mentioning some of the missing keys on the ticket? Cheers, Gabor -Original

Review Request 26693: CLOUDSTACK-7718: No Field Validations on Zone Form

2014-10-14 Thread Gabor Apati-Nagy
/scripts/zoneWizard.js 2c90f2b084e914debd128110fca09f26ffdfcbac Diff: https://reviews.apache.org/r/26693/diff/ Testing --- Tested fields with modified validation on them having applied commit[1] for CLOUDSTACK-7659 before [1] https://reviews.apache.org/r/26053/ Thanks, Gabor Apati-Nagy

Review Request 26703: CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP

2014-10-14 Thread Gabor Apati-Nagy
/ Testing --- Thanks, Gabor Apati-Nagy

Re: Review Request 26053: UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.

2014-10-08 Thread Gabor Apati-Nagy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26053/#review55783 --- On Sept. 30, 2014, 5:12 p.m., Gabor Apati-Nagy wrote

Review Request 26053: UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.

2014-09-30 Thread Gabor Apati-Nagy
72296a61f208298f2e54ac7b54b70557f41e0f84 Diff: https://reviews.apache.org/r/26053/diff/ Testing --- Tested that the validation is still working as expected. Thanks, Gabor Apati-Nagy

Review Request 25706: CLOUDSTACK-7561: UI: After creating a new account, the Add Account dialog remains open

2014-09-16 Thread Gabor Apati-Nagy
: https://reviews.apache.org/r/25706/diff/ Testing --- After adding an account using the UI there were no exceptions raised and the dialog closes properly. Thanks, Gabor Apati-Nagy

Review Request 25707: CLOUDSTACK-7562: Details page for disk offerings only show details for write performance

2014-09-16 Thread Gabor Apati-Nagy
Rate (IOPS) Disk Write Rate (IOPS) Thanks, Gabor Apati-Nagy

Review Request 25243: CLOUDSTACK-7463: UI: Domain Admin UI shows 'Add LDAP Users'

2014-09-02 Thread Gabor Apati-Nagy
/ Testing --- Thanks, Gabor Apati-Nagy

RE: jsonObj is not defined. UI development problem.

2014-09-01 Thread Gabor Apati-Nagy
Hi Ilia, I looked into this and although I did not try to make the changes myself, it turned out that the error you are getting is already there on the ACL rules tab. I raised a Jira ticket for investigation. It seems to me that your solution should work as is, once the issue with data:

Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4

2014-08-25 Thread Gabor Apati-Nagy
: cloudstack-git Description --- Replaced jquery.js file. Diffs - ui/lib/jquery.js 5d5a1d58ee5148d010b2029c419356440e679941 Diff: https://reviews.apache.org/r/25029/diff/ Testing --- I have done smoke test on the UI. Thanks, Gabor Apati-Nagy

Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues

2014-06-04 Thread Gabor Apati-Nagy
: +-return _l('label.gpu'); The problem above is the last two lines, it causes javascript syntax error, because also “-“ will be added to the js file. Thanks Gabor - Gabor Apati-Nagy On May 27, 2014, 11:58 a.m., Vetrivel Chinnasamy wrote

RE: UI Development

2014-06-03 Thread Gabor Apati-Nagy
Hi Matt, There are ui controls in /ui/scripts/ui/widgets that generate the actual controls/page based on JSON definitions at /ui/scripts. AFAIK there is no complete UI documentation, but you can take a look here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+widget+samples To add

Review Request 22143: CLOUDSTACK-6725: Fix: [OVS][UI] vm deployment wizard does not show all available zones in a region while deploying vm in a Regionlevel vpc

2014-06-02 Thread Gabor Apati-Nagy
/instanceWizard.js 9df6ecc Diff: https://reviews.apache.org/r/22143/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 22147: CLOUDSTACK-6722: Fix: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones Edit Comment Assign More Stop Progress Review Workflow E

2014-06-02 Thread Gabor Apati-Nagy
Export Diffs - ui/scripts/instanceWizard.js 9df6ecc Diff: https://reviews.apache.org/r/22147/diff/ Testing --- Thanks, Gabor Apati-Nagy

Re: Review Request 22147: CLOUDSTACK-6722: Fix: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones

2014-06-02 Thread Gabor Apati-Nagy
Description (updated) --- Fix for CLOUDSTACK-6722: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones Diffs - ui/scripts/instanceWizard.js 9df6ecc Diff: https://reviews.apache.org/r/22147/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 22019: CLOUDSTACK-6732: [OVS][UI] Network Service Providers page displays two ovs providers

2014-05-29 Thread Gabor Apati-Nagy
/diff/ Testing --- Thanks, Gabor Apati-Nagy

Cherry pick

2014-05-27 Thread Gabor Apati-Nagy
Hi Daan, Can you please cherry-pick the following to 4.4 from 4.4-forward? 3f1dc2534fc57376c596e616ca3e8e76754b209d Thu, 22 May 2014 17:44:45 +0100 CLOUDSTACK-6565: [UI] New Zones tab for Templates and ISOs Thanks, Gabor

Review Request 21817: [UI] New Zones tab for Templates and ISOs

2014-05-22 Thread Gabor Apati-Nagy
/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 21221: CLOUDSTACK-6606: Fix: create network offering dailog box has greyed out (not selectable) providers for the connectivity service.

2014-05-11 Thread Gabor Apati-Nagy
. This patch fixes this. Diffs - ui/scripts/configuration.js 1b82188 Diff: https://reviews.apache.org/r/21221/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 21109: [UI] New Zones tab for Templates and ISOs

2014-05-06 Thread Gabor Apati-Nagy
ui/scripts/templates.js 67cc2fb Diff: https://reviews.apache.org/r/21109/diff/ Testing --- Thanks, Gabor Apati-Nagy

[ACS44] cherry pick CLOUDSTACK-6255

2014-04-28 Thread Gabor Apati-Nagy
Hi Daan/Hugo, Could you please cherry-pick the following commit? commit 83e5ea9812cb57eb214ec9548671b0404914ae9b CLOUDSTACK-6255 UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks Thanks, Gabor

RE: Regarding create vpc offering wizard

2014-04-25 Thread Gabor Apati-Nagy
Hi Rajesh, There is a possibility to add new VPC offerings using the new Service OfferingsVPC Offerings screen - I added this to the UI recently. Once a new VPC Offering has been added, there would be more than two options in the dropdown you mentioned. Currently there is no filtering on it

RE: Regarding create vpc offering wizard

2014-04-25 Thread Gabor Apati-Nagy
then offering with netscaler combination will be wrong. Even if user/admin wants to create an offering the only possible offerings are already created and available to the user/admin. Thanks Rajesh Battala -Original Message- From: Gabor Apati-Nagy [mailto:gabor.apati-n...@citrix.com] Sent

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Gabor Apati-Nagy
On April 22, 2014, 6:55 p.m., Brian Federle wrote: Gabor, for the most part the UI is good. However, I did notice the 'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? Gabor Apati-Nagy wrote: Thanks for reviewing

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Gabor Apati-Nagy
/scripts/network.js 0276684 ui/scripts/regions.js 66dae8c ui/scripts/ui/dialog.js 82e7fd4 ui/scripts/vpc.js 73d34df Diff: https://reviews.apache.org/r/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-22 Thread Gabor Apati-Nagy
--- On April 15, 2014, 11:41 p.m., Gabor Apati-Nagy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391

Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-15 Thread Gabor Apati-Nagy
/20391/diff/ Testing --- Thanks, Gabor Apati-Nagy

RE: Coding Standards Questions

2014-04-14 Thread Gabor Apati-Nagy
To my mind having multiple return statements might be unclear sometimes, but personally I do prefer this option. In this case we can easily make sure that the return value is not going to be changed. If we know the result, let's return it asap. If we reach a return statement anywhere, we can be

RE: can't get the simulator running on 4.4

2014-04-11 Thread Gabor Apati-Nagy
Hi Tina, I have tried to get the Simulator working on branch 4.4 and I can confirm it works fine on Ubuntu. Now, the following entries are in my version table: 4.0.0 4.1.0 4.2.0 4.2.1 4.3.0 4.4.0 Maybe you could try cloning 4.4 to a different directory, drop DB and see if that helps.

Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)

2014-03-28 Thread Gabor Apati-Nagy
/accounts.js aff780e ui/scripts/ui/widgets/detailView.js 4c5aeea Diff: https://reviews.apache.org/r/19695/diff/ Testing --- Thanks, Gabor Apati-Nagy

Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter custom.diskoffering.size.min is not reflected in UI during new instance creation

2014-03-28 Thread Gabor Apati-Nagy
/instanceWizard.js 03ee344 ui/scripts/ui-custom/instanceWizard.js c5e0ddb Diff: https://reviews.apache.org/r/19751/diff/ Testing --- Thanks, Gabor Apati-Nagy

Review Request 19751: Fixed for [CLOUDSTACK-5962]: Value of Global parameter custom.diskoffering.size.min is not reflected in UI during new instance creation

2014-03-27 Thread Gabor Apati-Nagy
Diff: https://reviews.apache.org/r/19751/diff/ Testing --- Thanks, Gabor Apati-Nagy

Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter custom.diskoffering.size.min is not reflected in UI during new instance creation

2014-03-27 Thread Gabor Apati-Nagy
Apati-Nagy

Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)

2014-03-26 Thread Gabor Apati-Nagy
, Gabor Apati-Nagy

Review Request 18695: Fix for CLOUDSTACK-4563: Initial zone wizard UI label issue

2014-03-03 Thread Gabor Apati-Nagy
13630c1 Diff: https://reviews.apache.org/r/18695/diff/ Testing --- Thanks, Gabor Apati-Nagy