Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Hugo Trippaers
July 11, 2014, 10:10 p.m.) Review request for cloudstack and Hugo Trippaers. Bugs: CLOUDSTACK-6823 https://issues.apache.org/jira/browse/CLOUDSTACK-6823 Repository: cloudstack-git Description --- First code drop for Brocade Network plugin to orchestrate Brocade VDX

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Hugo Trippaers
Did you check with the rat plugin if the license is accepted like this? I think the license is only properly detected with it is located in a comment like in the spring xml files. - Hugo Trippaers On July 11, 2014, 11:44 p.m., Ritu Sabharwal wrote

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Hugo Trippaers
not impact anybody that is not using Nuage. - Hugo Trippaers On July 15, 2014, 11:38 a.m., Suresh Ramamurthy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23282

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-15 Thread Hugo Trippaers
On July 15, 2014, 3:01 p.m., Hugo Trippaers wrote: Suresh, While testing the new plugin i noticed that i get a popup telling me Provider NuageVsp should be enabled in at least one physical network of the zone specified even though i have not configured anything. I was just

Re: Coverity Scan Report: July 11 2014

2014-07-14 Thread Hugo Trippaers
Or fixed. Feel free to help fellow committers learn by fixing bugs and showing why a certain way of doing things could cause problems later on. Cheers, Hugo On 14 jul. 2014, at 07:16, Abhinandan Prateek abhinandan.prat...@citrix.com wrote: +1 Any commit that is not findbug compliant should

Re: Tomcat version issue while building cloudstack on RHEL7 RPMS

2014-07-14 Thread Hugo Trippaers
Hey Rayees, We should make a second set of scripts for the new redhat and cents releases. It’s not only tomcat that has changes, for example we also need systemd scripts for cloudstack. I’ve been working on it, but it’s not finished. Cheers. Hugo On 13 jul. 2014, at 19:19, Rayees

VPC Virtual Router and Redundancy

2014-07-14 Thread Hugo Trippaers
Hey All, As discussed in thread http://markmail.org/message/56xrscvnmdweoxf5 some of us are working on making the VPC virtual router redundant. As part of this effort we are doing just a little bit more to get this properly done. Based on the feedback we at Schuberg Philis are getting from our

License headers in cloud-core

2014-07-14 Thread Hugo Trippaers
Heya, Just a headsup, but i pushed a rather big looking change into core. It doesn’t actually make any changes, except for formatting on the license headers. We used to have some standards on the formatting of the license headers, but they were not really looked after (unless rat complains of

Re: Bug introduced by part of commit a600d8408ea86782318139c17cf346c8497943d0

2014-07-10 Thread Hugo Trippaers
Doesn’t seem related to that particular commit, the function invalidateRunSession appears to be dead code. I’ll do some digging. Cheers, Hugo On 10 jul. 2014, at 10:40, Funs Kessen fkes...@schubergphilis.com wrote: Hi Devs, I recently noticed on master that after starting, stopping and

Re: Bug introduced by part of commit a600d8408ea86782318139c17cf346c8497943d0

2014-07-10 Thread Hugo Trippaers
Fixed already, good job Santosh Cheers, Hugo On 10 jul. 2014, at 10:58, Hugo Trippaers trip...@gmail.com wrote: Doesn’t seem related to that particular commit, the function invalidateRunSession appears to be dead code. I’ll do some digging. Cheers, Hugo On 10 jul. 2014, at 10

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-09 Thread Hugo Trippaers
On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: Thanks for make this a separate review, much easier to read. The licenses are not added to all files and in some files they appear not to be complete. A good trick to solve this is to include the license-maven-plugin in the build

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-09 Thread Hugo Trippaers
On July 8, 2014, 10:07 a.m., Hugo Trippaers wrote: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java, line 196 https://reviews.apache.org/r/23282/diff/1/?file=624333#file624333line196 I'm not really agreeing with this method of loading

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Hugo Trippaers
Please remove commented code. plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java https://reviews.apache.org/r/23314/#comment83258 This TODO is fixed right? - Hugo Trippaers On July 7, 2014, 7:08 p.m., Ritu Sabharwal wrote

Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin

2014-07-08 Thread Hugo Trippaers
branch. - Hugo Trippaers On July 7, 2014, 6 p.m., Suresh Ramamurthy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23282

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-08 Thread Hugo Trippaers
Rajani, That is why we renamed nonoss to noredist. It has to do with the policy of the Apache Software Foundation regarding compatible licenses [1]. The problem in this case is subtle, but there is a difference. The main point in the discussion is so-called system dependencies. We know we need

Re: [HELP] How to build CS to enable VMware support in CloudStack..

2014-07-08 Thread Hugo Trippaers
Ritu. If you wan to build only the vmware dependencies , just enable the profile vmware So the command should be: mvm -P vmware,systemvm install. That would build only the vmware dependencies. Make sure the dependencies are in the deps folder and added to the local maven repository. The

Re: [HELP] How to build CS to enable VMware support in CloudStack..

2014-07-08 Thread Hugo Trippaers
On 8 jul. 2014, at 22:35, Amogh Vasekar amogh.vase...@citrix.com wrote: Hi, Unfortunately, you need to download and install the manageontop jar too You can enable every noredist plugin by itself, the noredist flag is just a handy shortcut to enable all of them for developers. Thanks,

Re: Ubuntu noredist

2014-07-07 Thread Hugo Trippaers
Hey Wido, This is particular ticket is about the mysql Ha module. It is part of the noredist build as we have a build time dependency on the mysql connector. The module also needs to be installed in a specific location in order to be loaded by the tomcat system class loader instead of the web

Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity

2014-07-04 Thread Hugo Trippaers
in the if. - Hugo Trippaers On July 4, 2014, 9:07 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23226/ --- (Updated

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-04 Thread Hugo Trippaers
On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote: Hey, There are a number of issues with this patch, i've made the commments on the lines directly. Also where is the real functionality? The code in this patch seems to only be the hook into the existing cloudstack code

Re: [VOTE] Apache Cloudstack 4.4.0

2014-07-03 Thread Hugo Trippaers
Hey Mike, That is technically not the way this vote works. Release votes a a “Lazy Majority” vote. This means that the vote requires at least 3 binding +1 votes and more +1 votes than -1 votes. For the exact working see paragraphs 3.4.4 and 3.2.2 of the Apache CloudStack bylaws. Cheers,

Release 4.5 / 4.6

2014-07-03 Thread Hugo Trippaers
Hey all, Just checking the schedule. Sticking to the fourth month release cycle means that the feature freeze for 4.5 is coming up really fast. The feature freeze for 4.4 was March 19 That makes the feature freeze date for 4.5 July 19 And the feature freeze for 4.6 November 19 Do we have any

Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity

2014-07-03 Thread Hugo Trippaers
On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote: engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java, line 310 https://reviews.apache.org/r/23226/diff/1/?file=622487#file622487line310 Shouldn't this be inside the try-with-resources bit of the try keyword? Santhosh Edukulla

Re: Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

2014-07-03 Thread Hugo Trippaers
dependency is not available on the regular maven systems? plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java https://reviews.apache.org/r/23257/#comment82957 Possible to fix this TODO before submitting? - Hugo Trippaers On July 3, 2014, 8

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-03 Thread Hugo Trippaers
On 3 jul. 2014, at 14:29, Koushik Das koushik@citrix.com wrote: On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote: I'm not sure we can actually have a dependency on the mysql connector like this because of it's GPL license. I'll check this and get back on this before we can accept

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-03 Thread Hugo Trippaers
on mysql and the mysql connection in our wix script. Cheers, Hugo On 3 jul. 2014, at 14:33, Hugo Trippaers h...@apache.org wrote: Hey Koushik, No problem, will do if required. The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks

Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity

2014-07-02 Thread Hugo Trippaers
it more clear for the readers of the code why not write 'if (params == null) { throw blabla }' - Hugo Trippaers On July 2, 2014, 8:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-24 Thread Hugo Trippaers
https://reviews.apache.org/r/22863/#comment81898 Please don't commit any changes to this file. - Hugo Trippaers On June 23, 2014, 5:49 p.m., Ritu Sabharwal wrote: --- This is an automatically generated e-mail. To reply, visit

create_schema.sql

2014-06-24 Thread Hugo Trippaers
Dear committers, When either committing or reviewing, please pay attention to the fact the create_schema.sql should NOT be modified under any circumstances. Since release 4.1 this file is considered frozen and updates to the schema will be in the upgrade scripts for the versions. At the

Re: [DISCUSS] Introducing Gerrit for quality? was: [PROPOSAL] Using continuous integration to maintain our code quality...

2014-06-11 Thread Hugo Trippaers
) for every commits, and I think the correct tool is important in this case. --Sheng On Mon, Jun 9, 2014 at 11:22 PM, Hugo Trippaers h...@trippaers.nl wrote: Hey, I’m all for automated solutions. I’m a happy gerrit user on some other projects and quite fond of working with Github

[DISCUSS] Release 4.4

2014-06-11 Thread Hugo Trippaers
Hey all, I’m getting somewhat concerned about the 4.4 release. We don’t seems to be able to get the 4.4 branch in shape for a release candidate and meanwhile master is diverging further and further. We also know that once we hit the RC phase we will probably need a sizable number of iterations

Re: [DISCUSS] Introducing Gerrit for quality? was: [PROPOSAL] Using continuous integration to maintain our code quality...

2014-06-10 Thread Hugo Trippaers
Hey, I’m all for automated solutions. I’m a happy gerrit user on some other projects and quite fond of working with Github pull requests as well. However there is one important point that makes working with those tools work and that is a willingness by the committers to review requests. Both

Re: redundant virtual routers for VPCs

2014-06-10 Thread Hugo Trippaers
Prokharchyk; kis...@cloud.com; Christopher Litsinger; Hugo Trippaers; int-toolkit Subject: Re: redundant virtual routers for VPCs BTW, do we have an agenda or some topics we want to discuss for the meeting? I just want to make sure it's efficient. --Sheng On Mon, Jun 9, 2014 at 1:14 PM, Sander

Re: [ANNOUNCE] Pierre-Luc Dion as a committer

2014-06-10 Thread Hugo Trippaers
Congrats Pierre-Luc! Cheers, Hugo On 10 jun. 2014, at 16:40, Chip Childers chipchild...@apache.org wrote: On Tue, Jun 10, 2014 at 01:45:36PM +0200, sebgoa wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Pierre-Luc Dion to become a committer and we are pleased

Fwd: New Defects reported by Coverity Scan for cloudstack

2014-06-06 Thread Hugo Trippaers
FYI Begin forwarded message: From: scan-ad...@coverity.com Subject: New Defects reported by Coverity Scan for cloudstack Date: 6 juni 2014 13:40:40 CEST Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. Defect(s) Reported-by:

Re: New Defects reported by Coverity Scan for cloudstack

2014-06-05 Thread Hugo Trippaers
. ~Rajani On 29-Nov-2013, at 9:28 pm, Hugo Trippaers trip...@gmail.com wrote: FYI Sent from my iPhone Begin forwarded message: From: scan-ad...@coverity.com Date: 29 november 2013 14:39:56 CET Subject: New Defects reported by Coverity Scan for cloudstack Hi, Please find

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

2014-06-03 Thread Hugo Trippaers
Author: Rajani Karuturi rajanikarut...@gmail.com Date: Tue Jun 3 12:31:20 2014 +0530 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com 4.4-forward: commit

Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

2014-06-03 Thread Hugo Trippaers
On June 3, 2014, 7:20 a.m., Hugo Trippaers wrote: master: commit 2424d9a9e0f1189044303a98c40e60033808f0b2 Author: Rajani Karuturi rajanikarut...@gmail.com Date: Tue Jun 3 12:31:20 2014 +0530 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440

RE: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity

2014-06-03 Thread Hugo Trippaers
Good find Santhosh. I missed the outer loop while doing the review. Cheers, Hugo -Original Message- From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] Sent: Tuesday, June 03, 2014 9:35 AM To: dev@cloudstack.apache.org; Hugo Trippaers; daan Hoogland; Abhinandan Prateek

quarterly board report, initial draft

2014-05-30 Thread Hugo Trippaers
Hey all, We are due for our quarterly board reports. I’ve drafted an initial version. Please review and post any feedback and/or questions. DESCRIPTION Apache CloudStack is open source software designed to deploy and manage large networks of virtual machines, as a highly available, highly

Re: 2014-5-26 Japanese CloudStack Community Weekly Update

2014-05-26 Thread Hugo Trippaers
Hey Mayumi, Thanks for sharing this with all of us. We appreciate the effort. Cheers, Hugo On 26 mei 2014, at 16:40, Mayumi K samem...@gmail.com wrote: Hi everyone I apologize for my delay in updating Activities of Japanese CloudStack Community. # # # ## Develop OSS Cloud

Re: [PROPOSAL] Using continuous integration to maintain our code quality...

2014-05-15 Thread Hugo Trippaers
Hey Alex, Nice job on getting this all done and working on some guidelines to improve quality of the overal guidelines. We discussed a lot of these things at the last CCC and i’m happy to see them here. I do have some feedback on the policy though. Specifically with the line stating “No

Re: test

2014-05-15 Thread Hugo Trippaers
and did it succeed? On 8 mei 2014, at 21:08, Nux! n...@li.nux.ro wrote: test -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

[ANNOUNCE] New PMC Menber: Go Chiba

2014-04-22 Thread Hugo Trippaers
The Project Management Committee (PMC) for Apache CloudStack has asked Go Chiba to join the PMC and we are pleased to announce that he has accepted. Join me in congratulating Go! -The CloudStack PMC

Re: Build failed in Jenkins: build-master #609

2014-04-10 Thread Hugo Trippaers
Hey guys, There is/was a problem the radios jar file. Rados version 0.1.4 is the culprit. The issue has now been resolved, but it was fixed by apparently replacing the jar file in the upstream maven repo. This is pretty unfortunate for us as a release version of a maven artifact is permanently

Re: InsufficientServerCapacityException

2014-04-06 Thread Hugo Trippaers
Hey Chris, It's pretty much a catch all exception, shouldn't be though. Feel free to submit patches with improvements ;-) Cheers, Hugo Sent from my iPhone On 6 apr. 2014, at 09:44, chris snow chsnow...@gmail.com wrote: I receive a lot of these errors while I'm learning cloudstack

Re: [PROPOSAL][Merge] Windowsfication of management server

2014-03-28 Thread Hugo Trippaers
Hey, 4.4 is in feature freeze, so no new features will be added. I think its fair to debate if this is a feature in that sense. It seems like minor changes and the addition of a few scripts, making it a simple change in my view. It would be great to be able to announce this, but for it to be

Re: [4.4] mysql-ha POM error

2014-03-28 Thread Hugo Trippaers
Fixed. Cheers, Hugo On 28 mrt. 2014, at 05:48, Damoder Reddy damoder.re...@citrix.com wrote: Paul, We have seen this issue while doing maven build on Red Hat Linux 6.2 and Fedora .. this was due to the wrong relative path in plugins/database/mysql-ha/pom.xml as mentioned by you.

Re: [Jenkins] centos slaves offline

2014-03-26 Thread Hugo Trippaers
I'll have a look. Thanks for the heads-up. Hugo Sent from my iPhone On 26 mrt. 2014, at 07:35, Paul Angus paul.an...@shapeblue.com wrote: Hi, I’ve noticed this morning that a large number of jobs in the 4.4 branch and some in the Master branch haven’t run for a week. There seems to

Re: [Jenkins] centos slaves offline

2014-03-26 Thread Hugo Trippaers
Hey Paul, It’s all fixed now. Cheers, Hugo On 26 mrt. 2014, at 07:35, Paul Angus paul.an...@shapeblue.com wrote: Hi, I’ve noticed this morning that a large number of jobs in the 4.4 branch and some in the Master branch haven’t run for a week. There seems to be a queue built up

[JENKINS] Updates

2014-03-26 Thread Hugo Trippaers
Hey, While working on the problem Paul reported i also performed all pending Linux updates and i upgrade Jenkins to version 1.556. ~190 packages updated Cheers, Hugo

Re: [ANNOUNCE] Apache CloudStack 4.3.0 Released

2014-03-26 Thread Hugo Trippaers
To get the semantics right, all our sources and packages are OSS, we are an Apache project and all our software is available with the Apache License V2. The only reason we are not releasing packages with the “noredist” flag is not because they are not open source (because they are open source!

Re: [JENKINS] Updates

2014-03-26 Thread Hugo Trippaers
, Hugo Trippaers h...@trippaers.nl wrote: Hey, While working on the problem Paul reported i also performed all pending Linux updates and i upgrade Jenkins to version 1.556. ~190 packages updated Cheers, Hugo -- Daan

Re: CloudStack New Spring Logic

2014-03-25 Thread Hugo Trippaers
Hey Soheil, The files look good to me at first glance. Are you sure the property files are in the final jar? Just asking because you use the resource directory and our default is resources. Cheers, Hugo On 24 mrt. 2014, at 20:46, Soheil Eizadi seiz...@infoblox.com wrote: I am refactoring

Re: 4.4 Feature Freeze

2014-03-20 Thread Hugo Trippaers
, Nux! n...@li.nux.ro wrote: On 11.03.2014 15:28, Hugo Trippaers wrote: Hey guys, I didn't go and tally all the +1s and -1s for the shift of the feature freeze, but with so many reactions i feel sticking to the schedule is the only way to go. We should only change dates

Feature Freeze 4.4

2014-03-20 Thread Hugo Trippaers
/* Sorry guys, just noticed that this email got stuck in my out folder and was never actually sent. Resending as the dates are still relevant. */ Hey all, As previously announced the tree leading up to the 4.4 release is now considered in feature freeze. To reflect this i’ve created a

Re: Java Coding Convention Errors

2014-03-18 Thread Hugo Trippaers
Soheil, How are these classes serialized? There are different ways to solve this like annotations with the serialized name or a gson policy. Cheers, Hugo Sent from my iPhone On 18 mrt. 2014, at 03:33, Soheil Eizadi seiz...@infoblox.com wrote: Looks like in the new trunk we have turned on

Re: Java Coding Convention Errors

2014-03-18 Thread Hugo Trippaers
From: Hugo Trippaers [trip...@gmail.com] Sent: Monday, March 17, 2014 11:30 PM To: dev@cloudstack.apache.org Subject: Re: Java Coding Convention Errors Soheil, How are these classes serialized? There are different ways to solve this like annotations with the serialized name or a gson

Re: Git Push Summary

2014-03-14 Thread Hugo Trippaers
Hey Muralli, The branch is already cut and the jenkins builds are setup. So i’m not going to recreate the 4.4 branch from master as all the version number are already updated. Which merge request are you merging in? If you can squash it it will be easy to pull into master and 4.4. Cheers,

Re: Git Push Summary : 4.4 feature branch

2014-03-14 Thread Hugo Trippaers
I announced the time when i would cut the branch in advance, so it shouldn’t be a surprise. But like i replied to Muralli, if you have a pending merge request on the ML i see no problem with merging it in in the next few hours because of the trouble with master. Just make sure it hits both

Re: [ACS4.4] RE: Git Push Summary : 4.4 feature branch

2014-03-14 Thread Hugo Trippaers
The branch is already cut and master has already been switched to 4.5.0. I’ve announced that the switch would be at 14:00 CET, you can’t expect me to get up in the middle of the night to cut a release branch. Cheers, Hugo On 14 mrt. 2014, at 16:09, Sudha Ponnaganti

Re: [ACS4.4] RE: Git Push Summary : 4.4 feature branch

2014-03-14 Thread Hugo Trippaers
Get your merge request in today because I'll be cutting the branch on Friday. At the time that most of us in the west read that email, get your merge request in today did not apply because it was technically already too late per your time spec. On Fri, Mar 14, 2014 at 9:12 AM, Hugo Trippaers h

Re: database version changed to 4.5 on master and it breaks the build

2014-03-14 Thread Hugo Trippaers
You shouldn't have to. I've got an automated test run that does the same and that succeeded before I committed the db change. I do a clean before jetty:run but that shouldn't matter. Hugo Sent from my iPhone On 14 mrt. 2014, at 18:25, Alena Prokharchyk alena.prokharc...@citrix.com wrote:

Re: [PROPOSAL] Bridge functionality

2014-03-13 Thread Hugo Trippaers
On 3/11/14, 7:12 AM, Hugo Trippaers h...@trippaers.nl wrote: Hey all, I¹ve been working on adding Bridge support to CloudStack. The use case is that with the introduction of SDN there is a need for us to link logical networks to physical hosts or physical networks. A typical use case

Re: [VOTE] Apache CloudStack 4.3.0 (seventh round)

2014-03-12 Thread Hugo Trippaers
3603 0540 | M: +447711418784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: 11 March 2014 19:31 To: dev@cloudstack.apache.org Cc: Hugo Trippaers; Hugo Trippaers (htrippa...@schubergphilis.com); Paul

Re: [VOTE] Apache CloudStack 4.3.0 (seventh round)

2014-03-12 Thread Hugo Trippaers
Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: 11 March 2014 19:31 To: dev@cloudstack.apache.org Cc: Hugo Trippaers; Hugo Trippaers (htrippa...@schubergphilis.com); Paul Angus Subject: RE: [VOTE] Apache CloudStack 4.3.0 (seventh round) -Original

Differences between 4.3 and 4.3-forward

2014-03-12 Thread Hugo Trippaers
Hey, There is a sizable number of differences between the two branch. Maybe it’s time to ditch 4.3-forward and recreate it based on current 4.3? Cheers, Hugo Hugos-MacBook-Pro:cloudstack hugo (4.3-forward)$ git diff --stat 4.3-forward 4.3

[PROPOSAL] Bridge functionality

2014-03-11 Thread Hugo Trippaers
Hey all, I’ve been working on adding Bridge support to CloudStack. The use case is that with the introduction of SDN there is a need for us to link logical networks to physical hosts or physical networks. A typical use case would be to connect legacy infrastructure to cloud infrastructure, or

Re: 4.4 Feature Freeze

2014-03-11 Thread Hugo Trippaers
Hey guys, I didn’t go and tally all the +1s and -1s for the shift of the feature freeze, but with so many reactions i feel sticking to the schedule is the only way to go. We should only change dates if there is a consensus and there clearly is none at the moment. Let’s take this discussion to

Re: [Merge] Virtual Router Service Failure Alerting

2014-03-11 Thread Hugo Trippaers
Harikrishna, Did you run the findbugs target on your changes? If not could you do that please, if there are any bugs marked a high importance it would cause build failures after we merge it. Cheers, Hugo On 11 mrt. 2014, at 16:17, Harikrishna Patnala harikrishna.patn...@citrix.com wrote:

Re: [MERGE] region level VPC

2014-03-11 Thread Hugo Trippaers
Murali, Did you use findbugs to scan for additional findings on your branch? If not could you do this, so there will be no build failures after we merge this branch? Cheers, Hugo On 11 mrt. 2014, at 15:59, Murali Reddy murali.re...@citrix.com wrote: I would like to merger region level VPC

FindBugs

2014-03-11 Thread Hugo Trippaers
Hey, Just a reminder, findbugs is now checking the code periodically via Jenkins. See http://jenkins.buildacloud.org/job/build-master-slowbuild/ If this job fails it means a checking caused additional warning above the 250+ high findings we already have. Over the last few weeks the total

Re: [Merge] CloudStack IAM branch to master

2014-03-11 Thread Hugo Trippaers
On 11 mrt. 2014, at 19:52, Min Chen min.c...@citrix.com wrote: Also, have already run FingBugs on our branch and addressed all new findings introduced by our branch. Awesome! :-) Thanks. -min On 3/10/14 7:33 PM, Min Chen min.c...@citrix.com wrote: No new jar dependencies. -min

Re: jenkins job for the developer build

2014-03-06 Thread Hugo Trippaers
The Jenkins builds do mvn -Pawsapi,systemvm clean install. I'm not using the developer profile there thats just for Marvin and Apidocs. Those are built separately. You can have a fully functional cloud dev environment without the developer profile. Cheers, Hugo Sent from my iPhone On 6

Re: 4.4 Feature Freeze

2014-02-28 Thread Hugo Trippaers
i’m all for being flexible, but i find a lot of the arguments used here debatable.“It causes developers to rush their development to meet the deadline." This will happen anyway, every time we’ve extended the deadline we got new features coming in at the last minute. Actually i’m under the

Re: developers and mysql

2014-02-27 Thread Hugo Trippaers
Ok, I’ll fix it in the poms then. Cheers, Hugo On 27 feb. 2014, at 09:02, Alex Huang alex.hu...@citrix.com wrote: -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Wednesday, February 26, 2014 11:36 PM To: dev@cloudstack.apache.org

Re: developers and mysql

2014-02-27 Thread Hugo Trippaers
we would use code to limit it. Thanks. --Alex -Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, February 25, 2014 2:02 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org Subject: Re: developers and mysql We are already pretty much

Re: developers and mysql

2014-02-27 Thread Hugo Trippaers
Done commit a0f932437c9ac9a0a82cc9b45b1aa6f17e8a478a Author: Hugo Trippaers htrippa...@schubergphilis.com Date: Thu Feb 27 09:48:55 2014 +0100 Move mysql ha strategy to a plugin. Activate this plugin using the mysqlha profile or the noredist flag On 27 feb. 2014, at 09:25, Hugo

Re: vhd-util on 64 bit system

2014-02-27 Thread Hugo Trippaers
See here for info on the convert “feature” http://blogs.citrix.com/2012/10/04/convert-a-raw-image-to-xenserver-vhd/ On 27 feb. 2014, at 15:08, Nux! n...@li.nux.ro wrote: On 27.02.2014 13:54, Daan Hoogland wrote: I loaded the 32 bit libs and checked with ldd. All right so far. It doesn't

Re: Yet another mail on code quality

2014-02-26 Thread Hugo Trippaers
the community if you can advise on how to setup the find bug tool. Is there a wiki on how to use find bug ? I know some tools that you can install on eclipse, but not sure about intellij etc. -abhi On 24/02/14 9:44 pm, Hugo Trippaers h...@trippaers.nlmailto:h...@trippaers.nl wrote: Guys

Re: 4.4 Feature Freeze

2014-02-26 Thread Hugo Trippaers
- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, February 25, 2014 8:50 AM To: dev@cloudstack.apache.org Subject: Re: 4.4 Feature Freeze Hey, If we stick to our 4 month release schedule the feature freeze is four months after the feature freeze of 4.3

Re: Looking for test folks on the community!

2014-02-26 Thread Hugo Trippaers
Certainly :-) On 27 feb. 2014, at 07:00, Raja Pullela raja.pull...@citrix.com wrote: Hi, Can you please respond if you are actively involved or looking get involved in testing 4.4 Release? Thanks, Raja

Re: developers and mysql

2014-02-26 Thread Hugo Trippaers
code just limits the possibilities. We can for example document this as a way to do it in on the wiki for example but I just don't see why we would use code to limit it. Thanks. --Alex -Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, February

Re: developers and mysql

2014-02-25 Thread Hugo Trippaers
that. --Alex -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, February 25, 2014 3:34 AM To: dev@cloudstack.apache.org Subject: Re: developers and mysql Heya, Just pushed a change that will make the database work again

Re: developers and mysql

2014-02-25 Thread Hugo Trippaers
that depending on jdbc only. It should not depend on mysql. We need to fix that. --Alex -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, February 25, 2014 3:34 AM To: dev@cloudstack.apache.org Subject: Re: developers and mysql Heya

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

2014-02-25 Thread Hugo Trippaers
functionality in XenServer. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17844: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1.

2014-02-25 Thread Hugo Trippaers
Tripathi sanjay.tripa...@citrix.com Date: Wed Jan 22 16:25:30 2014 +0530 CLOUDSTACK-6058: XenServer 6.2sp1 xenapi customization as per CloudStack resource code. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 19, 2014, 7:33 p.m., Sanjay Tripathi

Re: developers and mysql

2014-02-25 Thread Hugo Trippaers
dependency groupIdmysql/groupId artifactIdmysql-connector-java/artifactId scopeprovided/scope /dependency /dependencies /profile Thanks, ~Rajani On 24-Feb-2014, at 11:41 pm, Hugo Trippaers trip...@gmail.commailto:trip...@gmail.com wrote: Indeed

Who committed this?

2014-02-25 Thread Hugo Trippaers
commit 14689d781005006d95d5f67573331fd64e4c57a6 Author: Niels de Vos nde...@redhat.com Date: Sun Feb 23 14:32:24 2014 +0100 Gluster should store volumes in qcow2 format commit c02197ae86ba90ee4553fa437a1200e64915649f Author: Niels de Vos nde...@redhat.com Date: Sat Nov 23 14:30:40 2013

Anti-patterns

2014-02-25 Thread Hugo Trippaers
Anti-pattern: An anti-pattern (or antipattern) is a common response to a recurring problem that is usually ineffective and risks being highly counterproductive. The term, coined in 1995 by Andrew Koenig, was inspired by a book, Design Patterns, in which the authors highlighted a number of

Re: Review Request 18165: FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable in 1 class; adding 5 tests to cover the changes in the equals() methods.

2014-02-25 Thread Hugo Trippaers
: wrodrigues wrodrig...@schubergphilis.com Date: Sat Feb 15 13:23:35 2014 +0100 FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable in 1 class; adding 5 tests to cover the changes in the equals() methods. Signed-off-by: Hugo Trippaers htrippa

Re: 4.4 Feature Freeze

2014-02-25 Thread Hugo Trippaers
Hey, If we stick to our 4 month release schedule the feature freeze is four months after the feature freeze of 4.3. The feature freeze of 4.3 was 8 Nov 2013. So the proposed release schedule for 4.4 would look like this (dates slightly modified to take efficiency and RM’s personal life into

[JENKINS] Upgraded Jenkins to 1.551

2014-02-24 Thread Hugo Trippaers
This release fixes several critical security vulnerabilities. Cheers, Hugo

[PROPOSAL] Change systemvm template URL in master to s3 bucket

2014-02-24 Thread Hugo Trippaers
Hey all, I’ve finally fixed the configuration to automagically upload the systemvm templates to an s3 bucket. The jobs build-systemvm-master and build-systemvm64-master will rebuild the systemvm template on a daily basis and send the resulting files to that S3 bucket. I would like to update

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

2014-02-24 Thread Hugo Trippaers
On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote: It looks like a lot of the license headers are wrong in this file. Please make sure they are complying to the license headers as they should be for CloudStack code. See the LICENSE.header file for examples, especially the copyright

developers and mysql

2014-02-24 Thread Hugo Trippaers
Heya, as the mysql dependency is now set to provided in all the poms to fix our license compliancy the jetty target and the deployed targets are not working. I’m trying to configure an optional profile to enable those targets to include the mysql dependency while executing, but so far no

Re: [DISCUSS] Policy blocker?

2014-02-24 Thread Hugo Trippaers
Guys, I did a quick check using the scanner at http://www.sonatype.com/application-health-check. According to that report we need to do some additional checking of our dependencies. Licenses: Copyleft: 2 Non-standard: 9 Weak-copyleft: 15 Liberal: 82 I can’t get the exact details as

Yet another mail on code quality

2014-02-24 Thread Hugo Trippaers
Guys, Please pay attention to the code you are committing. Today i fixed a number of issues that were introduced in recent code, these are bugs that could have been prevented from entering master by either testing or running the findbugs checks. One was committed directly, the other one

Re: developers and mysql

2014-02-24 Thread Hugo Trippaers
affect the developer issues. -He who needs more maven experience On Feb 24, 2014, at 7:36 AM, Hugo Trippaers h...@trippaers.nl wrote: Heya, as the mysql dependency is now set to provided in all the poms to fix our license compliancy the jetty target and the deployed targets

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-21 Thread Hugo Trippaers
Heya, Just pushed commit ac00ab0087ca8f59184121697f7ac4343a694093 Author: Hugo Trippaers htrippa...@schubergphilis.com Date: Fri Feb 21 14:54:38 2014 +0100 Cleanup all mysql dependencies and set all to provided. This will set all mysql dependencies to provided and clean them up

<    1   2   3   4   5   6   >