Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605454
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605401
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,143 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605406
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java
---
@@ -0,0 +1,93 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605399
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,143 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605394
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java
---
@@ -0,0 +1,111 @@
+//Licensed
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605389
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java
---
@@ -0,0 +1,85 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605375
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,106 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605363
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,138 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605369
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,138 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605358
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,138 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605347
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,138 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605350
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,138 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605339
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,64 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605332
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,64 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605311
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,72 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605319
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,64 @@
+//Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605271
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,72 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605276
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,72 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605268
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java ---
@@ -0,0 +1,73 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605263
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java ---
@@ -0,0 +1,73 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605260
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java ---
@@ -0,0 +1,73 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605251
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605245
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605243
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605247
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605257
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605235
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java ---
@@ -0,0 +1,73 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605216
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605238
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,201 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605231
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDao.java ---
@@ -0,0 +1,43 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605166
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605101
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605032
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37604922
--- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
@@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37604908
--- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
@@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37604919
--- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
@@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37604903
--- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
@@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-132442691
@DaanHoogland @kishankavala @jburwell The documentation to run and check
the plugin are in this pull request:
https://github.com/apache/cloudstack-docs
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30
CLOUDSTACK-8592: Quota plugin usage documentation
This document provides information on configuring and running the quota
service. It also provides information on various
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-130971943
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/689
Quota master
This pull request is for quota service implementation, divided into
following two commits:
1. Quota server side implementation
a. Quota Framework plugin
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/608#issuecomment-122915463
I am not sure how severe are the coverity reported issues. If there are
customers who may want to upgrade then it is better to wait before depreciating
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/575#issuecomment-120815287
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120215440
This was much needed. The code looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98430113
The issue has got entangled, let me try to summarise what each of us has
been trying to do:
The initial fix itself takes a step into right
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98148840
Another thing to note is that while changing some of this legacy
understanding, it is not just the code that needs improvement/change, it is all
the
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98093700
Daan,
Yes, I agree. We can define a proper state and introduce it. I guess
there is some tribal knowledge involved here that Koushik and myself were
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98091401
I agree with Koushik here. The purpose of an HA investigator is to either
say that host is UP or Down or it does not know for sure. A host that has not
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98087158
The way HA is implemented, ânullâ is a valid return value from an
investigator. The valid values are Up, Down or null.
https://cwiki.apache.org
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-10998674
Rajani, you want to merge your commit ? It looks good to me. The first set
of tests have usually run without
401 - 450 of 450 matches
Mail list logo
