[GitHub] cloudstack pull request #1952: CLOUDSTACK-9790: fix NPE in case of Basic zon...

2017-02-17 Thread sgoeminn
GitHub user sgoeminn opened a pull request: https://github.com/apache/cloudstack/pull/1952 CLOUDSTACK-9790: fix NPE in case of Basic zone. This PR fixes the creation of a basic zone. https://issues.apache.org/jira/browse/CLOUDSTACK-9790 You can merge this pull request

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90520113 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510869 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510701 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510516 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90509963 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean