[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-23 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 It is now fwd merged to all the branches. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 This is pushed to 4.8 but not merged fwd. looks like 4.8 is not fwd merged for some commits and there are conflicts now. Need to investigate further. Will continue on monday. --- If your

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-22 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 Iso failures are due to URL access issues. All good here. merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1624 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1624 @jburwell a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1624 ### ACS CI BVT Run **Sumarry:** Build Number 116 Hypervisor xenserver NetworkType Advanced Passed=103 Failed=2 Skipped=5 _Link to logs Folder (searc

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 I started another test run on this. If it goes through, I will merge this tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 The commits have been squashed, commit message updated to make sense (I think; let me know if it's not right), and rebased against latest 4.8. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-20 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon can you squash your changes, and rebase against latest base branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 No code changes, just updating the commits under it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 Iso tests failed as the iso url wasnt accessible from our test environment. All is well here. @ProjectMoon were there any code changes in your latest rebase? (meaning, do we have to run BVT

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 This branch has been rebased to latest 4.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1624 ### ACS CI BVT Run **Sumarry:** Build Number 112 Hypervisor xenserver NetworkType Advanced Passed=101 Failed=2 Skipped=4 _Link to logs Folder (searc

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-21 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1624 ### ACS CI BVT Run **Sumarry:** Build Number 102 Hypervisor xenserver NetworkType Advanced Passed=99 Failed=2 Skipped=4 _Link to logs Folder (search

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-21 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1624 I started BVT run(xenserver, advanced zone) on this PR. @cloudmonger will post the results here in approx. 4 hrs. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-18 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon I want to get this PR into 4.8.2.0, 4.9.1.0, and 4.10.0.0 for which we will be cutting RCs on 25 Sept 2016. Tests should be the entire Marvin smoke test suite against VMware, KVM,

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-16 Thread nnesic
Github user nnesic commented on the issue: https://github.com/apache/cloudstack/pull/1624 @blueorangutan kick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 We can have someone test it. Are you looking for results of a manual test, reproduction tests, or something automated? A manual test is probably the best from our side because we don't reall

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon we need a test LGTM. I inquired yesterday -- do you have someone lined up to test it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Looks like it's ready for merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 The pull request has been rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon please rebase now, PR 1654 has been merged now. DB upgrades should not cause errors. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 LGTM. Thanks @ProjectMoon as soon as #1654 is merged, we'll get this merged as well. Do we have any regression tests results, especially around the changed code? --- If your project is set up fo

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Alright. I'll rebase it once #1654 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 LGTM for code review. Do we have someone testing for the second LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon we have a code review LGTM on #1654, and have someone lined up to test it and provide the second LGTM. We should have the second LGTM by 1 Sept 2016 at which time you can re-kick

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 Until #1654 is fixed and merged, all 4.8 will fail due to db upgrade failures. /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Have rebased to latest 4.8. Travis build failed with what looks like `Unable to execute /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql: Unknown column 'sta

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Jenkins build log has vanished into 404 oblivion. Will see what happened with Travis (https://travis-ci.org/apache/cloudstack/builds/154436801). --- If your project is set up for it, you ca

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon both the Jenkins and Travis builds are failing. Could you please investigate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Has been rebased against latest 4.8 and the `TODO` comments removed. The map was left alone though. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-22 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @ProjectMoon I would like to get this PR merged for the 4.8.2.0 release, but I need to cut an RC ASAP. Will it be possible for you to address the PR comments in time? --- If your project is

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-05 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1624 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1624 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-05 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1624 A Trillian-Jenkins job has been kicked to build packages and start testing. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1624 @blueorangutan kick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so