[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Tests LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-28 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-468) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34374 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-462) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26823 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Failure wrt debian pkg was due to an env issue. @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-25 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-438) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34149 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-25 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 There were some intermittent errors seen, I'll re-kick tests. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-25 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-24 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ustcweizhou @ozhanrk can you check snapshot and volume related errors in the last test runs above. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-24 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-418) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36313 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-24 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-419) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32311 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Thanks @ozhanrk I'll kick a final test round with xenserver and merge this. @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @rhtyd we have got the required LGTM's now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1710 This code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1710 LGTM! We're running it in our labs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @kiwiflyer @nathanejohnson i saw that you are merged this fix and using it on your ENA CloudStack branch, when you have time could you check the code for possible LGTM's please. --- If

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Do we have LGTMs on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-21 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Trillian test result (tid-377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27282 seconds Marvin logs:

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-20 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-20 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-20 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-20 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-20 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-17 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 hi @jburwell this pr does not delete any kind of snapshots, this patch only prevents, solves a kind of timeout issue on code thats all, nothing more. This is a 4 lines of small fix where

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-17 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk @ustcweizhou I asked a [functionality question](https://github.com/apache/cloudstack/pull/1710#issuecomment-257697031) regarding this functionality to which I cannot find an answer.

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-17 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ustcweizhou @ozhanrk this feels like a relatively narrow case (RBD on KVM), and we are extremely late for 4.9.1.0. We have numerous "small" fixes that could be included that would further

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-17 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @rhtyd @jburwell, With the comments of @ustcweizhou, could we start required tests and if its all ok, could we merge this pr to upcoming 4.9.1.0 release please? --- If your project is

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-07 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1710 @jburwell John, this is a small bug fix for issue: failed to delete snapshot on RBD if the original volume is removed. It will not impact other scenario and bring other issues. I

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-07 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @jburwell , i am so sorry but i do not understand, what you mean by combining fixes under a single pr because this is a only single fix with a 4 lines of code change which only effects rbd

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-07 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk I recommend combining the fixes into a single PR for review cohesion and to ensure that the merge maintains the stability of the release branches. You could either amend this PR with

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-01 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @jburwell , this is a missing 3 line of code fix which was occured because of the fixes done in CLOUDSTACK-8302, CLOUDSTACK-9297. Those fixed bug's are already in 4.9.0 release so the codes

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1710 @ozhanrk Reading the ticket and the patch, this behavior seems like a common request across storage implementations. Some users want snapshots to be automatically removed and others do not.

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-01 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1710 @jburwell Could you please review this PR ? Thanks, @ozhanrk wants to make it in 4.9.1. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-10-20 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi, @ustcweizhou do we need to take any more action or inform some people from ACS to take this PR to upcoming releases? --- If your project is set up for it, you can reply to this email and