[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206934467 Since this is a net new test that I do not have the ability to test and because the tests that have been run are passing, I think this PR is ready. Are we in

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1316#discussion_r58840282 --- Diff: test/integration/component/maint/test_vpc.py --- @@ -0,0 +1,400 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206769730 Agree with @DaanHoogland though looks like it ran no tests (skipped them) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206751818 No, you are right. I no longer have that 'hardware' so I can rerun the test but as I stated earlier the test was basing itself on an exception not being throw

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206664435 I am not sure how that tests this code though. I have that same setup, but I don't think I have the ability to test this configuration. Am I wrong? --- If your

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206578492 real virtualized hardware (advanced zone with 2 kvm hosts, bubble style). --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206441793 @DaanHoogland you ran this against real hardware correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206313506 Squashed changed into single commit and addressed all the review comments and also posted test run results after making changes. Can somebody please merge this

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-175690062 @sanju1010 please squash changes in to a single commit and comment if all outstanding issues are resolved now? --- If your project is set up for it, you can

Re: [GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Will add some validations On Fri, Jan 8, 2016 at 7:51 PM, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/1316#issuecomment-170016433 > > test succeeds as is : > ``` >

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-170016433 test succeeds as is : ``` [root@daans-dev-machinina ~]# ssh cs1 nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2.cfg

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1316#discussion_r49191905 --- Diff: test/integration/component/maint/test_vpc.py --- @@ -0,0 +1,360 @@ +# Licensed to the Apache Software Foundation (ASF) under one