Github user rohit commented on the pull request:
https://github.com/apache/cloudstack/pull/71#issuecomment-73066613
Off topic but I'm not the Rohit you'll are looking for. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
> On 05-Feb-2015, at 7:32 pm, sebgoa wrote:
>
> We should always wait for TravisCI to finish, even for a typo.
The other issue is TravisCI on master branch is timing out which I’ll see
tomorrow or will check next to next week (entire next week is holidays for me)
if no one fixes it.
Regards,
On Feb 5, 2015, at 1:48 PM, Rohit Yadav wrote:
> Hey Sebastien - I merged it only after Erik fixed the DateTime issue
> using Joda. Changes look good to me so I did not wait for TravisCI.
I love you man, but I think that's bad practice :)
We should always wait for TravisCI to finish, even for a
Hey Sebastien - I merged it only after Erik fixed the DateTime issue
using Joda. Changes look good to me so I did not wait for TravisCI.
On Thursday 05 February 2015 06:01 PM, sebgoa wrote:
On Feb 5, 2015, at 1:26 PM, Erik Weber wrote:
I did update it Sebastien :-)
Ah my bad then (cc @Ro
On Feb 5, 2015, at 1:26 PM, Erik Weber wrote:
> I did update it Sebastien :-)
>
Ah my bad then (cc @Rohit), I did not see a conversation update about it.
all is good then :)
> --
> Erik
>
> On Thu, Feb 5, 2015 at 1:16 PM, sebgoa wrote:
>
>> Rohit, check the review, Rajani made a suggesti
I did update it Sebastien :-)
--
Erik
On Thu, Feb 5, 2015 at 1:16 PM, sebgoa wrote:
> Rohit, check the review, Rajani made a suggestion and Terbolous is going
> to change his commit.
> Please revert and let's wait for an updated commit.
>
>
> On Feb 5, 2015, at 12:54 PM, bhaisaab wrote:
>
> >
Rohit, check the review, Rajani made a suggestion and Terbolous is going to
change his commit.
Please revert and let's wait for an updated commit.
On Feb 5, 2015, at 12:54 PM, bhaisaab wrote:
> Github user bhaisaab commented on the pull request:
>
>https://github.com/apache/cloudstack/pul
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/71#issuecomment-73034891
Applied on both 4.5 and master. Thanks for fixing this @terbolous !
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/71#issuecomment-73034212
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/71#issuecomment-73025102
I agree with you :-)
I didn't know we had Joda DateTime available, and with my limited Java
experience I didn't want to head out on the journey to introduce it..
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/71#issuecomment-73023911
Just a personal preference: using [Joda](http://www.joda.org/joda-time/)
DateTime might make it more readable :)
```
DateTime now = DateTime.now(DateTimeZ
GitHub user terbolous opened a pull request:
https://github.com/apache/cloudstack/pull/71
CLOUDSTACK-8215: SAML changing date calculation
Changed to java.util.Calendar which is a bit more straight forward to use.
Tested and verified that the new certificate is valid for 3 ye
13 matches
Mail list logo
