Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164494786
I truly believe we need a meeting to discuss this. I understand the hole
licensing thing, but having a PR open to review is already a prove that the
issue i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164489480
Don't go here. this is about licensing. We have a duty do do this with
extreme prejudice.
On Mon, Dec 14, 2015 at 5:00 PM, borisroman
wrote:
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164475560
@SudharmaJain Could you please open a new PR so it can be merged with
reviews.
---
If your project is set up for it, you can reply to this email and have your
r
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164474404
@rafaelweingartner
It's not about throwing stones, it's about the process.
Simply put: 2 LGTM, and depending on the PR at least 1 with inte
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164471811
@Wilderrodrigues, @borisroman I agree with you that we cannot merge PRs
without two(2) LGTMs and integration tests to check if nothing was broken.
@DaanHo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164467579
+1 for reverting it. And I don't even care if the RAT is broken after the
rever. Reasons are obvious, but we have to stick to the 2 LGTM otherwise the
proje
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164425397
@DaanHoogland Could you please explain why you merged this?
We have a policy stating **2 (TWO)** persons will have to review a PR. One
code review and on
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164417836
argh, thanks @SudharmaJain LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/1243
CLOUDSTACK-9166:Build failed in Jenkins: cloudstack-rat-master #7038
With my last PR#1196, I missed to place the license disclaimer into
CitrixHelperTest.java. Updated the file with the di
10 matches
Mail list logo
