Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137758483
I am merging this as there are two :+1: Let me know if there are any
objections.
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38727056
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137664209
LGTM based on the tracking bugs for addressing some of the issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726623
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726468
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726691
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38731619
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38732126
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137645397
travis build for the PR is here.
https://travis-ci.org/apache/cloudstack/builds/78567814
for some reason, its not showing it here.
---
If your project is set
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136946071
@karuturi LGTM, though one question - once an LDAP group is linked with a
cloudstack domain, and then say if I manually create a user in cloudstack's
domain first
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512226
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136980464
users are added based on the username. So, in this case LDAP user wont be
added(it will error out). CS user will exist and will continue to work with
earlier
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511573
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511898
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38511940
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512420
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512312
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137344109
@koushik-das I created two issue for the open items. I will track these
later
https://issues.apache.org/jira/browse/CLOUDSTACK-8797
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38515428
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38513021
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38512709
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38513100
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392031
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38391829
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392290
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38392508
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38401570
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396925
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397250
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -189,6 +194,21 @@ public LdapUser getUser(final
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397611
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399204
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399252
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396821
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396794
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397144
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399524
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38399931
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username,
String
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38400365
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38396458
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38397126
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -189,6 +194,21 @@ public LdapUser
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38400169
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
---
@@ -52,21 +58,71 @@ public LdapAuthenticator(final
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38410923
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302129
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303506
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303769
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303804
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38304057
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38301615
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38301757
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302004
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38302765
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303216
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -39,6 +39,9 @@
private static final
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38303622
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38383999
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384079
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384082
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -39,6 +39,9 @@
private static final
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136589494
updated the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384161
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384124
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38383968
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384030
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384040
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114 @@
+/*
+ *
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384226
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38384216
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled()
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-136249877
Can someone review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/755
Cloudstack:8647 LDAP Trust AD and Autoimport
Today, CloudStack can automatically import LDAP users based on the
configuration to a domain or an account. However, any new users in LDAP aren't
67 matches
Mail list logo
