Github user kansal closed the pull request at:
https://github.com/apache/cloudstack/pull/618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125552998
Closing this pull request. Will open one for each issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35524999
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -358,7 +363,8 @@ private boolean setup() {
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35524889
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -119,12 +123,12 @@
@Override
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125154356
@kansal Please see my comments. While it's okay, please squash the commits
into two separate commits; one targeting the saml related stuff and second one
targeting
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35521408
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -358,7 +363,8 @@ private boolean setup() {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35521326
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -119,12 +123,12 @@
@Override
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125150991
LGTM :+1:
Thanks for the improvements!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125136388
LGTM. @bhaisaab can you also take a look at the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125106632
@DaanHoogland Added the test file. Checking only the false cases.
@wilderrodrigues Got away with the IF statements and replaced with the api
@karuturi suggested. Plea
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-124330473
instead of a notnull check everywhere, can you use a Non Nulllable
ArrayList for tags or use CollectionUtils.addIgnoreNull() api?
---
If your project is set up for
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-124034693
@kishankavala: The message has been changed.
@karuturi: Added the path. Please check
I have also made another change with respect to solving this problem o
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-124034602
thanks @kansal
Can you add some test cases (for null values found for instance)?
LGTM
---
If your project is set up for it, you can reply to this email
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35291257
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -368,8 +368,14 @@ private boolean setup() {
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35290636
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -368,8 +368,14 @@ private boolean setup(
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/618
Dereference NULL return value
No check on the null value of metadatafile. If null, the following
operations failed. Added null check for the metadatafile.
You can merge this pull request into a
16 matches
Mail list logo
