Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-222135268
@rodrigo93 thanks.
@DaanHoogland, @swill, @rhtyd can someone help us here with the note
@rodrigo93 has highlighted?
I have sent an email to
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-222007302
Hello again @rafaelweingartner,
I did as you suggested. I also checked that the variable **file** was not
used anywhere else besides lines 60 - 76, so I also
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221426317
Hi @rafaelweingartner ,
Thanks for the advice. I will take a look on that and do the proper changes
as soon as I can.
---
If your project is set up for it,
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221028275
@rodrigo93,
I was reviewing your PR, nice work; but, I think you can remove some other
lines too.
I checked and the variable
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1557
Removed unused methods from XenServerConnectionPool
Removed the following methods that are unused from the class
_com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool_:
-
