Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-119515211
Thanks, @DaanHoogland
Will proceed from here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-119509684
L reasonably GTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34128899
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -407,10 +410,10 @@ def fw_vpcrouter(self):
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34126781
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -407,10 +410,10 @@ def fw_vpcrouter(self):
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34126397
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -407,10 +410,10 @@ def fw_vpcrouter(self):
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34126048
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -407,10 +410,10 @@ def fw_vpcrouter(self):
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34125971
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -407,10 +410,10 @@ def fw_vpcrouter(self):
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-119490399
@DaanHoogland @remibergsma @karuturi
It LGTM.
There is still 1 issue, that was also mentioned by Ian, but I'm fixing that.
The deta
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r34012792
--- Diff: test/integration/component/test_vpc_redundant.py ---
@@ -0,0 +1,506 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-118881977
Hi @isoutham
Unfortunately the test is failing. Details about my environment and results
below:
Management Server running on CentOS 7.1
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r33914408
--- Diff: test/integration/component/test_vpc_redundant.py ---
@@ -0,0 +1,506 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/558#discussion_r33905368
--- Diff: test/integration/component/test_vpc_redundant.py ---
@@ -0,0 +1,506 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-118279061
Only if something get pushed to the branch which generated the PR.
Only 1 job out of 9 timed out... I wouldn't bother.
---
If your project is set u
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-118275941
@isoutham @wilderrodrigues is there a way to trigger the build again?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-118274398
Travis failed due timeout... so, that's not relevant and won't be taken
into account when reviewing the PR:
===
No output has been received in th
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/558#issuecomment-118274161
Nice one, @isoutham !
I will test it this week and also try to get someone else to have a look so
we get the 2 LGTM needed to merge.
Thanks!
GitHub user isoutham opened a pull request:
https://github.com/apache/cloudstack/pull/558
Vpcr Marvin test and some fixes for vprc
A combined commit because otherwise it would not make sense.
If I commit the fixes alone there is not test to verify them
If I commit the te
18 matches
Mail list logo
