[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r91006590 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-02 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90676681 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@ public

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-02 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90676133 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@ public

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-01 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90595496 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@ public

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90438253 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-10-03 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1600 Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the “createSnapshot” API command. Depending on the locationType,

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-10-03 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-07 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1600 Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the “createSnapshot” API command. Depending on the locationType,

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-07 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259462 --- Diff: api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java --- @@ -0,0 +1,130 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259447 --- Diff: core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java --- @@ -51,6 +50,7 @@ private final String url; private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259407 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -328,15 +412,64 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259373 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259356 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259343 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259202 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259286 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259303 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259257 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -212,20 +251,47 @@ public

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77259176 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77254138 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77220737 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -328,15 +412,64 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77218636 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77210539 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-09-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77209873 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -328,15 +412,64 @@ private void

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77080602 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -212,20 +251,47 @@ public

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77080424 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77080328 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77079861 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77079527 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -92,7 +90,34 @@

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77079000 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77078902 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77077921 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77077963 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -380,6 +513,122 @@ private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77074337 --- Diff: core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java --- @@ -51,6 +50,7 @@ private final String url; private

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77074073 --- Diff: api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java --- @@ -0,0 +1,130 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77073945 --- Diff: api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java --- @@ -0,0 +1,130 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-08-31 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r77073521 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -82,6 +82,10 @@ @Param(description = "valid types are

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-07-12 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r70563575 --- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java --- @@ -82,6 +82,10 @@ @Param(description = "valid types are

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-07-12 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r70425148 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java --- @@ -195,24 +196,37 @@ public void create() throws

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-06-30 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1600 Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the “createSnapshot” API command. Depending on the locationType,