Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r100267498
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96295051
--- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java ---
@@ -80,4 +80,8 @@ public boolean isDisplay() {
return display;
}
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294598
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294371
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294242
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294332
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable)
}
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294219
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514039
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95515374
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517419
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517522
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable)
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95514745
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95517926
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516498
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516609
--- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java ---
@@ -80,4 +80,8 @@ public boolean isDisplay() {
return display;
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839433
--- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java ---
@@ -123,4 +125,12 @@ public boolean getQuiescevm() {
public void
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84841681
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -610,7 +615,11 @@ public UserVm revertToSnapshot(Long vmSnapshotId)
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84841375
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -639,10 +648,57 @@ else if (jobResult instanceof Throwable)
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839190
--- Diff: core/src/com/cloud/agent/api/VMSnapshotTO.java ---
@@ -35,6 +35,7 @@
private VMSnapshotTO parent;
private List volumes;
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839712
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
---
@@ -128,7 +128,7 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84839559
--- Diff: engine/schema/src/com/cloud/vm/snapshot/VMSnapshotVO.java ---
@@ -248,4 +252,9 @@ public void setRemoved(Date removed) {
public
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84767316
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -50,3 +50,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84766346
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -50,3 +50,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r84757955
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -50,3 +50,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1727
CLOUDSTACK-9539: Support changing Service offering for instance with VM
Snapshots
## Actual behaviour
CloudStack doesn't support changing service offering for vm instances which
have vm
26 matches
Mail list logo
