Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-09-01 Thread Mike Tutkowski
At several of the companies where I've worked before, we would hold "bug court" a couple times per week as the release marched on. Representatives from different areas (product marketing, sales, support, engineering, etc.) would attend and we'd go through all issues opened since the previous bug

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-09-01 Thread Daan Hoogland
There is something like this on the page by Remi on the new release procedure. It is one of the lesser things about it. I think we should only look at stability. The discussion on what is minor or major is not something we want to need to have. On Tue, Sep 1, 2015 at 3:48 AM, Mike Tutkowski

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread David Nalley
On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das wrote: > I am no longer able to start MS after this. I did a clean build followed by > starting MS. Did travis pass for it? Should we revert? > Yes, and in general, when things break you should feel empowered to revert (still

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Daan Hoogland
As David says; Though I think it is very polite of you to wait and ask around, you have this right if you can show master doesn't work. On Mon, Aug 31, 2015 at 6:06 PM, David Nalley wrote: > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das > wrote: > > I am

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-31 Thread Mike Tutkowski
What do we think, though, about tickets listed as Minor going in at this point in 4.6 development? If they entail a trivial change in only a file or two, it's probably OK, but where should we draw the line? At some point as the release goes on, we should stop accepting PRs that are tied to Minor

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-30 Thread Mike Tutkowski
I would say, yeah, revert it. Daan and I did a visual walk through of the code, but I don't think either of us did a build and tried to run it. I thought the tests said they were good on Travis, though. On Sun, Aug 30, 2015 at 10:57 PM, Koushik Das koushik@citrix.com wrote: I am no longer

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-30 Thread Mike Tutkowski
In fact, the JIRA ticket is listed as Minor. At this point in 4.6, I don't think we want to merge in code for tickets listed as Minor. Perhaps Remi can confirm or deny that. On Sun, Aug 30, 2015 at 11:03 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I would say, yeah, revert it. Daan

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-30 Thread Remi Bergsma
I say we revert so the 4.6 testing can continue and then work on fixing why this broke the build. No hard feelings, we simply need master to build. If someone can revert, please do. I can do it in about two hours. Sent from my iPhone On 31 Aug 2015, at 06:58, Koushik Das

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-08-30 Thread Rajani Karuturi
I am doing a build with revert locally. Will revert once done. ~Rajani On Mon, Aug 31, 2015 at 11:11 AM, Remi Bergsma rberg...@schubergphilis.com wrote: I say we revert so the 4.6 testing can continue and then work on fixing why this broke the build. No hard feelings, we simply need master to