Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review25387 --- Commit 42e4b74402ec5aa254a5bdc714f1446894aff3af in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review25389 --- Commit 9cfd434640cf51bbd591ef4f34f90163ebb255df in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-14 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review25134 --- Commit ba90fa91d3da56d4b63a0850d58add34cc5a7a2c in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-09 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24902 --- Commit 6d86af85baa57bb20ec9642cbd1cd82c002dcfef in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-09 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24903 --- Commit dacc4e1a4f7dc3763f16acc2cddd936fdc2fbd42 in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-09 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24904 --- Commit 64bb7007053d004fe7a8ac3b610e20df69f16bab in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-08 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24880 --- Commit b2ed632396fb57fedd7f88d36408299167f963c0 in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-08 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24881 --- Commit ea50c6663fcff4b166fc43cb652638e3c1080c64 in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-08 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24882 --- Commit 630d2561d2b13882892799507613823bcc04b4ac in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24778 --- Commit 9ec8d48945f465b74284034b94f12efdd319bd0f in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-06 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24711 --- Commit 5cb090ed40816950d0c9dbb62135240a7c8b1e3d in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-06 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24712 --- Commit c229244dabb5c5685fbb1aab84de9afdf199820b in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/ --- (Updated Aug. 5, 2013, 10:38 a.m.) Review request for cloudstack, edison su

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24650 ---

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/ --- (Updated Aug. 5, 2013, 6:07 p.m.) Review request for cloudstack, edison su and

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24657 --- Ship it! Ship It! - edison su On Aug. 5, 2013, 6:07 p.m., Wei

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24656 --- Commit 0f539b4ce1b07c672a776ffa806dabb70c528afe in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-05 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24659 --- Commit 1e4ff7f4532a39355ef5e5bfaa8dbfbc1f1c27e4 in branch

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24511 --- Review 13223 failed the build test : FAILURE The url of build

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24520 --- I haven't tested the patch, but I'm missing some comments. Can we

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wei Zhou
On Aug. 2, 2013, 11:09 a.m., Wido den Hollander wrote: I haven't tested the patch, but I'm missing some comments. Can we add clear comments as to WHY this is in the code? Otherwise I'm afraid this will become legacy and in 6 months new committer won't have the slightest idea of why

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/ --- (Updated Aug. 2, 2013, 1:03 p.m.) Review request for cloudstack, edison su and

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24589 ---