Re: Using Maven wrapper

2017-11-15 Thread Khosrow Moossavi
Not at all, I'll open one soon. On Wed, Nov 15, 2017 at 7:28 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > This seems to be interesting. Would you mind opening a PR? > > On Tue, Nov 14, 2017 at 7:53 PM, Khosrow Moossavi > wrote: > > > No changes required in pom whatsover. Only

Re: Using Maven wrapper

2017-11-15 Thread Rafael Weingärtner
This seems to be interesting. Would you mind opening a PR? On Tue, Nov 14, 2017 at 7:53 PM, Khosrow Moossavi wrote: > No changes required in pom whatsover. Only the scripts/guides. For examaple > in: > > /cloudstack/tools/travis/install.sh > /cloudstack/deps/install-non-oss.sh > /cloudstack/pack

Re: Using Maven wrapper

2017-11-14 Thread Khosrow Moossavi
No changes required in pom whatsover. Only the scripts/guides. For examaple in: /cloudstack/tools/travis/install.sh /cloudstack/deps/install-non-oss.sh /cloudstack/packaging/package.sh (even lines 63-69 will become useless) ... -- Khosrow On Tue, Nov 14, 2017 at 4:33 PM, Rafael Weingärtner < r

Re: Using Maven wrapper

2017-11-14 Thread Rafael Weingärtner
This seems to be something interesting to be used. Do we need to make changes to our pom.xml files to use it? Or is it only a matter of protocol/guidelines? On Tue, Nov 14, 2017 at 7:06 PM, Khosrow Moossavi wrote: > Well basically anywhere (either manual or in scripts/CI) maven is required > to

Re: Using Maven wrapper

2017-11-14 Thread Khosrow Moossavi
Well basically anywhere (either manual or in scripts/CI) maven is required to do something with ACS. Basically using *"./mvnw foo bar -Pbaz" *instead of *"mvn foo bar -Pbaz"* in which mvnw is an executable file in the repo not installed in the OS. Khosrow Moossavi Cloud Infrastructure Developer

Re: Using Maven wrapper

2017-11-14 Thread Rafael Weingärtner
You mean, to use this tool to help us managing maven versions in ACS' community distributed CIs and devs environments? On Tue, Nov 14, 2017 at 5:15 PM, Khosrow Moossavi wrote: > Hi > > I'm new to ACS community, so I'm not sure if this topic has already come up > before. > > I wanted to suggest