Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-19 Thread Syed Ahmed
Thanks Murali. On Tue 19 Nov 2013 01:10:45 PM EST, Murali Reddy wrote: I have cherry-picked to 4.3. Will be pushing in a while. On 19/11/13 11:25 PM, "Syed Ahmed" wrote: Hi Murali, Should I send a patch for the 4.3 branch as well? Thanks, -Syed On Tue 19 Nov 2013 12:01:53 PM EST, Murali

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-19 Thread Murali Reddy
I have cherry-picked to 4.3. Will be pushing in a while. On 19/11/13 11:25 PM, "Syed Ahmed" wrote: >Hi Murali, > >Should I send a patch for the 4.3 branch as well? > >Thanks, >-Syed > >On Tue 19 Nov 2013 12:01:53 PM EST, Murali Reddy wrote: >> This is an automatically generated e-mail. To reply,

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-19 Thread Alena Prokharchyk
lto:alena.prokharc...@citrix.com>> Subject: Re: Review Request 15489: Adding protocol parameter to loadbalancer response Hi Murali, Should I send a patch for the 4.3 branch as well? Thanks, -Syed On Tue 19 Nov 2013 12:01:53 PM EST, Murali Reddy wrote: This is an automatically generated

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-19 Thread Syed Ahmed
Hi Murali, Should I send a patch for the 4.3 branch as well? Thanks, -Syed On Tue 19 Nov 2013 12:01:53 PM EST, Murali Reddy wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/ Ship it! commit 481af07fb130d24490efe6a98970cb13104e4046 - Mur

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-19 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/#review29115 --- Ship it! commit 481af07fb130d24490efe6a98970cb13104e4046 - Murali

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-15 Thread Alena Prokharchyk
> On Nov. 15, 2013, 1:53 p.m., Murali Reddy wrote: > > Syed I dont think you added 'protocol' to createLoadBalancerRule. There > > should not be 'protocol' in the LoadBalancerContainer? > > Syed Ahmed wrote: > I actually did add the 'protocol' parameter to createLoadBalancerRule. > This ma

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-15 Thread Alena Prokharchyk
gt;> Date: Friday, November 15, 2013 9:21 AM To: Murali Reddy mailto:muralimmre...@gmail.com>>, Alena Prokharchyk mailto:alena.prokharc...@citrix.com>> Cc: Syed Ahmed mailto:sah...@cloudops.com>>, cloudstack mailto:dev@cloudstack.apache.org>> Subject: Re: Review Request

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-15 Thread Syed Ahmed
> On Nov. 15, 2013, 1:53 p.m., Murali Reddy wrote: > > Syed I dont think you added 'protocol' to createLoadBalancerRule. There > > should not be 'protocol' in the LoadBalancerContainer? I actually did add the 'protocol' parameter to createLoadBalancerRule. This maps to `lb_protocol` field in t

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-15 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/#review28968 --- Syed I dont think you added 'protocol' to createLoadBalancerRule. Th

Re: Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-13 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/ --- (Updated Nov. 13, 2013, 6:08 p.m.) Review request for cloudstack, Alena Prokhar

Review Request 15489: Adding protocol parameter to loadbalancer response

2013-11-13 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/ --- Review request for cloudstack, Alena Prokharchyk and Murali Reddy. Repository: