Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/#review34466 ---

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Wilder Rodrigues
On Feb. 14, 2014, 9:08 a.m., Hugo Trippaers wrote: plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java, line 63 https://reviews.apache.org/r/18072/diff/1/?file=484234#file484234line63 Why recreate the map? After explained how this method could

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Wilder Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/ --- (Updated Feb. 14, 2014, 1:52 p.m.) Review request for cloudstack, daan

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Wilder Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/ --- (Updated Feb. 14, 2014, 2:43 p.m.) Review request for cloudstack, daan

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/#review34493 --- Ship it! commit 643301e031817cc4495fff5d37bd4970ca578c9c Author:

Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-13 Thread Wilder Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/ --- Review request for cloudstack, daan Hoogland and Hugo Trippaers. Repository: