Re: Review Request 23735: Fix deployment of data center with marvin

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review79037 --- Thank you for submitting your CloudStack contribution through

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-24 Thread Miguel Ferreira
On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote: tools/marvin/marvin/marvinLog.py, line 168 https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168 Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-24 Thread Miguel Ferreira
On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote: tools/marvin/marvin/marvinLog.py, line 168 https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168 Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-23 Thread Santhosh Edukulla
On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote: tools/marvin/marvin/marvinLog.py, line 168 https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168 Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile path, as similar to

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote: tools/devcloud/devcloud-advanced.cfg, line 133 https://reviews.apache.org/r/23735/diff/1/?file=636739#file636739line133 Is this change required, compared to earlier devcloud cfg, it was a working cfg for devcloud. That would

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
On July 21, 2014, 1:58 p.m., Hugo Trippaers wrote: tools/devcloud/devcloud-advanced.cfg, line 133 https://reviews.apache.org/r/23735/diff/1/?file=636739#file636739line133 For devcloud deployments the mgtSvrIp should be .10 as the management server is running on the devcloud

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/ --- (Updated July 22, 2014, 7:24 a.m.) Review request for cloudstack, daan

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Miguel Ferreira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/ --- (Updated July 22, 2014, 7:24 a.m.) Review request for cloudstack, daan

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-22 Thread Santhosh Edukulla
On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote: tools/marvin/marvin/deployDataCenter.py, line 1099 https://reviews.apache.org/r/23735/diff/1/?file=636741#file636741line1099 Instead of this, can we make logger node under devcloud.cfg as similar to setup/dev/advanced.cfg. We

Review Request 23735: Fix deployment of data center with marvin

2014-07-21 Thread Miguel Ferreira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/ --- Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla,

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-21 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review48216 --- tools/devcloud/devcloud-advanced.cfg

Re: Review Request 23735: Fix deployment of data center with marvin

2014-07-21 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review48217 --- tools/devcloud/devcloud-advanced.cfg