We'll live with it this time I'd say ;-) Thanks for bringing it up!
Regards, Remi
On 06 Aug 2015, at 08:09, Mike Tutkowski mike.tutkow...@solidfire.com wrote:
Fair enough
Do you want me to revert this one or are we OK to just live with it?
On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma
Fair enough
Do you want me to revert this one or are we OK to just live with it?
On Wed, Aug 5, 2015 at 11:57 PM, Remi Bergsma rberg...@schubergphilis.com
wrote:
Hi Mike,
Yes, I want everything to go through a PR.
Otherwise:
- there are no Travis CI and other tests run
- we need to
How's about this:
Super-Trivial:
:)
On Thu, Aug 6, 2015 at 2:34 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
H Mike,
If you find a good title for such a trivial change bucket pr it makes
creating release notes easier as well. Try to group them by mental state or
character (can you say
H Mike,
If you find a good title for such a trivial change bucket pr it makes
creating release notes easier as well. Try to group them by mental state or
character (can you say that in English?)
On Thu, Aug 6, 2015 at 8:31 AM, Mike Tutkowski mike.tutkow...@solidfire.com
wrote:
Sounds good
I
Sounds good
I could always cache those kinds of trivial changes and create a single
PR for them later, too.
On Thu, Aug 6, 2015 at 12:29 AM, Remi Bergsma rberg...@schubergphilis.com
wrote:
We'll live with it this time I'd say ;-) Thanks for bringing it up!
Regards, Remi
On 06 Aug 2015, at
Woops...I meant to provide the URL to the diff:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=2c8d179b7abf6da1c99390788c3329f243e172db;hp=abfe33a2441679b0105e2023472614a8648e6fcb
On Wed, Aug 5, 2015 at 10:48 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Hi
Hi everyone,
Hopefully this isn't an issue, but I occasionally have super trivial, but
useful changes to SolidFire-only code that I'd like to push without
bothering with a PR.
For example:
Hi Mike,
Yes, I want everything to go through a PR.
Otherwise:
- there are no Travis CI and other tests run
- we need to describe what 'trivial' is and what not
- the change is not visible
The goal is a stable master at all times and we cannot reach that with direct
commits.
I do get your
