Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/578#issuecomment-121140173
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/578#issuecomment-121138178
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/578#issuecomment-120455619
LGTM (squash maybe)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/578
Coverity resource leaks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack
coverity-resource-leaks
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/564
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/564#issuecomment-119917601
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/564#issuecomment-119546107
changes looks good. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
I have started working on this in [1] and found that a lot of this is
in the upgrade code. I fixed a few of those and all of them in other
code. I will triage the upgrade issues separately and like to have a
review on [1] now, please.
[1] https://github.com/apache/cloudstack/pull/564
On Tue, Jul
On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi wrote:
> This not a good candidate for squashing/huge commit.
> If a regression is found in any of the fixes, it will be easier to just
> revert it than reverting all the 70 commits.
>
> ~Rajani
Thanks Rajani, I allready made a booboo in the first
This not a good candidate for squashing/huge commit.
If a regression is found in any of the fixes, it will be easier to just
revert it than reverting all the 70 commits.
~Rajani
On Tue, Jul 7, 2015 at 3:47 PM, Rohit Yadav
wrote:
>
> On 07-Jul-2015, at 3:40 pm, Daan Hoogland wrote:
>
> I will n
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/564
coverity resource leaks
This PR holds fixes for different resource leaks of the type that can be
fixed by using try-with resource. The complete category is to be absent from
coverity
On 07-Jul-2015, at 3:40 pm, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:
I will not do it in one commit, if we insist on a PR i will do 73 commits
in one PR.
Fine.
Regards,
Rohit Yadav
Software Architect, ShapeBlue
[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
M. +91 88 262 30892 |
Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits.
On Tue, Jul 7, 2015 at 12:15 PM, sebgoa wrote:
>
> On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote:
>
>> I will not do it in one commit, if we insist on a PR i will do 73 commits
>> in one PR.
>>
>
> are you automat
On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote:
> I will not do it in one commit, if we insist on a PR i will do 73 commits
> in one PR.
>
are you automating those commits ?
I would not mind scanning through them and giving green light. and in that case
squash might be good :)
> On Tue, J
I will not do it in one commit, if we insist on a PR i will do 73 commits
in one PR.
On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav
wrote:
>
> On 07-Jul-2015, at 3:29 pm, Daan Hoogland wrote:
>
> I want permission to go ahead and address these issues and not create
> one huge or 73 small PRs. Can
On 07-Jul-2015, at 3:29 pm, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:
I want permission to go ahead and address these issues and not create
one huge or 73 small PRs. Can I?
One huge commit would be fine, testing/merging 73 small PRs is going to be some
work.
Regards,
Rohit Yadav
S
Guys `n' Dolls,
I want an exception to the rule requiring two LGTMs for any commit:
coverity reports 73 high impact issues at the moment. All of them are
resource leaks that can be solved by the well known pattern of using
try-with-resource. We (and I do mean a lot of us) have been fixing
th
/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed resource leaks, null dererence issues, performance issues and bugs
> reported by coverity. Simple bug in generic dao was found during these
> changes, fixed that as well.
>
>
>
uly 4, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fix
apache.org/r/23226/
> ---
>
> (Updated July 4, 2014, 9:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
&g
Prateek and daan Hoogland.
Changes
---
Added try-with-resource and other misc fixes for coverity.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks, null dererence issues, performance issues and bugs
2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed resou
ttps://reviews.apache.org/r/23226/
> ---
>
> (Updated July 2, 2014, 8:44 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
ateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed resource leaks, null dererence issues, performance issues and bugs
> reported by coverity. Simpl
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed resource leaks, null dererence issues, performance issues and bugs
> reported by coverity. Simple bug in generic dao
Prateek and daan Hoogland.
Summary (updated)
-
Fixed resource leaks, null dererence issues, performance issues and bugs
reported by coverity
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description (updated)
---
Fixed
://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks, null dererence issues, performance and bugs reported by
coverity
Diffs
-
engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e
engine/schema/src/com/cloud/storage/dao
Prateek and daan Hoogland.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks, null dererence issues, performance and bugs reported by
coverity
Diffs
-
engine/schema/src/com/cloud/dc/dao
ne 24, 2014, 6:06 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> 1. Fixed
Prateek and daan Hoogland.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
1. Fixed few Resource Leaks reported by coverity in master
2. As well added support for a config command to simulator in master
Diffs
-
engine
.
Repository: cloudstack-git
Description
---
1. Fixed few Resource Leaks reported by coverity in master
2. As well added support for a config command to simulator in master
Diffs
-
engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 836a537
framework/db/src/com/cloud/utils
.org/r/22859/
> ---
>
> (Updated June 23, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> -
Hoogland.
Changes
---
Fixed the mentioned issue
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
fixed resource leaks reported by coverity
Diffs (updated)
-
engine/schema/src/com/cloud/upgrade/dao
ugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> fixed resource leaks reported by coverity
>
>
> Diffs
> -
>
> engine/schema/src/com/cl
://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
fixed resource leaks reported by coverity
Diffs
-
engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 836a537
framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java
-
>
> (Updated June 20, 2014, 7:23 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> -
: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
---
Fixed resource leaks,invalid value comparisons,null dereferences, invalid
result set loop comparison.
All these issues were fixed in master branch
Diffs
-
engine/schema/src/com
-
>
> (Updated June 14, 2014, 4:57 p.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed resource leaks, null dereferences and other misc issues reported.
>
>
Description
---
Fixed resource leaks, null dereferences and other misc issues reported.
Diffs
-
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 889cad4
engine/schema/src/com/cloud/vm/VMInstanceVO.java 849e042
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm
great Rajani, I am having a look at Upgrade43to44 and will backport
the fix to all others that it applies to:
try(PreparedStatement selectstatement =
conn.prepareStatement("SELECT * FROM 1+1");
ResultSet results = selectstatement.executeQuery()) {
}without finally
On Fri, Jun
Hi All,
Of the 1697 issues reported by coverity in the latest scan, about 187 are in
upgrade###to###.java and many of them are due to RESOURCE_LEAKS because of not
closing the pstmt properly.
For ex:
Resource leak on an exceptional path (RESOURCE_LEAK)
299 }
300
ns, then why not? I think there's good reasons
proposed in this thread.
--Alex
> -Original Message-
> From: Chip Childers [mailto:chipchild...@apache.org]
> Sent: Wednesday, December 11, 2013 4:51 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS][PROPOSAL]Closin
On Wed, Dec 11, 2013 at 09:45:03PM +, Alex Huang wrote:
> Why not just use java 7? What's stopping us?
>
> --Alex
This is a relevant thread with stated objections:
http://markmail.org/message/a4lfcbqwi7y474hy
Why not just use java 7? What's stopping us?
--Alex
> -Original Message-
> From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
> Sent: Wednesday, December 11, 2013 1:28 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS][PROPOSAL]Closing SQLStateme
+1
Wish there was a more elegant solution (like in Java 7)
On 12/10/13 6:01 AM, "Antonio Fornié Casarrubios"
wrote:
>Hi all,
>
>I'm trying to fix some typical "Resource Leak" issues in some cloudstack
>classes. An example could be Upgrade2214to30, but actually the very same
>issue can be found i
Hi all,
I'm trying to fix some typical "Resource Leak" issues in some cloudstack
classes. An example could be Upgrade2214to30, but actually the very same
issue can be found in many other classes.
The reason for this mail is all these occurrences shall be fixed in a
congruent way and I would like
47 matches
Mail list logo
