[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack-docs-admin pull request: change version to 4.6

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-17 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-157371668 Thanks @remibergsma, much appreciated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-install/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack-docs-rn pull request: 4.6

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-rn/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-157373768 Ping @remibergsma Are the tests still running? Cheers, Wilder --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9066: Update testpath to delet...

2015-11-17 Thread pritisarap12
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1078 CLOUDSTACK-9066: Update testpath to delete account after deleting VM's of that account In testpath_snapshot_hardning.py testpath account was getting cleared prior to VM's of that

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

2015-11-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1077 CLOUDSTACK-9069: Newly added project is not showing in the drop down until the browser is refreshed. The created or deleted project was added to/deleted from the list but it was

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-157411446 I've created the PR against 4.6 now. https://github.com/apache/cloudstack/pull/1079 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1079#issuecomment-157411634 This is a duplicate of PR https://github.com/apache/cloudstack/pull/1062 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-157411442 @DaanHoogland FYI test results: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-157418578 Closing this pull request now that it has been created against the 4.6 branch in PR #1079 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread dsclose
Github user dsclose closed the pull request at: https://github.com/apache/cloudstack/pull/1062 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-157421614 @DaanHoogland Because @bhaisaab wants it in 4.5.3. Otherwise people will upgrade from 4.5.3 to say 4.6.2 and lose a feature. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread dsclose
GitHub user dsclose opened a pull request: https://github.com/apache/cloudstack/pull/1079 CLOUDSTACK-9058 - Respond with "saved_password" if no password is to be issued. The password server on the virtual router should respond with "saved_password" if no password is to be issued.

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1079#issuecomment-157416663 @wilderrodrigues no, i was asked to open this pull request by @remibergsma --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157418520 No, we don't run any xen and I have to use spare time as a matter of professional integrity when doing things on that platform. We don't have our own bubble

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-157410651 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: CLOUDSTACK-9054 use of google-optional as...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1060#issuecomment-157415551 tnx @remibergsma . It can be merged but more important is for it to be a coding policy so I'll link it on dev@ @miguelaferreira Or should we consider going

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1079#issuecomment-157416121 Should it be closed then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1080 CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157417603 @DaanHoogland ... can't the guys at LeaseWeb help with testing against xen or are you the only one with a bubble? No need to close it due to test

[DISCUSS][PROPOSE] use of optional instead of null

2015-11-17 Thread Daan Hoogland
LS, As a spin off from a discussion in a PR where it is no longer relevant I made another PR to show the principle of the use of Optionals[1] Miguel from Schuberg Philis has been proposing this as replacement of the bad practice of returning null

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1080 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1079#issuecomment-157421231 @wilderrodrigues I want to merge this to 4.6, so the one against master should be closed. As we merge forward now, we need bug fixes against 4.6. Otherwise it

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1076#discussion_r45052092 --- Diff: ui/scripts/ui/widgets/multiEdit.js --- @@ -279,7 +279,7 @@ } // Align width to main header

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157399076 @runseb @pdion891 This did not make it into 4.6, will be merged with master. https://github.com/apache/cloudstack/pull/768 --- If

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157404633 thanks, I've looked into Jira, and rollback the publishing of quotas in 4.6 documentation. still merge in master, master branch is not published on RTD.

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1076#discussion_r45074032 --- Diff: ui/scripts/ui/widgets/multiEdit.js --- @@ -279,7 +279,7 @@ } // Align width to main

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157392000 Hi @DaanHoogland, I run integration tests before creating the PRs and that's not manually and I do have only 1 bubble. I just do: * build

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-157393161 How did you test it, @dsclose? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157396108 @pdion891 let me check with @abhinandanprateek I might be wrong --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1073#issuecomment-157409023 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-17 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-157409534 This was tested situationally. Not perfect, but we don't have the Cloudstack test-suite setup yet. Not sure I will have time to do that now. The following

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1076#issuecomment-157409637 Hi @nitin-maharana thanks for the fix! Please make this pull request against 4.6, so it can be fixed there as well. Once merged, it will be forward merged to

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157406551 @wilderrodrigues i have a habbit of -1'ing my own PR at times! this time for instance. I ran this against the bubble and it failed. It was the reason

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157389188 @pdion this should be on the master branch not in the 4.6 branch since quota have not yet been merged...correct ? --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1073#issuecomment-157389878 Hi @ustcweizhou, Okay, I understood. Have you prepared a test to cover it? I mean, we need a test that deploys a DC, creates a redundant VPC, adds

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8592: Quota plugin ...

2015-11-17 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157391102 hum, ok, I will roll it back from 4.6 docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-157426767 hm, this is breaking our policy hard. I have some things of Wei's laying around --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

2015-11-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1082 CLOUDSTACK-9069: Newly added project is not showing in the drop down until the browser is refreshed. The created or deleted project was added to/deleted from the list but it was not

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-17 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-157428042 Right, so what now? Can't we just postpone this till 6.7 and perhaps provide some easy patches in the meanwhile for whoever wants to use in 4.5 and 4.6?

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1076#issuecomment-157440647 Hi @remibergsma Actually 4.6 is nine commits behind this branch. So I am making one more pull request with different branch. Thanks. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1081 CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load For setting the width of each data item for each row of Port Forwarding rules, it was processing all rules.

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1076 CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load For setting the width of each data item for each row of Port Forwarding rules, it was processing all rules.

[GitHub] cloudstack-docs-admin pull request: change version to 4.6

2015-11-17 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/33 change version to 4.6 doc version to 4.6, not changes regarding new features :-S You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack-www pull request: 4.6.0 is out!

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-www/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

2015-11-17 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1083#issuecomment-157551229 Ping @wido @remibergsma @wilderrodrigues @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9062: Improve S3 implementatio...

2015-11-17 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1083 CLOUDSTACK-9062: Improve S3 implementation. The S3 implementation is far from finished, this commit focuses on the bases. - Upgrade AWS SDK to latest version. - Rewrite S3

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-17 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1073#issuecomment-157485350 @wilderrodrigues @remibergsma @DaanHoogland this issue indeed happened in my testing environment. After investigation, I found the node was shut down

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1076#issuecomment-157498727 @nitin-maharana You can close this one. When the 4.6 one is merged, it will be forwarded merged to master automatically. --- If your project is set up for it,

Re: DevCloud deployment

2015-11-17 Thread Abhinandan Prateek
The wiki below is much more elaborate on cloudstack setup using virtual box, and good for anyone wishing to be a cloudstack developer. http://www.shapeblue.com/virtualbox-test-env/ On 17/11/15, 2:17 PM, "Илья Толстихин" wrote: >I copied vhd-util from /usr/bin/ on

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

2015-11-17 Thread nitin-maharana
Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack-docs-rn pull request: fix pre 4.5 upgrade instruction

2015-11-17 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/26 fix pre 4.5 upgrade instruction This go into master and 4.6 branch, tag 4.6.0 must be redo to include following changes. I'm suspecting more changes in the RN as we removed

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-157311229 @KrisSterckx @nlivens Guys, we are ready to merge this into master/4.7 now. Since it was rebased last some weeks ago, I'll do a quick test run against current

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-157313386 @jayapalu @karuturi Let's get this into 4.7! Can you respond to the comments please @jayapalu ? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-157321576 Couple of minor things that can go through now and be fixed after this is merged. @miguelaferreira has already tested the PR and showed that it works just

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1071 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: 4.6.0 is out!

2015-11-17 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-www/pull/18#issuecomment-157307389 a bit difficult to review since the files are long. +1 to merge and update if we see any errors on the live site. --- If your project is set up for it, you

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

2015-11-17 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/25#issuecomment-157308289 +1 looking at the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157303792 Wilder, I do run unit test always, but integration test only to the degree that they make sense. Even then it is way more convenient to use the check-pr

Re: DevCloud deployment

2015-11-17 Thread Daan Hoogland
Ilya, it is clearly some network issue but it is not clear to me what. Have a look at any firewalls on your machines. Look in SRLog on the host to see if communication is initiated in the first place and if any errors are there. On Tue, Nov 17, 2015 at 8:47 AM, Илья Толстихин

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-17 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157328375 LGTM I did a centos63 build and it worked as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: cloudstack UI

2015-11-17 Thread Sebastien Goasguen
> On Nov 17, 2015, at 7:24 AM, Abhinandan Prateek > wrote: > > Hi, > > I am considering some improvements to cloudstack UI. Like delinking the > quick view with the details page. Such that the details page can contain > listView. > > Another change

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-157306100 most network tests passed: ``` Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : FAILED

Re: DevCloud deployment

2015-11-17 Thread Илья Толстихин
I copied vhd-util from /usr/bin/ on devcloud to scripts/vm/hypervisor/xenserver of cloudstack. Nothing changed. Also I tried to setup with manuals https://github.com/apache/cloudstack/blob/master/tools/devcloud4/README.md

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/935#discussion_r45038824 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/nicira/ControlClusterStatus.java --- @@ -84,4 +89,17 @@ public int

[GitHub] cloudstack pull request: Quota

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-157311669 @bhaisaab @abhinandanprateek it would be great to include this in 4.7. Can you guys rebase it and resolve the conflicts? @jburwell Can you update your

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Sebastien Goasguen
> On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues > wrote: > > Nice email, Remi! > > The most important point that everyone has to be aware of: > > Master is release branch for 4.7 > > Master has now become the 4.7.0 release

Master aka 4.7 open for new features to be merged!

2015-11-17 Thread Remi Bergsma
Hi all, TL;DR: Features that are have a code review AND integration tests executed against them (resulting in 2x LGTM) can now be merged to master (note “merged”, NO direct commits). Please read [1]. I think it is wise to have one of the RMs do the merge. The window for new features is about 2

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Daan Hoogland
Sebastien, On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen wrote: > > > On Nov 17, 2015, at 7:33 AM, Wilder Rodrigues < > wrodrig...@schubergphilis.com> wrote: > > And for that, I think we should have 4.7 RMs. > we have three so far (don't know if Rajani continues) Remi,

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-157311867 Would be great to include this in 4.7, please ping me when you're ready! --- If your project is set up for it, you can reply to this email and have your reply

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Rajani Karuturi
Daan, I wont be able to continue. I will be OoO during the release timeframe. ~Rajani On Tue, Nov 17, 2015 at 1:55 PM, Daan Hoogland wrote: > Sebastien, > > On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen > wrote: > > > > > > On Nov 17, 2015, at

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1073#issuecomment-157320534 code review done: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/935#discussion_r45038549 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2076,6 +2087,9 @@ private static void

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157320397 code lgtm and my testing is the same as Davis so as I think we want a wide range of users to have a go at this: @wido @remibergsma @resmo @karuturi @NuxRo

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Wilder Rodrigues
I won’t be RM, Daan. Will just continue that work I do in the way I do it. Cheers, Wilder > On 17 Nov 2015, at 09:25, Daan Hoogland wrote: > > Sebastien, > > On Tue, Nov 17, 2015 at 8:21 AM, Sebastien Goasguen > wrote: > >> >>> On Nov 17, 2015,

Re: Hello 4.6.0, now what?!

2015-11-17 Thread Daan Hoogland
to bad On Tue, Nov 17, 2015 at 9:45 AM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > I won’t be RM, Daan. Will just continue that work I do in the way I do it. > > Cheers, > Wilder > > > > On 17 Nov 2015, at 09:25, Daan Hoogland wrote: > > > > Sebastien, >

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-17 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1085 [4.6] Cannot list vlanipranges by keyword Before change: cloudmonkey> list vlanipranges keyword=118 : Caught: com.mysql.jdbc.JDBC4PreparedStatement@18f36b6e: SELECT vlan.id,

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1075#discussion_r45169717 --- Diff: packaging/package.sh --- @@ -18,26 +18,37 @@ function usage() { echo "" -echo "usage: ./package.sh

[KVM] NPE when createVolume by a snapshot whose source volume is deleted

2015-11-17 Thread Qian Shaohua
Hi all, CS 4.5.2 KVM KVMStorageProcessor checks source volume of a snapshot for the ImageFormat in createVolumeFromSnapshot(CopyCommand cmd). If the source volume is deleted, we get NPE. 2015-11-18 14:02:57,259 DEBUG [o.a.c.e.o.VolumeOrchestrator] (API-Job-Executor-35:ctx-0c1e2671

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157634027 Building the environment to start testing this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1079#issuecomment-157619773 Okay, understood. I just read the other PR and saw your details about the tests, how you did it, ando also saw that @remibergsma already tested the

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

2015-11-17 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1084 CLOUDSTACK-9067 - As I developer I want to remove all the unused router-shell scripts from ACS This PR removes the unused shell scripts that were present in the ACS project. Those

[GitHub] cloudstack pull request: CLOUDSTACK-9067 - As I developer I want t...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1084#issuecomment-157625899 Ping @remibergsma @miguelaferreira @karuturi @DaanHoogland @borisroman Partial tests results, but I will still run some tests against XenServer 6.2