[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message in UI if user ...

2017-03-15 Thread ramkatru
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1855 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-15 Thread ramkatru
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1868 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1994#discussion_r106313430 --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java --- @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-15 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1994#discussion_r106311985 --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java --- @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1994#discussion_r106306374 --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java --- @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-15 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1994#discussion_r106303439 --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java --- @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {

Re: More Jira tickets clean up

2017-03-15 Thread Tutkowski, Mike
Hi, This one appears to have been fixed a long time ago. I marked it as Fixed and closed the ticket. https://issues.apache.org/jira/browse/CLOUDSTACK-1524 This one is not a big deal. I marked it as Won’t Fix and closed the ticket. https://issues.apache.org/jira/browse/CLOUDSTACK-1432 I went

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-15 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/2003 @swill first_i_p in json -> firstIP in java. This is formatted by google.gson it is defined in api/src/com/cloud/agent/api/to/IpAddressTO.java, and used in

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-15 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/2003 Does anyone know what `first_i_p` represents in the `ips.json` dbag? I am assuming it is the Source NAT IP, but I can't find it represented anywhere in the code (other than in a test). If it

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1994#discussion_r106001103 --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java --- @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {

Re: Not able to setup source-nat for a regular router yet

2017-03-15 Thread Gabriel Beims Bräscher
As far as I know, the log exists for a long time. However, I am not aware of potential issues. Hope that someone can share his/her wisdom on this one. Cheers, Gabriel. Em 15/03/2017 13:10, Jeff Hair escreveu: It's coming from the config scripts on the routers, yes. This is version 4.9.2.0

Re: Not able to setup source-nat for a regular router yet

2017-03-15 Thread Jeff Hair
It's coming from the config scripts on the routers, yes. This is version 4.9.2.0 (it's a fork, but should be similar enough to vanilla). I'm not necessarily noticing problems with it. Connectivity from public IPs on Isolated networks seem to be working. I'm just wondering what this message means,

Re: Not able to setup source-nat for a regular router yet

2017-03-15 Thread Gabriel Beims Bräscher
Hi Jeff, Could you please provide more details (e.g. CloudStack version, CloudStack management log)? Seems that the log came from [1]. I will check on it. [1] https://github.com/apache/cloudstack/blob/master/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py Cheers, Gabriel. Em

Re: More Jira tickets clean up

2017-03-15 Thread Daan Hoogland
sorry Rafael, I haven't taken the time to look at more then a few. Go ahead, for my part On Wed, Mar 15, 2017 at 4:24 PM, Rafael Weingärtner wrote: > Folks, > It has been a week. I am assuming that no one knows about these tickets. > > In the last years, our workflow

[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

2017-03-15 Thread olivierlemasle
GitHub user olivierlemasle opened a pull request: https://github.com/apache/cloudstack/pull/2008 Fix datetime format of snapshots events Include the timezone in datetime format of snapshot events, to be consistent with every other events. "eventDateTime" was added by

Re: More Jira tickets clean up

2017-03-15 Thread Rafael Weingärtner
Folks, It has been a week. I am assuming that no one knows about these tickets. In the last years, our workflow has been improved greatly; most of the PRs I see have Jira ticket associated and everything seems to be getting better by the time; let’s not loose momentum. However, we still have some

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r106188366 --- Diff: server/src/com/cloud/alert/AlertManagerImpl.java --- @@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r106186279 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java --- @@ -512,7 +512,11 @@ public void

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r106185631 --- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java --- @@ -141,7 +142,7 @@ public void

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r106185108 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java --- @@ -100,17 +103,18 @@ public Long getInstanceId() {

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1918 Awesome! This seems a good approach to deal with the issue. @jayakarteek and @nvazquez thanks for the effort. @jayakarteek sorry for all of the stubbornness ;) You

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-03-15 Thread GabrielBrascher
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1269 Thanks for the response @anshul1886. I am sorry, but I disagree with you. I think that it gets more stable and readable with less duplicated code. In my humble opinion, it is

Re: [DISCUSS] Retirement of midonet plugin

2017-03-15 Thread Jeff Hair
Complete removal of the plugin was my solution to the problem of the jar file's dependencies. If it's not used or maintained, then it should be removed, in my opinion. Disabling it in the build is a good first step. *Jeff Hair* Technical Lead and Software Developer Tel: (+354) 415 0200

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-15 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/2003 nics in database seems ok, so it looks some issue in creating ip_associations.json --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-03-15 Thread jayakarteek
Github user jayakarteek commented on the issue: https://github.com/apache/cloudstack/pull/1918 @rafaelweingartner Tried using both cpuentitlement cpu reservedCapacity but retrieved values from vmware are zero. While going through docs , I saw

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106138864 --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java --- @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106142726 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106145072 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void

[GitHub] cloudstack issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert ...

2017-03-15 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/837 ### ACS CI BVT Run **Sumarry:** Build Number 469 Hypervisor xenserver NetworkType Advanced Passed=102 Failed=3 Skipped=7 _Link to logs Folder

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106133214 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java --- @@ -191,7 +191,8 @@ public void

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r103894706 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -1181,6 +1181,17 @@ public boolean configure(String name,

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106134695 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -194,18 +194,22 @@ protected

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-15 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106137098 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {

[GitHub] cloudstack pull request #2007: CLOUDSTACK-9834: prepareTemplate API call doe...

2017-03-15 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/2007 CLOUDSTACK-9834: prepareTemplate API call doesn't work well with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation) removed the host uuid from SR label so that any host which has

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

2017-03-15 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @ustcweizhou @sebgoa @rhtyd can you review this as a first version of an integrated plugin for application clusters. It is still very k8s specific and I want to defer making it more

Not able to setup source-nat for a regular router yet

2017-03-15 Thread Jeff Hair
Hi, I'm seeing this message in the logs when detaching IPs with disableStaticNat. This is on a network without redundant routers. What exactly dose "Not able to setup source-nat for a regular router yet" mean? Does this cause functionality problems for non-redundant routers? Jeff

[GitHub] cloudstack issue #1180: CLOUDSTACK-9112: Deploy VM failing frequently due to...

2017-03-15 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the issue: https://github.com/apache/cloudstack/pull/1180 Added test for the case where we need to list only clusters which has hosts with host tag specified in the offering. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-15 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1879 @nvazquez Thanks for testing. I'll check and update accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-03-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @karuturi ping? can this be merged as well, this greatly improves the UI performance for the existing metrics view feature as well as improves the load time of the infrastructure tab

Re: [DISCUSS] Retirement of midonet plugin

2017-03-15 Thread Rohit Yadav
+1 as others have noted Disable the plugin from the default build for next few releases and eventually deprecate/remove the plugin from the codebase. The roadmap can look something like: - Announce on the MLs that we're planning to do this, send a PR and get it accepted - During the release

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-15 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/2003 @ustcweizhou - I was able to restart the network with cleanup. New VR came up with duplicated eth2 and eth3. ![screen shot 2017-03-15 at 9 48 33

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

2017-03-15 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1726 code LGTM @yvsubhash it would be nice if you can reformat part of the code with java code conventions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-15 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/2003 @borisstoyanov moreover, can you please restart the network with cleanup, to see if the new VRs can start ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1884: CLOUDSTACK-9699: Add global setting for enabl...

2017-03-15 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1884: CLOUDSTACK-9699: Add global setting for enable/disab...

2017-03-15 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1884 Closing this based on the new PR #1944. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Reg : Edit Access

2017-03-15 Thread Rajani Karuturi
you are in. ~ Rajani http://cloudplatform.accelerite.com/ On March 14, 2017 at 7:15 PM, Pavan Kumar Aravapalli (pavankuma...@persistent.com) wrote: Hi, I am unable to edit/add pages for the cwiki link https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.9+Design+Documents. Can some one

Re: [DISCUSS] Retirement of midonet plugin

2017-03-15 Thread Daan Hoogland
Disable with a maven profile to enable? mvn –P withThisOrThat Delete but only after a time span. A number of releases is not any kind of promise in our case. On 15/03/17 04:40, "Tutkowski, Mike" wrote: Disable, then delete works for me, too. On 3/14/17,

[GitHub] cloudstack pull request #2006: CLOUDSTACK-9833: Move configuration parameter...

2017-03-15 Thread harikrishna-patnala
GitHub user harikrishna-patnala opened a pull request: https://github.com/apache/cloudstack/pull/2006 CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot Following parameters are moved from config.java to configdepot. This will make the management