Review Request 16465: fixed the listvirtualmachines API to show cpu, memory and cpucores when using custom compute offering

2013-12-26 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16465/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-5472

Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored

2013-12-26 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/ --- Review request for cloudstack and Min Chen. Bugs: CLOUDSTACK-5530

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30864 --- Commit d825b3dd141c76c0af8d02bac2147378a3506e96 in branch

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30865 --- Ship it! Ship It! - Jayapal Reddy On Dec. 24, 2013, 9:20 a.m.,

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30866 --- Commit ab4f095c68d4a4b4fb354b3d95096b193706987d in branch

Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state

2013-12-26 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5638

Re: Regarding contribution to CloudStack project

2013-12-26 Thread Wido den Hollander
Hi Abhinav! On 12/23/2013 05:27 PM, Abhinav Koppula wrote: Hi all, I am Abhinav Koppula, a senior undergraduate student pursuing my Bachelors in India. I am interested in contributing towards the Apache CloudStack project. I would be really glad if anyone could guide me on how I can get

Re: Regarding contribution to CloudStack project

2013-12-26 Thread Mike Tutkowski
There is this book on Amazon (I read it when I started working on CloudStack, but - as Wido says - CloudStack development moves fast, so not all details in this book are still accurate, but the high-level areas generally still apply):

Fwd: KVM - LibvirtDomainXMLParser did not support interface type='direct'

2013-12-26 Thread Howie
HI All In this document https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+Cloudstack, CloudStack should support direct mode. Direct Networking Libvirt supports direct attachmenthttp://libvirt.org/formatdomain.html#elementsNICSDirectof the guest VM's network to a physical

KVM - LibvirtDomainXMLParser did not support interface type='direct'

2013-12-26 Thread Howie
HI In this document https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+Cloudstack, CloudStack should support direct mode. Direct Networking Libvirt supports direct attachmenthttp://libvirt.org/formatdomain.html#elementsNICSDirectof the guest VM's network to a physical

Re: Issue in accessing Windows and Linux VM

2013-12-26 Thread jitendra shelar
Thanks Sanjeev,Kirk,Frankie, Daan. @Sanjeev, I have deployed VMs in isolated network. I will try with it. Regards, Jitendra On Thu, Dec 26, 2013 at 5:20 AM, Sanjeev Neelarapu sanjeev.neelar...@citrix.com wrote: Hi Jitendra, If you have deployed vms in an isolated networks , acquire one

Re: Regarding contribution to CloudStack project

2013-12-26 Thread jitendra shelar
Hi Abhinav, Nice that you have taken interest in cloudstack. It is really excellent. Free ebook is available at below link. http://it-ebooks.info/book/2930/ Thanks, Jitendra On Thu, Dec 26, 2013 at 5:33 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: There is this book on Amazon (I

Re: [ACS43] Schedule Reminder : 4 weeks to RC

2013-12-26 Thread Marcus Sorensen
Vlan id is required when add ip range to the public network, does anyone know when that was decided? It used to be that you could just create a public bridge and go with it (vlan = 'untagged'), now cloudstack requires a tagged vlan? On Thu, Dec 19, 2013 at 6:44 PM, Animesh Chaturvedi

Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored

2013-12-26 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30880 --- Ship it! Ship It! - Min Chen On Dec. 26, 2013, 10:09 a.m.,

Re: [ACS43] Schedule Reminder : 4 weeks to RC

2013-12-26 Thread Marcus Sorensen
Looks like it goes to aaf3979c on the 20th, I'll follow up there. It breaks my test suite, and probably how many others are used to deploying. CLOUDSTACK-5502: interpret vlan='untagged' as vlan == null On Thu, Dec 26, 2013 at 12:32 PM, Marcus Sorensen shadow...@gmail.com wrote: Vlan id is

Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30881 --- Commit 69fb1d4ed04156b61ca7993516d6ca02e72d45a2 in branch

Re: Review Request 16293: CLOUDSTACK-5264: Xenserver - Full Snapshots are not being created even after snapshot.delta.max is exceeded

2013-12-26 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16293/#review30882 --- Edison has fixed this bug, so this patch is not needed. - Min Chen

Re: Review Request 16466: CLOUDSTACK-5530 attempt to add secondary storage with the same name is ignored

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16466/#review30887 --- Commit fead6706ff25f42b6185aa2c41856778f639cc76 in branch

custom_parameters in deployVm call

2013-12-26 Thread Alena Prokharchyk
Bharat, I’ve noticed that you’ve added a new parameter to deployVm API -“customparameters”. The description of the parameter is very vague and generic “used to specify the custom parameters”. Is it just the metadata in form of value/key pairs? If so, please change the name to “details” - the

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread Marcus Sorensen
Could this be causing CLOUDSTACK-5652? I just see that it touches the isNetworkAWithinNetworkB, which now seems to return true for everything I try when deploying two networks in a vpc. On Thu, Dec 26, 2013 at 4:51 AM, ASF Subversion and Git Services asf...@urd.zones.apache.org wrote:

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread Marcus Sorensen
Yes, I verified that reverting the change on my local copy fixed the issue. On Thu, Dec 26, 2013 at 2:55 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: This is definitely the cause of the regression. Sateesh/Jaypal, please revert your change. It doesn¹t do the correct cidd

Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30900 --- Commit ec8610f7566b74ea36399db020007fb878d013eb in branch

Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30902 --- Commit 53f0d35517ff717950120d2cb4206d50fbed13de in branch

Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state

2013-12-26 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30901 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On

Re: custom_parameters in deployVm call

2013-12-26 Thread Bharat Kumar
Hi Alena, please find by comments inline. On 27-Dec-2013, at 2:40 am, Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com wrote: Bharat, I’ve noticed that you’ve added a new parameter to deployVm API -“customparameters”. The description of the parameter is very

Re: why we delete prmary storage pool every time when stopping vm?

2013-12-26 Thread Marcus Sorensen
Yes, this should be a noop for LibvirtStorageAdaptor. I'm not sure why we decided to delete the pool. On Thu, Dec 19, 2013 at 6:05 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I updated the CRs and assigned them to Marcus. Since the issues are not related to the new iSCSI code

Re: why we delete prmary storage pool every time when stopping vm?

2013-12-26 Thread Marcus Sorensen
My notes from the initial version of the patch with instructions read: LibvirtStorageAdaptor: need to implement dummy connectPhysicalDisk/disconnectPhysicalDisk I must have missed during review that the final implementation actually did something. On Thu, Dec 26, 2013 at 10:47 PM, Marcus

Re: why we delete prmary storage pool every time when stopping vm?

2013-12-26 Thread Marcus Sorensen
Actually, I see why now. This code that deletes storage pool used to be in LibvirtComputingResource.java, named cleanupDisk. It was only ever called for isos, because we only had Libvirt Storage. Now, cleanupDisk is called for everything, so that other storage adaptors can do their cleanup, but

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30903 --- Commit 0478aee78fe481e81eb4820cf181e4beb42ae22a in branch

Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-12-26 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14124/#review30904 --- Commit 07de75191c487de980be795b202b0a8d8bbda4d6 in branch

VMware Question

2013-12-26 Thread Mike Tutkowski
Hi, I have a question about the initializeLocalStorage method in VmwareResource. When an ISO is downloaded from secondary storage to an ESX host, we create an NFS datastore on the host. When the host connects to a management server, initializeLocalStorage is run and this method sees the new NFS

Re: VMware Question

2013-12-26 Thread Mike Tutkowski
I can see the problem is in HostMO.getLocalDatastoreOnHost. My datastore (as well as the NFS datastore that was automatically created to download an ISO) shows up as DatastoreSummary.isMultipleHostAccess == false (along with a couple other fields) and this qualifies it as local storage. I