Re: New Defects reported by Coverity Scan for cloudstack

2014-07-30 Thread Hugo Trippaers
Hey Ritu, Thanks! Could you post the patch as a separate review? That way it will be a lot easier for me to merge the changes. The easiest way to do it is to base the new patch on the current state of the master branch. Cheers, Hugo On 29 jul. 2014, at 22:32, Ritu Sabharwal

Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-07-30 Thread Vetrivel Chinnasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/ --- Review request for cloudstack. Repository: cloudstack-git Description

Re:Re: Re: Use OVSTunnelxxx but not cloudbr1 result exception

2014-07-30 Thread Michael Li
Hi Nguyen, Thanks for your reply. Did u mean when I create a gre network offering use ovs as service provider for connectity, and then create a guest isolated network use this offering, at this point a OvsTunnel bridge will be created ? Regards At 2014-07-25 10:17:08, Nguyen Anh Tu

Re: building cloudstack

2014-07-30 Thread Daan Hoogland
did you run $ git pull $ mvn clean test install before that? if so you could try thowing away your ~/.m2/repositories dir. On Wed, Jul 30, 2014 at 1:50 AM, Elapavuluri, Jaya jaya.elapavul...@netapp.com wrote: So this is the screen shot of the error I am getting. This was after trying to

Re: [DISCUSS] git commit proces

2014-07-30 Thread Sebastien Goasguen
On Jul 29, 2014, at 8:40 PM, Sheng Yang sh...@yasker.org wrote: And talking about to achieve good code quality, I think compulsive review and testing through some kind of automation system is much more helpful. --Sheng This new git workflow is not directly about good code quality, as a

Re: [DISCUSS] git commit proces

2014-07-30 Thread Leo Simons
On Jul 30, 2014, at 1:14 AM, Sheng Yang sh...@yasker.org wrote: The issue with current development process? 1. Cherry-pick is needed for RM to choose stable fix commit after code freeze to enforce quality. 2. Bug fix to current release branch need to be checked in both release branch and

Re: Re: Re: Use OVSTunnelxxx but not cloudbr1 result exception

2014-07-30 Thread Nguyen Anh Tu
Hi, It will be created when you run the first VM on that guest isolated network. Thanks, --Tuna On Wed, Jul 30, 2014 at 2:21 PM, Michael Li cloudcomp...@163.com wrote: Hi Nguyen, Thanks for your reply. Did u mean when I create a gre network offering use ovs as service provider for

Re: Review Request 23805: Added state parameter to the listPublicIpAddresses API call

2014-07-30 Thread Ilia Shakitko
On July 29, 2014, 10:20 a.m., Rohit Yadav wrote: Looks fine, we still need to test it before we land it on master. I unfortunately don't have my hardware (and some parts) setup will try with DevCloud or hope someone else would review, test and ship it :) Maybe we can add a reviewer who

Re: [ACS44][BUG] SystemVM not working on 4.4

2014-07-30 Thread Andrei Mikhailovsky
Hello guys, I am planning to upgrade my ACS from version 4.2.1 to version 4.4 this weekend. Following the last disastrous upgrade from 4.2.1 to 4.3.0, which also related to the system vm issues, I would like to verify the required steps to have a _working_ ACS following upgrade to 4.4?

Re: Marvin Package?

2014-07-30 Thread Rohit Yadav
Santhosh Edukulla wrote: please add me as well. username santhoshe Done. Regards. Santhosh From: Rohit Yadav [rohit.ya...@shapeblue.com] Sent: Tuesday, July 29, 2014 5:28 PM To: dev@cloudstack.apache.org Subject: Re: Marvin Package? Ian Duffy

Re: [ACS44][BUG] SystemVM not working on 4.4

2014-07-30 Thread Erik Weber
This is work in progress for a guide to fixing broken system vm's, but please note that this currently has seen limited testing yet, so take any precautions you can. https://gist.github.com/terbolous/102ae8edd1cda192561c The best thing you can do before upgrading is to download the new system vm

Re: building cloudstack

2014-07-30 Thread Rohit Yadav
Hi Jaya, The database upgrade path issue was fixed. This looks like mvn/dependency error. Just git pull the latest on 4.4 branch and do a mvn clean install. If problem persists, remove ~/.m2 and start over. Regards. Elapavuluri, Jaya wrote: So this is the screen shot of the error I am

Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
I believe for every check-in we decided to run sanity tests on simulator atleast, currently build for simulator is failing. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile

RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
The simulator code should be kept up to date with any changes done in the core product. If there are any interface changes, necessary changes should be made in simulator plugin as well along with other hypervisor plugins. To build simulator code use refer to [1]. -Koushik [1]

Re: Review Request 21554: CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21554/#review49093 --- Commit a40f2315fdc761309107cc5c88fbd44932edf7e3 in cloudstack's

Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21858/#review49095 --- Commit 34f3a5fd44cd7af9f53f628b71f48d854d498eff in cloudstack's

Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20621/#review49094 --- Commit 25a78acee127e7b195e4508bd8c1740d9fe227ed in cloudstack's

Build failed in Jenkins: cloudstack-4.4-maven-build #404

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/404/changes Changes: [Daan Hoogland] Fixing issues in regression test suite test_accounts.py [Daan Hoogland] Fix for Marvin utils.py:checkVolumeSize Fix for test_01_create_volume to use the correct volume name for XenServer

RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
I just logged a bug for the same. https://issues.apache.org/jira/browse/CLOUDSTACK-7204 Santhosh From: Santhosh Edukulla Sent: Wednesday, July 30, 2014 5:56 AM To: dev@cloudstack.apache.org Cc: Anthony Xu Subject: Simulator on master is not building I

Build failed in Jenkins: cloudstack-4.4-maven-build #405

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/405/changes Changes: [Daan Hoogland] CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name [Daan Hoogland] CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract

Build failed in Jenkins: cloudstack-4.4-maven-build #406

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/406/changes Changes: [Daan Hoogland] try-with-resource to prevent resource leaks [Daan Hoogland] Fixed issues reported by coverity NPEs, unwritten field access and self assignment [Daan Hoogland] Fix for test_01_create_volume

Re: Review Request 22256: CLOUDSTACK-6830 :[hyper-v] fixed vm migration failing between different clusters if volumes are on zone wide primary store

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22256/#review49098 --- Commit 8b9166ae0bf437f35bf51dfb8dcfda3e4835a8ee in cloudstack's

Jenkins build is back to normal : cloudstack-4.4-maven-build #407

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/cloudstack-4.4-maven-build/407/changes

Review Request 24096: CLOUDSTACK-7205: Passing expunge=True while deleting VMs to speed up test case execution

2014-07-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24096/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7205

Re: 4.4-forward picked empty

2014-07-30 Thread Rajani Karuturi
Hi Daan, commit 2ab7bcade2f37cb17e071a6154fdae1d80e4ff99 Author: Rajani Karuturi rajanikarut...@gmail.commailto:rajanikarut...@gmail.com Date: Fri May 23 15:50:06 2014 +0530 Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range This is same as

Re: Review Request 24098: CLOUDSTACK-6873: Removing BugId from test cases to enable them

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24098/#review49101 --- Commit e1be035870d6b40285166e0ae0633e39509662c0 in cloudstack's

OVS with VLANS: migration impossible

2014-07-30 Thread Claus Kalle
Hi, I am testing a setup where OVS is in use with VLANs as separation between isolated networks for guests. Whene I try to migrate such a guest from one host to another (both share the same VLAN set by the same trunk=.. list) I get the message: Unable to migrate due to Unable to add port vnet0 to

Review Request 24102: Fixing missing attribute issue in test_stopped_vm.py

2014-07-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24102/ --- Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git

Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

2014-07-30 Thread Daniel Vega Simões
Hi guys, Since nobody was opposed to the approach suggested in the last e-mail, we went on and implemented the global option that authorizes the plugin to override record entries when they already exist in the DNS server. We also updated the name to GloboDNS and the functional spec to reflect

Review Request 24103: Fixed test_escalations_instances.py - Stop VM before detaching root volumes

2014-07-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24103/ --- Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git

Re: multiple primary storage

2014-07-30 Thread Mike Tutkowski
Clustered LVM is a set of clustering extensions to LVM. This allows a set of compute nodes (in this case, XenServer hosts) to manage shared storage using LVM. LVM: http://en.wikipedia.org/wiki/Logical_Volume_Manager_(Linux) If you create a volume on a SAN that's accessible via iSCSI and create

Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

2014-07-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24104/ --- Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git

Re: 4.4-forward usage

2014-07-30 Thread Rohit Yadav
Hi Daan, On 24-Jul-2014, at 6:20 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: People (especially test developers), please stop using 4.4-forward and switch to 4.4 If we do a code freeze for 4.4.1 make a new branch per fix, the model of a -forward branch is fundamentally broken and has

Re: Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

2014-07-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24104/ --- (Updated July 30, 2014, 9:28 p.m.) Review request for cloudstack and Girish

Re: 4.4-forward usage

2014-07-30 Thread Daan Hoogland
Well Rohit, I was thinking we should not use 4.4-forward anymore at all (or create a new one) Merging back from it at the moment costs to much conflicts. I'd say we work on branches taken from 4.4 on a per fix basis and merge those that are proven. makes sense? On Wed, Jul 30, 2014 at 5:37 PM,

Re: Review Request 24096: CLOUDSTACK-7205: Passing expunge=True while deleting VMs to speed up test case execution

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24096/#review49113 --- Commit 42a861e5908b110bbb41145b09394bd86ef318e1 in cloudstack's

Re: 4.4-forward usage

2014-07-30 Thread Rohit Yadav
On 30-Jul-2014, at 6:11 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Well Rohit, I was thinking we should not use 4.4-forward anymore at all (or create a new one) Merging back from it at the moment costs to much conflicts. I'd say we work on branches taken from 4.4 on a per fix basis

Build failed in Jenkins: build-master-noredist #3191

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/3191/ -- [...truncated 1799 lines...] log4j:WARN No appenders could be found for logger (com.cloud.event.EventControlsUnitTest). log4j:WARN Please initialize the log4j system properly. log4j:WARN

RE: building cloudstack

2014-07-30 Thread Elapavuluri, Jaya
I am getting the same error after throwing away the .m2 folder. It complains about resolving the dependencies for 4.4.1. Is there any other way I could go back? -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, July 30, 2014 3:28 AM To: dev

RE: Simulator on master is not building

2014-07-30 Thread Anthony Xu
We used -Dsimulator to include simulator, it is very easy for developers to forget it. Simulator should be built by default , we may use -Dnosimulator to exclude simulator. Anthony -Original Message- From: Koushik Das Sent: Wednesday, July 30, 2014 3:03 AM To:

RE: Simulator on master is not building

2014-07-30 Thread Edison Su
+1, include simulator in the default build, exclude explicitly in the production build. -Original Message- From: Anthony Xu [mailto:xuefei...@citrix.com] Sent: Wednesday, July 30, 2014 10:28 AM To: Koushik Das; dev@cloudstack.apache.org Subject: RE: Simulator on master is not

Jenkins build is back to normal : build-master-noredist #3192

2014-07-30 Thread jenkins
See http://jenkins.buildacloud.org/job/build-master-noredist/3192/changes

RE: Simulator on master is not building

2014-07-30 Thread Anthony Xu
Hi Koushik, fixed the build for simulator. I just found out Simulator use its own VOes for some VOes, it may not be easy for developer to add feature for simulator if the feature needs to change VO, for example, the new VMsync logic, I don't think simulator test the new VMsync logic. If we

Re: 4.4-forward usage

2014-07-30 Thread Mike Tutkowski
My understanding is that the -forward concept goes away after 4.4.1. On Wednesday, July 30, 2014, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 30-Jul-2014, at 6:11 pm, Daan Hoogland daan.hoogl...@gmail.com javascript:; wrote: Well Rohit, I was thinking we should not use 4.4-forward

[acs44] systemvm64template-4.4.0-6-{xenserver|kvm}: update

2014-07-30 Thread Pierre-Luc Dion
Daan, We made few tests with version 6 of 4.4.0 system vms for xenserver and kvm. So far so good! fresh install of 4.4 with those templates work fine so far, not issues as earlier this week. So, the install doc is updated to use those templates. I'm validating the upgrade path from 4.2.1 then

Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/ --- Review request for cloudstack and Hugo Trippaers. Bugs: CLOUDSTACK-6823

RE: New Defects reported by Coverity Scan for cloudstack

2014-07-30 Thread Ritu Sabharwal
Hi Hugo, I have created a separate review request based on current master. The review request is: https://reviews.apache.org/r/24111/ Thanks Regards, Ritu S. From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, July 29, 2014 11:09 PM To: Ritu Sabharwal Cc:

Re: 4.4-forward usage

2014-07-30 Thread Sebastien Goasguen
On Jul 30, 2014, at 2:38 PM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: My understanding is that the -forward concept goes away after 4.4.1. yes +1 instead of asking for a cherry-pick from -forward, folks should ask the RM to merge from their cloudstack-WXYZ branch and merge it

Re: 4.4-forward usage

2014-07-30 Thread Daan Hoogland
On Wed, Jul 30, 2014 at 10:15 PM, Sebastien Goasguen run...@gmail.com wrote: and merge it in other needed branches (master and develop) that part will be hard as it will merge all commits (also hotfixes and others) that aren't on the the ancestry of the branch to merge into. So this is only

Re: building cloudstack

2014-07-30 Thread Daan Hoogland
Jaya, You can go back to any commit id you want. I don't think you'll find much going backwards but it is nice trouble shooting the code. In your case my thoughts go to the build environment as you fail to build versions that others have build successfully. best do a git pull and try mvn clean

Re: 4.4-forward usage

2014-07-30 Thread David Nalley
On Wed, Jul 30, 2014 at 4:26 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: On Wed, Jul 30, 2014 at 10:15 PM, Sebastien Goasguen run...@gmail.com wrote: and merge it in other needed branches (master and develop) that part will be hard as it will merge all commits (also hotfixes and

Re: [DISCUSS] git commit proces

2014-07-30 Thread Sheng Yang
On Wed, Jul 30, 2014 at 12:37 AM, Sebastien Goasguen run...@gmail.com wrote: On Jul 29, 2014, at 8:40 PM, Sheng Yang sh...@yasker.org wrote: And talking about to achieve good code quality, I think compulsive review and testing through some kind of automation system is much more helpful.

Re: 4.4-forward picked empty

2014-07-30 Thread Min Chen
Daan, That commit is already there in 4.4 branch. See https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=6ba541a fb73475758a62a17dae1ec1be088da810. Thanks -min On 7/30/14 5:33 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: thanks Rajani On Wed,

Re: [DISCUSS] git commit proces

2014-07-30 Thread Sheng Yang
On Wed, Jul 30, 2014 at 1:21 AM, Leo Simons lsim...@schubergphilis.com wrote: On Jul 30, 2014, at 1:14 AM, Sheng Yang sh...@yasker.org wrote: The issue with current development process? 1. Cherry-pick is needed for RM to choose stable fix commit after code freeze to enforce quality. 2.

Re: Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs

2014-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24050/#review49193 --- Commit b919da8a5c54ec0f7d0c370203ccfb058cbe1a54 in cloudstack's

RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
If we build simulator by default, it may add to the build time, and there is a potential people forgetting to exclude some times. Santhosh From: Anthony Xu [xuefei...@citrix.com] Sent: Wednesday, July 30, 2014 1:27 PM To: Koushik Das;

Re: [DISCUSS] git commit proces

2014-07-30 Thread Rajani Karuturi
4. Then, conflict would happen when you merge release/4.4. branch to release/4.5. Since the version number changed to 4.4.1. You need to deal with version number conflict every time when merge to upper release. one empty merge with git merge -s ours after the version change and git would not

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49200 ---

[Summary] checkin process

2014-07-30 Thread Rajani Karuturi
For the git flow: 1. We agreed to follow git-flow explained here http://nvie.com/posts/a-successful-git-branching-model/ 2. This is the proposal for first cut 2a. rename 'master' to 'develop’ 2b. branch a new 'master' from ‘4.4’ and update tags with release/4.4.0 2c. branch ‘release/4.5' from the

RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
Simulator can be included in the default build but it needs to be tested whether simulator plugin can coexist with actual HV plugins in the same MS without any issues. Right now there is an issue which prevents it, refer to https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is

RE: Simulator on master is not building

2014-07-30 Thread Koushik Das
There is a separate simulator DB where all these VOs are used. These are only used in the 'Simulator' resource layer and are not part of core CS logic. Also I have written a sample test for new vmsync (test/integration/smoke/test_vm_sync.py). Please check it out and let me know if there are

RE: Simulator on master is not building

2014-07-30 Thread Santhosh Edukulla
AS well, the way we build simulator for deploying its db is different , all packaging scripts needs to be changed and a potential testing involved . Santhosh From: Santhosh Edukulla Sent: Thursday, July 31, 2014 12:05 AM To: dev@cloudstack.apache.org;