Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/587#issuecomment-121827701
LGTM, though did not test it due to lack of time and test infrastructure.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/189#issuecomment-121830729
Patch fails, file already exists? Please rebase and push again, or close PR
if this is already merged on master in some other PR
---
If your project is set up for
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/386#issuecomment-121829533
LGTM, really old so merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r34755962
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -124,6 +127,9 @@
description = true
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/189#issuecomment-121830270
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-121829695
ping, any update on this? still WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121829664
LGTM, squashing and merging; please squash your changes in future as you
iterate on your PR
---
If your project is set up for it, you can reply to this email and
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/577#discussion_r34755687
--- Diff: packaging/centos63/cloud.spec ---
@@ -129,6 +129,8 @@ Requires: perl
Requires: libvirt-python
Requires: qemu-img
Requires:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-121829053
While LGTM and travis seems to be happy about it, my java kung - {locks and
synchroization} -fu skills are not to be trusted
---
If your project is set up for it,
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/580#discussion_r34755639
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtFenceCommandWrapper.java
---
@@ -48,6 +48,18 @@ public Answer
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/579#issuecomment-121828476
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/384#issuecomment-121829822
Ping, any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/532#issuecomment-121829768
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/584
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121522610
thanks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
LGTM
On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 g...@git.apache.org wrote:
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34656988
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py
Github user pvr9712 commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121559068
I have tested this changes and it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/594
CLOUDSTACK-8637: Verify that VM with same Display name creation fails if
vm.instancename.flag=true
When vm.instancename.flag=true it will only set the instancename without
any additional
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121563084
@pvr9712 the question here is not if it works or not, because it's quite
clear that once the permission changes it will suffice @sanju1010's need. The
point
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-121528428
@bhaisaab this PR didn't auto close. You think your ref from
shapeblue/cloudstack to here might have anything to do with it?
---
If your project is set up for
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/593
CLOUDSTACK-8580
Users are now able to view, expunge and recover their vm's themselves. Two
configuration options are added to allow this behaviour on a global or per
account scale.
Hi,
I totally agree with Wido, This should be fixed in the ACS repo for every one
to use, Instead of sharing this using non ACS private builds.
Thanks,
Bharat.
On 15-Jul-2015, at 2:41 pm, Rohit Yadav
rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com wrote:
On 14-Jul-2015, at 9:23
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/590#discussion_r34650668
--- Diff: test/integration/testpaths/testpath_revert_snap.py ---
@@ -0,0 +1,159 @@
+# Licensed to the Apache Software Foundation (ASF) under one
A directory rename? If you create a patch file of your branch and
apply it on HEAD, does that work?
On Wed, Jul 15, 2015 at 3:03 AM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Hi everyone,
I have a Git question that relates to a rebase problem I've been seeing.
I have a branch I've
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/590#issuecomment-121510634
Hi @pritisarap12
The issue/PR title says Unable to rever snapshot on XenServer, however
you have created a component test to check that volume
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/588#issuecomment-121510209
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121511254
@bhaisaab @DaanHoogland @remibergsma could you have a look at this?
Wasn't ACS management-server supposed to be executed as SUDO? If I'm right,
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/592
CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with
disksize parameter
Custom disk creation should not take disksize parameter while creating the
disk offering
You
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34650908
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121511374
This description looks better, @pritisarap12 . I think you meant something
like that for your previous PR.
I will wait for the build/travis and vote
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121512748
@wilderrodrigues currently I am on holiday and not able to look into stuff.
As far as I know sudo was implemented for KVM agent only.
See ya in about
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/591
CLOUDSTACK-8633: Changing file permissions from 755 to 440
With 0755 permissions on /etc/sudoers.d/cloudstack-management we are
getting following error in bringing up CS:
Failed to start
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121512071
Hi @wido
Could you please add an extra test to cover the pools.size() == 0)?
Cheers,
Wilder
---
If your project is set up for it, you
If there would be dependencies on some other things, that in no way could be
fixed now, we could wait for 4.7 (5.0). However, if we could give it a go, I
would be able to tackle this in our next Sprint (within 1 1/2 week from now)
and still get it into 4.6.
What would be the main
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121600559
Added description to title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121602397
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pvr9712 commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121566177
@wilderrodrigues if you look at the earlier commit, the code was refactored
and I feel it is a miss. If this worked for someone, will be interested to
know.
LGTM
On Wed, Jul 15, 2015 at 3:29 PM, pritisarap12 g...@git.apache.org wrote:
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/594
CLOUDSTACK-8637: Verify that VM with same Display name creation fails
if vm.instancename.flag=true
When
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121573911
Hi @pvr9712
Thanks for the commit IDs, a bit of context always help.
It would have saved us some time if the PR would have the commit ID
I was trying to bring up MS with xencluster.
On Wed, Jul 15, 2015 at 4:10 PM, pvr9712 g...@git.apache.org wrote:
Github user pvr9712 commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121571026
BTW, here is my email on the Dev list with the
Github user pvr9712 commented on the pull request:
https://github.com/apache/cloudstack/pull/591#issuecomment-121571026
BTW, here is my email on the Dev list with the details for this issues -
including the earlier commit - Using Master builds, MS logs shows following
error -
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/588#issuecomment-121603988
@wido do we need to port them on 4.5 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
awesome!
agree on the context... thanks!
-Original Message-
From: wilderrodrigues [mailto:g...@git.apache.org]
Sent: Wednesday, July 15, 2015 4:18 PM
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file
permission...
Github user
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121585809
Can you add the description of the functionality is short to the pr title?
for instance 'CLOUDSTACK-8580: user access to deleted VMs'
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/589
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 15-07-15 09:20, Wilder Rodrigues wrote:
If there would be dependencies on some other things, that in no way
could be fixed now, we could wait for 4.7 (5.0). However, if we
could give it a go, I would be able to tackle this in our next
Sprint
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/594#issuecomment-121601522
looks like this is for vmware only
no way for me to verify, but good looks okay.
LGTM, merging now
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/583#issuecomment-121606896
LGTM from Abhi (on chat); test setup on http://acs.bhaisaab.org:8080/client/
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/595
CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_domaâ¦
test result
=
Test secondary storage limit of domain and its sub-domains ... ===
TestName:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/582#discussion_r34674108
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
return
Hi,
I'm trying to run a test based on this guide:
http://www.chipchilders.com/blog/2013/7/22/visualizing-the-cloudstack-planners-in-action.html
the test code:
https://gist.github.com/chipchilders/6056220#file-test_deploy_lots_of_vms_with_firstfitplanner-py
I've done some minor changes to make it
See http://jenkins.buildacloud.org/job/build-4.5/499/changes
Changes:
[Rohit Yadav] CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form
--
[...truncated 2974 lines...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2
64 matches
Mail list logo
