[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread kmccormick
Github user kmccormick commented on the pull request: https://github.com/apache/cloudstack/pull/766#issuecomment-136810812 OK, reworked this a bit. Removed dom0ram and using only _dom0MinMem now. This line should cause a 1GB default if the value isn't specified in the file:

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-09-01 Thread sebgoa
On Sep 1, 2015, at 9:17 AM, Rajani Karuturi wrote: > Where did you give cloudstack apikey and secret? > Did you give AWS keys both at AWS configure and ec2-register? yes you need to do both… $ aws configure ….> give your keys $ ec2stack-register ….> give your keys

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38392031 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + *

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38391829 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + *

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-09-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136599746 @rafaelweingartner I see windows line endings in the new test file. Can you fix that please? Other than that, LGTM. once thats fixed I will merge --- If your

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-09-01 Thread Rajani Karuturi
Where did you give cloudstack apikey and secret? Did you give AWS keys both at AWS configure and ec2-register? ~Rajani On 01-Sep-2015, at 10:16 am, Rohit Yadav > wrote: On 28-Aug-2015, at 4:34 pm, Rajani Karuturi

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38392290 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136601269 @karuturi @bhaisaab @DaanHoogland @koushik-das Anyone with some time to have a look at this PR? Thanks in advance. Cheers,

[GitHub] cloudstack-www pull request: update download URL

2015-09-01 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136609778 @terbolous yes, there was a DDOS against ASF servers and the PMC was informed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack-www pull request: update download URL

2015-09-01 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136613436 @runseb Ok, no worries then :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack-www pull request: update download URL

2015-09-01 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136596035 Looks good to me, but have we been informed of this change from infra? Did a search for closer.cgi and closer.lua in my mailbox, and the only reference I found

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38392508 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/766#issuecomment-136922701 LGTM, in case my previous comment is not already interpreted as such. --- If your project is set up for it, you can reply to this email and have your reply

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-09-01 Thread Mike Tutkowski
At several of the companies where I've worked before, we would hold "bug court" a couple times per week as the release marched on. Representatives from different areas (product marketing, sales, support, engineering, etc.) would attend and we'd go through all issues opened since the previous bug

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136877843 Rohit - I just submitted https://github.com/apache/cloudstack/pull/771/files for the support of live migration on older versions of Libvirt in CS 4.5.

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/771 Support live migration on older version of Libvirt https://issues.apache.org/jira/browse/CLOUDSTACK-8792 A flag being passed to Libvirt assumes v1.0.0 or later. We need

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136620086 @wilderrodrigues I'm now testing your PR, but I have a question: how is SSHing into the VMs testing the default policy is set to DROP? --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/766#issuecomment-136632587 except for the initialisation issue, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/754#issuecomment-136640381 When I build the entire project mvn always gets stuck running unit tests of some project (not always the same). I don't want to keep digging any further

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-09-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136640347 since this fixes slow build, I am going to merge this PR and push another commit for line endings fix. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/765#discussion_r38396363 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -414,7 +426,7 @@ def fw_router(self): self.fw.append(['',

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38401570 --- Diff: setup/db/db/schema-452to460.sql --- @@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` ( CONSTRAINT

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136621356 SSH doesn't test it... I just did to make sure all works as before. To check the policies to iptables -L --verbose (you will see DROP for INPUT and

Build failed in Jenkins: build-master-slowbuild #2199

2015-09-01 Thread jenkins
See -- [...truncated 28153 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38396925 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + *

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38397250 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -189,6 +194,21 @@ public LdapUser getUser(final

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38397611 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38399204 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38399252 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/766#discussion_r38394939 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -258,7 +258,7 @@

Re: [VOTE] Release Apache CloudStack EC2stack 0.8.0

2015-09-01 Thread Rajani Karuturi
ok. I have done that. This is what I see in cloudstack logs 2015-09-01 12:13:10,537 DEBUG [c.c.a.ApiServlet] (255545312@qtp-2099531272-5:ctx-475b47b7) ===START=== 10.147.28.40 -- GET apikey=AWS_API_KEY=listTemplates=true=json=executable=wydwgfo%2BbwkLcU8DwONqu6CVFm4%3D 2015-09-01 12:13:10,544

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/753#issuecomment-136662511 @miguelaferreira thanks :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/765#discussion_r38404211 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -414,7 +426,7 @@ def fw_router(self):

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/760#issuecomment-136673890 Anyone? @kishankavala @bhaisaab @remibergsma @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136621918 ok, that's what I thought. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

2015-09-01 Thread Daan Hoogland
There is something like this on the page by Remi on the new release procedure. It is one of the lesser things about it. I think we should only look at stability. The discussion on what is minor or major is not something we want to need to have. On Tue, Sep 1, 2015 at 3:48 AM, Mike Tutkowski

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/767#discussion_r38395369 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -1273,10 +1274,20 @@ public void

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38396821 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java --- @@ -0,0 +1,114 @@ +/* + *

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38396794 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -243,4 +263,22 @@ public boolean isLdapEnabled()

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38397144 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public LdapAuthenticator(final

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/753#issuecomment-136641962 @bhaisaab I'm testing this one now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38399524 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136664670 Hi @miguelaferreira Okay for the Marvin test, but then it will make the thing wait for another day, at least. Which is fine, but I hope people LGTM

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

2015-09-01 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-136620633 @wilderrodrigues, @DaanHoogland, I removed the field since it's not used at all in the code. No matter what you select in that dropdown, the value will be

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136625019 @wilderrodrigues wouldn't it be better to have a Marvin test that check the policy? Now that I think of it, also a Python unit-test? --- If your

[EVENT] CCC Dublin Oct 8-9

2015-09-01 Thread sebgoa
CloudStack collab Dublin Oct 8-9 is coming up fast, http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe Register for this exciting event. See you all there, Cheers, -Sebastien

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/754#issuecomment-136635121 @bhaisaab I've created a totally new test environment, checked out your PR and started building it. I'm already past the point where it was failing before,

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38399931 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38400365 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2196,6 +2193,11 @@ private UserAccount getUserAccount(String username, String

[GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/753#issuecomment-136648011 Full maven build successful, with the exception of Console Proxy RDP client project that contains a flakey unit test. :+1: --- If your project is

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38396458 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136636331 changes look reasonable. have not tested, so I am going to trust @wilderrodrigues on this but @miguelaferreira his point on an automation sounds very promising

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38397126 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -189,6 +194,21 @@ public LdapUser

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38400169 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -52,21 +58,71 @@ public LdapAuthenticator(final

[GitHub] cloudstack pull request: Quota master

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136660371 New PR here: https://github.com/apache/cloudstack/pull/768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8688 - default policies for IN...

2015-09-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/765#issuecomment-136667361 @wilderrodrigues ok for the python unit tests, but I would really like a marvin test, or al least some way to automate setting up the environment you

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136684709 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-09-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136698602 cat -v filename will show you line endings. I figured the timezone issue. didnt want to wait for another day with broken build. hence pushed it. The recent

Multiple Nexus1000v enabled Clusters in one Zone

2015-09-01 Thread Alireza Eskandari
Hi everybody, I use CloudStack 4.5.2 with ESXi 5.5 and Nexus 1000v - I created "Cluster01" in vCenter. I added this cluster to "Nexus01" with "uplink01" port-profile. I connected this cluster to CloudStack without problem. - I created "Cluster02" in vCenter. I added this cluster to "Nexus01"

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/760#discussion_r38406769 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -383,10 +383,10 @@ public void scheduleRestart(VMInstanceVO vm, boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/766#discussion_r38409667 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -258,7 +258,7 @@ private String

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/760#issuecomment-136677170 followed the refactored logic, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Jenkins build is back to normal : build-master-slowbuild #2200

2015-09-01 Thread jenkins
See

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136686420 @mike-tutkowski I've merged this on master, cherry-pick failing on 4.5 branch; can you send a new PR for 4.5 branch? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...

2015-09-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/755#discussion_r38410923 --- Diff: setup/db/db/schema-452to460.sql --- @@ -399,3 +399,14 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` ( CONSTRAINT

[GitHub] cloudstack pull request: L10n update master from Transifex 2015090...

2015-09-01 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/769 L10n update master from Transifex 20150901 Update L10N resource files on master branch with 4.6 translation strings from Transifex (20150901) Fix an issue with the key

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-09-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136681350 @remibergsma I merged the PR following the new merge style you and @miguelaferreira did. I dunno why it's still not updated. Let's wait a bit more.

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/760#issuecomment-136696233 2 LGTMs merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-09-01 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136702586 With your comments, I fixed my Eclipse configuration on my Windows environment, now I am using UNIX lines for ACS on windows. On Tue, Sep 1,

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-09-01 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-136708467 No, seems good. We can merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/760#issuecomment-136675396 in terms of refactorring i like this very much. unit tests and travis pass so LGTM. I haven't done any integration testing, have you @koushik-das --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/760#issuecomment-136680502 @DaanHoogland I ran the following integration test on simulator. Other than this I don't thick there is any other test for VM HA.

Re: [EVENT] CCC Dublin Oct 8-9

2015-09-01 Thread Wido den Hollander
Yes, I'll be there! Giving a talk again :) Should be fun and interesting again! Wido On 01-09-15 10:05, sebgoa wrote: > CloudStack collab Dublin Oct 8-9 is coming up fast, > > http://events.linuxfoundation.org/events/cloudstack-collaboration-conference-europe > > Register for this exciting

[GitHub] cloudstack pull request: Proposal for an improved CglibThrowableRe...

2015-09-01 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/762#issuecomment-136686182 @Karuturi, Sorry for the windows line endings (did you see that on log files? I was not able to see anything there). Sometimes I jump between OS and

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-09-01 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-136705849 any other comment about this PR ? If no, I will merge it into master. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/767#discussion_r38414670 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -1273,10 +1274,20 @@ public

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-09-01 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/770 Update L10N resource files on 4.5 branch with 4.5 translation strings… … from Transifex (20150901) Fix an issue with the key message.admin.guide.read on pt_BR L10N in web UI

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: simulator-4.5-singlerun #270

2015-09-01 Thread jenkins
See -- Started by upstream project "build-4.5-simulator" build number 324 originally caused by: Started by upstream project "build-4.5" build number 522 originally caused by: Started by

[GitHub] cloudstack pull request: L10n update master from Transifex 2015090...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/769#issuecomment-136933730 @milamberspace LGTM, can you rebase against latest master so the PR won't include redundant commits --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/770#issuecomment-136933764 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/771#issuecomment-136933433 LGTM @mike-tutkowski thanks, since the same was merged on master; will merge this on 4.5 today --- If your project is set up for it, you can reply to this email

cloud-set-guest-password script for CentOS 7 template

2015-09-01 Thread Indra Pramana
Dear all, I am using ACS 4.2.0 with KVM hypervisor. I am trying to create a CentOS 7 template and everything is running fine except the CloudStack password reset script template. CentOS 7 is using systemd so I have created the required /usr/lib/systemd/system/cloud-set-guest-password.service as

[GitHub] cloudstack pull request: L10n update master from Transifex 2015090...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/769#issuecomment-136928701 @milamberspace I don't understand the commit sequence. why are all the other commits in this PR? They seem unrelated. --- If your project is set up for it,

Re: [GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread Mike Tutkowski
Cool...sounds good - thanks for merging. On Tue, Sep 1, 2015 at 10:16 PM, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/771#issuecomment-136933433 > > LGTM @mike-tutkowski thanks, since the same

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136940141 May be there is some issue with ACS or github. I also noticed that commits are not getting closed on merge and @hubot is marking it as merged after sometime.

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-01 Thread shwetaag
Github user shwetaag commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r38500164 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ "ostype": "CentOS 5.6 (64-bit)" }, +

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-09-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/770#issuecomment-136928840 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

2015-09-01 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-136934002 @DaanHoogland Removed the duplicate tests. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: L10n update master from Transifex 2015090...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/769 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8785: Proper enforcement of re...

2015-09-01 Thread koushik-das
Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/760 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/761#issuecomment-136939562 Anyone github bug? why is @hubot here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136939528 Something went wrong in this PR, why is @hubot here and not asfgit? The PR is still getting listed in the list of open PRs, even though it has been merged on

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

2015-09-01 Thread ustcweizhou
Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: messages: fix string in pt_BR translation...

2015-09-01 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/749#issuecomment-136713014 @bhaisaab I've send 2 PR (one for master/4.6 and one for 4.5 branch) to fix this issue (and update the L10N files) from Transifex. See #769 and #770 ---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread Mike Tutkowski
Member variables of type int or long are auto initialized to 0 in Java (as opposed to an unknown value). That being said, that might not be a good default value for this situation. On Tuesday, September 1, 2015, DaanHoogland wrote: > Github user DaanHoogland commented on a

Re: [GitHub] cloudstack pull request: Support live migration on older version o...

2015-09-01 Thread Mike Tutkowski
Sure, I can submit a follow-up PR for 4.5. On Tuesday, September 1, 2015, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/767#issuecomment-136686420 > > @mike-tutkowski I've merged this on master,

[GitHub] cloudstack pull request: CLOUDSTACK-8678: Reserve RAM for KVM host...

2015-09-01 Thread securityvoodoo
Github user securityvoodoo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/766#discussion_r38436231 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -258,7 +258,7 @@