[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

2015-09-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139855167 @bhaisaab Will do! Please wait with merging, will commit them to this PR. --- If your project is set up for it, you can reply to this email and have your reply

Build failed in Jenkins: build-master-slowbuild #2295

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

Re: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Remi Bergsma
Hi, The question is, is CentOS7 even supported on 4.5? The docs say it isn’t and when we were voting for 4.5.2 (http://markmail.org/message/36vnwh4kiilhkunu) I found some issues with CentOS 7. Regarding the KVM agent, that doesn’t work properly on 4.5 (which is now fixed on master). You can

Re: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Keerthiraja SJ
When will the 7.x rpm's will get uploaded. On Sun, Sep 13, 2015 at 6:12 AM, Pierre-Luc Dion wrote: > There is one: http://jenkins.buildacloud.org/view/build-release/ but the > job is failing, I'm still not sure if it's the jenkins slave the problem. > > > PL > > > On

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX format for ni...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139854597 @giraffeforestg Thanks. Is it an idea to add all possible systemd names to prevent more issues in the future? ``` With systemd 197 we have added

Re: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Wido den Hollander
On 09/13/2015 10:47 AM, Remi Bergsma wrote: > Hi, > > The question is, is CentOS7 even supported on 4.5? The docs say it isn’t and > when we were voting for 4.5.2 (http://markmail.org/message/36vnwh4kiilhkunu) > I found some issues with CentOS 7. Regarding the KVM agent, that doesn’t work >

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX format for ni...

2015-09-13 Thread giraffeforestg
Github user giraffeforestg closed the pull request at: https://github.com/apache/cloudstack/pull/811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX format for ni...

2015-09-13 Thread giraffeforestg
Github user giraffeforestg commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139868712 OK. I will modify the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139873749 @wido Cool, thank you! Will test tomorrow :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Remi Bergsma
Hi Wido, PR 731's patch does not apply cleanly on 4.5 due to a conflict in LibvirtComputingResource.java. It doesn't look too complicated (just one conflict), but I'd rather have one of the Java gurus look at this. I just cherry-picked the commits to a new branch (branched off of 4.5). 757

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-13 Thread giraffeforestg
GitHub user giraffeforestg opened a pull request: https://github.com/apache/cloudstack/pull/812 CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX format for ni...

2015-09-13 Thread giraffeforestg
Github user giraffeforestg commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139873507 sorry. I am not familiar. https://github.com/apache/cloudstack/pull/812 --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/813 CLOUDSTACK-8625: Systemd profile for CloudStack Agent With CentOS 7 and Ubuntu 16.04 (to be released) using systemd it is preferred that CloudStack's Agent is also being started using

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX format for ni...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139869756 @giraffeforestg Awesom! You may also leave the PR open and push more commits once done. Whatever suits you :-) --- If your project is set up for it, you can

Re: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Wido den Hollander
On 09/13/2015 01:28 PM, Remi Bergsma wrote: > Hi Wido, > > PR 731's patch does not apply cleanly on 4.5 due to a conflict in > LibvirtComputingResource.java. It doesn't look too complicated (just one > conflict), but I'd rather have one of the Java gurus look at this. I just > cherry-picked

Build failed in Jenkins: build-master-slowbuild #2297

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

Build failed in Jenkins: build-master-slowbuild #2296

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-13 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-139862762 @DaanHoogland I will write unit tests for this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

2015-09-13 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/814 CLOUDSTACK-8443: Support CentOS 7 for 4.5 This is based on two PRs: - 731 - 757 This commit is based on the 4.5 branch for a future 4.5 release. You can merge this pull request

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139874783 @giraffeforestg Thanks for picking this up! Will test it tomorrow. FYI: You can always make changes after the PR is opened. If you'd want to change

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139897498 Hey @wido.. question: I tried building the packages: `./package.sh -d centos7` Got this error: ``` Processing files:

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/810 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-139915515 @remibergsma @maneesha-p Indeed. We have the information, so why not KVM? That would cover allmost all cases. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread ashwinswaroop
Github user ashwinswaroop commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139910486 @rafaelweingartner I committed and pushed the new changes. I also changed the commit comment like you requested. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/814#issuecomment-139913862 @bhaisaab Could you look into this? If this gets a LGTM we might want to spin out 4.5.3 shortly with proper CentOS 7 support. A short e-mail to the dev@ list

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139914467 Looking at the if-statement I give it a LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Cloudstack 8816 entityuuid missing in som...

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/782#issuecomment-139915412 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Build failed in Jenkins: build-master-slowbuild #2298

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/814#issuecomment-139911602 LGTM - Built agent RPMs for CentOS 7 from this PR branch and installed those on the KVM hypervisors. Run the management server also from this branch and was

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139913021 Now the change seems ok. I would just suggest you to squash the two commits, and fix the commit message (the first line of the comment is used to

Systemd support for CloudStack 4.6

2015-09-13 Thread Wido den Hollander
Hi, Today I've spent some time in writing a systemd service file for the (KVM) Agent and there is a PR for that now: https://github.com/apache/cloudstack/pull/813 While working on it I found out that when writing it properly the profile can work on both Ubuntu 16.04 (to be released) and CentOS

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139913727 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139913812 @remibergsma I did and made another small change. I don't have a very good CentOS dev setup here, so I wasn't able to test it very thorough. I think this

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139914691 Why don’t you extract the content of line 1164 (the condition) to a method, this way it is possible to create a test case and enables some java doc.

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139914742 Automatically merged?!? I think it would be better to have merged, just after the squash --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-139907185 @wido In order to get it to work on CentOS 7 I had to patch it like this. You may want to add it to the PR: ``` diff --git

Build failed in Jenkins: build-master-slowbuild #2299

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

2015-09-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-139915266 This one was merged, but it wasn't closed since something went wrong with the commit to master. @remibergsma, help? Any idea on how to close this PR? --- If

Build failed in Jenkins: build-master-slowbuild #2300

2015-09-13 Thread jenkins
See Changes: [ashwinswaroop93] This is the fix for the JIRA issue CLOUDSTACK-8817. The return values for endpoint and startpoint are now Integer instead of String. [ashwinswaroop93] CLOUDSTACK-8817: listFirewallRules

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread ashwinswaroop
Github user ashwinswaroop commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139927888 @resmo Do you know the reason for the 2 aborted messages above? Is there anything I should do? --- If your project is set up for it, you can reply to this

Build failed in Jenkins: build-systemvm-master #623

2015-09-13 Thread jenkins
See Changes: [ashwinswaroop93] This is the fix for the JIRA issue CLOUDSTACK-8817. The return values for endpoint and startpoint are now Integer instead of String. [ashwinswaroop93] CLOUDSTACK-8817: listFirewallRules

Build failed in Jenkins: build-master-slowbuild #2301

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139921174 @ashwinswaroop, Well, now I have no idea what to do. Let’s hope someone with more experience reply to this thread. --- If your project is set up

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread ashwinswaroop
Github user ashwinswaroop commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139920903 @rafaelweingartner Okay so should I still squash the commits or leave it as it is since it says the pull request has been merged and closed? Also I received

[GitHub] cloudstack pull request: Cloudstack 8816 entityuuid missing in som...

2015-09-13 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/782#issuecomment-139958046 Thanks for the review guys. Two LGTMs mergins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Build failed in Jenkins: build-4.5 #525

2015-09-13 Thread jenkins
See Changes: [wido] CLOUDSTACK-8443: Support CentOS 7 for 4.5 -- [...truncated 3810 lines...] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-plugin-syslog-alerts --- [INFO]

Build failed in Jenkins: build-4.5 #526

2015-09-13 Thread jenkins
See Changes: [Rohit Yadav] cloudstack: set next version to 4.5.3-SNAPSHOT [Rohit Yadav] debian: add 4.5.3-snapshot to changelog -- [...truncated 3724 lines...] Results : Tests run: 4, Failures:

Build failed in Jenkins: build-master-slowbuild #2302

2015-09-13 Thread jenkins
See -- [...truncated 27639 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>>

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

2015-09-13 Thread harikrishna-patnala
Github user harikrishna-patnala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/809#discussion_r39362992 --- Diff: test/integration/smoke/test_baremetal.py --- @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139969167 builds were aborted probably because the PR was merged. This PR is properly merged to master with below commits * | | 120e1cc Merge pull request #810

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-139968967 Attached the screenshots to ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

2015-09-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139958818 Thanks @borisroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Cloudstack 8816 entityuuid missing in som...

2015-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

2015-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2015-09-13 Thread maneesha-p
Github user maneesha-p commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-139961981 @wido @remibergsma I am sorry I changed it for kvm but updated the description wrong. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/803#discussion_r39361975 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java --- @@ -350,4 +351,20 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t...

2015-09-13 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139957981 @DaanHoogland the repeated code is two lines calling sendalert and logger. may be we could move the logging to send alert itself. Will check that later. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 for 4.5

2015-09-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/814#issuecomment-139958619 @wido: thanks, LGTM. Sure, I think for now we should be focusing on master/4.6 and meanwhile keep fixing/merging any 4.5.x issues and perhaps attempt to do a 4.5.3

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...

2015-09-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/806#issuecomment-139962348 @remibergsma sure, but can do this next week (lack infra right now) --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Repo CS 4.5 for CentOS 7.x Missing

2015-09-13 Thread Keerthiraja SJ
Hi Guys, Is there a way I can get the CS 4.5.2 rpm's for CentOS 7.x http://cloudstack.apt-get.eu/centos7/4.5/ Thanks, Keerthi On Sun, Sep 13, 2015 at 6:12 AM, Pierre-Luc Dion wrote: > There is one:

Re: Build failed in Jenkins: build-master-slowbuild #2302

2015-09-13 Thread Rajani Karuturi
slow build is broken due to a new findbugs warning I think its not really new but, its reported maybe because of some reformatting. It maybe due to changes from commit 1c6378ec0056e8c75990a4a0c15e99b2df162a75 and PR 795 @borisroman @widodh can you take a look at the slow build please? ~Rajani On