[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-199642025 ### ACS CI BVT Run **Sumarry:** Build Number 117 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=14 Skipped=4

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-199568119 @remibergsma, @swill I had cherry-picked the changes of PR #780 into this PR and then I applied my changes to solve those problems that were reported

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-199535142 This LGTM. @pdube, would you mind reviewing this for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-199529926 ### ACS CI BVT Run **Sumarry:** Build Number 116 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=13 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199522152 Thank you @GabrielBrascher. I am also getting my CI setup so I can get tests running against these PRs, so I should be able to start validating this stuff as well.

[GitHub] cloudstack pull request: More VR performance!

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199521648 Sorry, my bad. I have been disconnected for 3 days and my inbox has exploded and I am trying to work my way through everything and my brain is a bit fried. Sorry

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199521289 @DaanHoogland @swill thank you for the concern. I agree with the need for executing integration/functional tests to keep the code stable. Unfortunately,

[GitHub] cloudstack pull request: More VR performance!

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199519708 @swill Already merge to 4.8 (for next 4.8.1) and on master (4.9) same commit id: 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39 --- If your project is set up

Re: Issue: CLOUDSTACK-9255 Unable to start VM DomainRouter due to error in finalizeStart

To me, it looks like PR #1449 is still relevant since it is minimizing the number of fetches required when the code is run and PR #1356 just made sure code was run only when it needed to be. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec

[GitHub] cloudstack pull request: speedup iptables setup

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-199517201 @kollyma, maybe just add a comment at the top to mention something like "pre-fetch the variables so they are not done inline" or something like that and this should

[GitHub] cloudstack pull request: More VR performance!

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199514658 Sorry, I missed that line in the comments. :) Thanks @ustcweizhou. I will check and see if it has been forward merged. It should be if it hasn't been, correct?

[GitHub] cloudstack pull request: More VR performance!

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199513826 @swill this PR has already been merged into 4.7 on 2016-01-23 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: More VR performance!

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199512959 I am happy with this PR. I believe I should be merging into 4.7 and then forward merging into 4.8 and master. I am sorry this is a bit off topic, but should we be

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199509482 With these major stripping out of unused code, we need to be very careful that we do not introduce integration test issues. Can you please validate that the

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-199500059 @rafaelweingartner, thank you for offering to merge in the changes from #780. I have reverted that merge, if you can merge it here and we can run integration tests

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199497512 Hey Guys, Sorry I have been MIA on this. I have been traveling and have limited connectivity. I am going to revert this merge. There are visible problems

[GitHub] cloudstack pull request: More VR performance!

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199448860 @DaanHoogland @remibergsma I don't want backport this fix, my (new) current installation of CS is under 4.8, but this RV bug is coming with the new python

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1441#discussion_r56880597 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -279,7 +282,52 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-199402183 ### ACS CI BVT Run **Sumarry:** Build Number 115 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=11 Skipped=4

[GitHub] cloudstack pull request: Enable/disable static NAT associates only...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1450 Enable/disable static NAT associates only relevant IPs. This pull request fixes a concurrency issue when disabling static NAT on a bunch of IPs simultaneously. Under the old behavior,

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1 Den fredag 18. mars 2016 skrev Will Stevens følgende: > We are discussing this proposal in 3 or 4 threads, so I will not try to > recap everything. Instead I will try to give a brief overview of the > problem and a proposal for solving it. > > *Problem:* > The

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1447#issuecomment-199337285 Hi @DaanHoogland. I did a maven install (this executes the unit tests). Also, the PR has passed in the Jenkins and the CI tests. However, I did not

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1 -Syed On Mon, Mar 21, 2016 at 8:31 AM, John Burwell wrote: > +1 (binding) > > > > > [image: ShapeBlue] > John Burwell > ShapeBlue > d: *+44 (20) 3603 0542 | s: +1 (571) 403-2411 * >

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199275394 Ok, that is somewhat comforting, however still a large integration test suite should be run on this. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015 @DaanHoogland the lack of test in some classes indeed is a problem. However, these classes that I removed are not being used. I used UCDetector

[GitHub] cloudstack pull request: More VR performance!

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791 @milamberspace No back porting please :-) Just upgrade to 4.7, it's a painless 10min job. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199270124 Guys, LGTMs or not, there were no integration test results posted so it shouldn't have been merged. --- If your project is set up for it, you can reply to this

FW: [PROPOSAL] - Reference Guide for CloudStack configuration parameters

Hi, All, I am still waiting for your review comments/thoughts on this categorization of configuration parameters. Thanks, Rajsekhar Kunnampally Senior Product Engineer | Accelerite, Bangalore Email: rajsekha...@accelerite.com Hi, All, Please find the wiki

[GitHub] cloudstack pull request: speedup iptables setup

Github user kollyma commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-199257722 @cristofolini : thanks! indeed the "Apache CloudStack Plugin - Quota Service" timed out. After reviewing the PR and the Jenkins output, I can not see any

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199254175 @DaanHoogland I don't see any reason for closing master in this case. If an issue is noticed after a merge, it definitely needs to be tracked and fixed.

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1 (binding) > [ShapeBlue] John Burwell ShapeBlue d: +44 (20) 3603 0542 | s: +1 (571) 403-2411 e: john.burw...@shapeblue.com | t: | w:

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1445#discussion_r56813778 --- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java --- @@ -19,84 +19,79 @@ package com.cloud.utils; -import

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-199232343 ### ACS CI BVT Run **Sumarry:** Build Number 114 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=13 Skipped=4

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1445#discussion_r56808020 --- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java --- @@ -19,84 +19,79 @@ package com.cloud.utils;

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199227949 @kishankavala you are formally correct and we had not closed master for release so I don't blame you for the merge. The issue as brought up by @swill is not to

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199222784 @swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from @swill came after the PR was merged on Mar 17 2016. By then, there were code reviews

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1441#discussion_r56801490 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -279,7 +282,52 @@ public

[GitHub] cloudstack pull request: More VR performance!

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-199210638 @milamberspace I think we seriously need to consider if we are going to maintain 4.6 as in the beginning of 4.7 many bugs were fixed on master and later 4.7

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-199209886 @swill I would not allow any other merge before this is fixed or reverted! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9315: Removed unused Classes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1448#issuecomment-199209016 @GabrielBrascher removing unused code is good; less is more. These are API calls and related stuff however. A large test set should be run and I am surprised

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1447#issuecomment-199207256 @pedro-martins How did you validate you didn't break anything? Was this work based on code analysis alone? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1445#discussion_r56799125 --- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java --- @@ -19,84 +19,79 @@ package com.cloud.utils; -import

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-199189940 Need one more LGTM, anyone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-199189395 @bvbharat Can you run the tests on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1. Regards Sadhu -Original Message- From: Bharat Kumar [mailto:bharat.ku...@accelerite.com] Sent: Monday, March 21, 2016 11:57 AM To: dev@cloudstack.apache.org Subject: RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack' +1 --Bharat On 21 Mar 2016 11:51 am, Kishan

[GitHub] cloudstack pull request: CLOUDSTACK-8829 : Consecutive cold migrat...

Github user maneesha-p commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/797#discussion_r56786342 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1776,19 +1773,26 @@ private void

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

Makes sense Shane if we can have that role shared amongst several people of the PMC, not just one as you suggest. On Mon, Mar 21, 2016 at 2:41 AM, Shane Curcuru wrote: > Will Stevens wrote earlier: > ... snip... > > *Proposal:* > > Transfer ownership of the

RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1 --Bharat On 21 Mar 2016 11:51 am, Kishan Kavala wrote: +1 for the move. Regards, Kishan Kavala Chief Product Engineer, CloudPlatform Development, Accelerite. www.accelerite.com -Original Message- From: chunfeng tian

RE: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

+1 for the move. Regards, Kishan Kavala Chief Product Engineer, CloudPlatform Development, Accelerite. www.accelerite.com -Original Message- From: chunfeng tian [mailto:tianyunqu...@gmail.com] Sent: 20 March 2016 05:22 PM To: dev@cloudstack.apache.org Subject: Re: [VOTE] Move