[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9217 script to ...

2016-03-25 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1322#issuecomment-201706492 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 ### ACS CI BVT Run

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

2016-03-25 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1402#issuecomment-201681267 @remibergsma can't you asking false instead of "false" ? If the function accepts boolean values I think that it would be more efficient.

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-201657556 @swill I've fixed for Travis now, locally I was successfully able to run more than 50 smoke/component tests against simulator. The Travis test result printer is

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-25 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1451#issuecomment-201620444 @alexandrelimassantana Agreed, thanks for the review. I've added a commit removing the prototype with the default. That has allowed me to remove that if altogether

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-25 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1451#issuecomment-201610435 @insom with this changes there is still one place where the applyConfigToVR is not provided with this timeout parameter (line 183, same class). This

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

2016-03-25 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-201576078 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 ### ACS CI BVT Run

[GitHub] cloudstack pull request: speedup iptables setup

2016-03-25 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-201531706 I am pretty comfortable with this PR given the scope of the change. Thanks @milamberspace for testing. Should this be committed against 4.7 and then forward

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-25 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-201497762 @swill I agree there a lot of incongruent changes in this PR. I would like to see it decomposed. For example, the Bouncy Castle upgrade should be completely

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-25 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-201496521 @swill Travis has been failing for several PRs when the test exceed the timeout period (30mins) https://travis-ci.org/apache/cloudstack/jobs/117688064 This has

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-25 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-201491672 There is a lot going on here and I don't like that Travis is failing since it tends to be pretty stable. Also, Travis is failing with a "Pull Request #1397 maven:

[GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...

2016-03-25 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1438#issuecomment-201476824 I don't think these tests failing are relevant to this change. We agree this is ready to be merged? Only against master? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Fix new error found in findbugs slow buil...

2016-03-25 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1438#discussion_r57485802 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -395,16 +391,9 @@

[GitHub] cloudstack pull request: New test to validate starting vm after ni...

2016-03-25 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1326#issuecomment-201368034 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 ### ACS CI BVT Run

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-03-25 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-201355723 @kollyma This was happening for swift because the `template.properties` file was not correctly populated. So, when a management restart happens, it syncs data from

Re: [DISCUSS] Request for comments: Dynamic Role Based API Access Checker for CloudStack

2016-03-25 Thread Daan Hoogland
you know you are great, right? On Fri, Mar 25, 2016 at 2:10 PM, Rohit Yadav wrote: > Hi Daan, > > Thanks for the comments. > > Yes, I looked into it but the IAM-services related work started by some of > our former colleagues was not in a good shape to be picked up,

Re: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread Sebastien Goasguen
> On Mar 25, 2016, at 10:24 AM, Raja Pullela > wrote: > > @Sebastien, thanks for the feedback. please note that the goal of this > exercise was not to impact any users during this migration and hence the > efforts to place the content at a location where we

RE: [DISCUSS] Request for comments: Dynamic Role Based API Access Checker for CloudStack

2016-03-25 Thread Rohit Yadav
Hi Koushik, Thanks for the comments on the FS, I've replied to all of them and updated the FS (for example, default param in APIs). Let me know on this ML thread or on the FS if you've further questions/comments. Thanks. Regards. Regards, Rohit Yadav rohit.ya...@shapeblue.com 

RE: [DISCUSS] Request for comments: Dynamic Role Based API Access Checker for CloudStack

2016-03-25 Thread Rohit Yadav
Hi Daan, Thanks for the comments. Yes, I looked into it but the IAM-services related work started by some of our former colleagues was not in a good shape to be picked up, it also introduced resource level fine-grain ACLs that would have required a lot of effort to both implement and test

Re: [DISCUSS] Request for comments: Dynamic Role Based API Access Checker for CloudStack

2016-03-25 Thread Koushik Das
The idea looks good. I have provided some questions/comments on the FS itself. Thanks, Koushik From: Rohit Yadav Sent: Wednesday, March 23, 2016 10:34 PM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject:

Re: [DISCUSS] Request for comments: Dynamic Role Based API Access Checker for CloudStack

2016-03-25 Thread Daan Hoogland
Rohit, I had a first glance and it looks promising; +1 You have been thourough on the fs. One question that comes to mind is whatever happened to the role base access That Min and Pradhi(not sure if I remeber her name correctly) where implementing for 4.4. It failed then because the work was

[GitHub] cloudstack pull request: CLOUDSTACK-9319: Use timeout when applyin...

2016-03-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1451#issuecomment-201246728 @insom any chance you can supply some test-mech? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread Rafael Weingärtner
I agree with Nux. Does not Apache CloudStack have its own domain? On Fri, Mar 25, 2016 at 7:37 AM, Nux! wrote: > +1 on keeping the download sites company agnostic. > > Shouldn't we take the opportunity and create a download.cloudstack.org or > similar now? > > Lucian > > -- >

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

2016-03-25 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-201243710 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 ### ACS CI BVT Run

Re: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread Nux!
+1 on keeping the download sites company agnostic. Shouldn't we take the opportunity and create a download.cloudstack.org or similar now? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Sebastien Goasguen"

RE: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread Raja Pullela
@Sebastien, thanks for the feedback. please note that the goal of this exercise was not to impact any users during this migration and hence the efforts to place the content at a location where we could move it to. Since Wido is ok with hosting the content on 'cloudstack.apt-get.eu', it is

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-03-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r57429500 --- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java --- @@ -26,13 +25,11 @@ public VpcOffering

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-03-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r57429458 --- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java --- @@ -26,13 +25,11 @@ public VpcOffering

Local disk full while creating snapshots

2016-03-25 Thread Andrija Panic
Hi guys, we are running intro strange situation, where local our /MNT folder on KVM nodes (where Secondary Storage gets mounted by Default) - becomes full 100%. During snapshots create, volume is moved from Primary Storage (CEPH our case) to /MNT/xx - but sometimes this folder seems to

Re: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread Sebastien Goasguen
>>> >>> Citrix has been hosting "download.cloud.com" for quite some time now >>> and it holds the System Templates for all the releases and some tools. >>> Going forward, this content needs to be moved from >>> "download.cloud.com".So, we will be moving this content to

Re: Migrating CloudStack content from download.cloud.com

2016-03-25 Thread ilya
Raja Would you know if cloud.com domain will be transferred to accelerite? Regards ilya On 3/24/16 5:38 AM, Wido den Hollander wrote: > >> Op 24 maart 2016 om 13:33 schreef Raja Pullela : >> >> >> Hi, >> >> Citrix has been hosting "download.cloud.com" for quite

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

2016-03-25 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1450#discussion_r57422486 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -778,10 +778,11 @@ public int compare(final PublicIpAddress o1, final

RE: [DISCUSS] Request for comments : VPC Inline LoadBalancer (new plugin)

2016-03-25 Thread Sanjeev Neelarapu
Hi Nick Livens, I have gone through the FS and following are my review comments: 1. Will this LB appliance be placed between guest vms and the Nuage VSP provider(Nuage VSP and lb appliance will have one nic in guest network)? 2. Is there any specific reason for traffic filtering on lb appliance