[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214637482 >@rhtyd maybe in a follow-up; can we split the test in hardware required true and false? @DaanHoogland for this feature's integration test, we don't need an

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-214637123 @swill It's done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214636312 Thank you @DaanHoogland @pyr @wido for the review @swill I think we've enough votes for this one, though le'ts wait for @borisstoyanov 's test results which h

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-214620580 @swill thanks, this can be merged first as we wait for bountycastle related changes to work with openjdk 1.7.0_95+ --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214617500 @jburwell I've not tested, but if it is using/enforcing SQL99 it should fail too (or it could be mysql 5.7.4+ issue); "As of MySQL 5.7.4, the IGNORE clause fo

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214574233 Do these instructions apply to MariaDB as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: CaaS in CloudStack with Kubernetes

Congrats Sebastien! I am very excited to see it running! Marco Sinhoreli Consultant Manager marco.sinhor...@shapeblue.com mobile: +55 21 98276 3636 Praia de Botafogo 501, bloco 1 - sala 101 – Botafogo Rio de Janeiro, RJ - Brazil - CEP 22250-040 office: + 55 21 2586 6390 | fax: +55 21 2586 6002

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-214542430 LGTM for code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-214538838 Running tests again in the same setup to see if any of the connection issues are resolved. The error for sure should be looked into... --- If your project is set up

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-214537887 ### CI RESULTS ``` Tests Run: 29 Skipped: 10 Failed: 3 Errors: 1 ``` **Summary of the problem(s):** ```

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-214529726 I do not find them (final static) purely cosmetics (we are using too much this expression lately). I understand its use, as I presented the references ab

ACS PRs Status - 2016/04/25

ACS PRs - 826 - master (ready, pending comments) - 1515 (1375) - 4.8 (ready, pending squash) - 1376 - master (ready, pending 1515 + rebase) - 1374 - master (ready, pending 1515 + 1376 + rebase) - 1054 - master (grep, pending CI) - 1464 - master (pending LGTM) - 1436 - master (

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-214518411 @rafaelweingartner yes, as I have said, ``final statics`` are not evaluated for GC. A single case is not a noticeable problem. However, if made all loggers were

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-214509189 @jburwell, @syed, sorry the long post, I did a research on a few thing and I would like to share with you guys. I was just looking at the state of

[GitHub] cloudstack pull request: Remove unused images

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-214505566 @remibergsma bump. :) just a friendly reminder. what should we do with this PR? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-214503490 Would you mind doing a force push to try to get everything green. Thanks... --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user dmytro-shevchenko commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-214497874 Rebase with Master done, pom.xml file updated. Also I perform a small modification in code, during testing I found one issue: in 'snapshot_store_ref'

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-214495424 ### CI RESULTS ``` Tests Run: 0 Skipped: 0 Failed: 0 Errors: 0 ``` **Associated Uploads** **`

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-214480409 go ahead. I am trying to get to the bottom of marvin being strange right now. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-214480008 @swill busy on this one yet? I am looking to run it as well --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Re: No module named marvin

I had this some bubbles back. the mysql connector python driver is not the stablest of packages it seems. I started a new environment in my bubble last this afternoon (your morning). I will restart one later tonight, just to see. On Mon, Apr 25, 2016 at 8:06 PM, Will Stevens wrote: > Could this:

No module named marvin

Could this: Deploy data center.. Traceback (most recent call last): File "/data/git/cs3/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 28, in from marvin import configGenerator ImportError: No module named marvin Be caused by this: Installing Marvin DEPRECATION: --allow-externa

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214463216 Just finished all reruns of failing tests in the bubble. They all succeeded. [1511.results.network.txt](https://github.com/apache/cloudstack/files/2350

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214459138 Thank you sir. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214458410 I found one bug and added a commit to solve it. I will keep at tjis one for a while. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214455195 Lets get some CI results in here so we can start to figure out what is going on. I believe I had a bunch of problems with this PR before it was broken out, so I wan

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214454225 @swill it seems the berfore script is failing sometimes. I don't think this is a problem with the PR itself. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-214448604 Can you squash the commits for me? I will get this merged and then forward merged to master and then we can rebase the other ones to to make sure we don't have merge

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-21297 I will run those failed travis tests in the bubble. I am seeing some failures as well so this needs more work --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214432357 @swill done, though as I mentioned in the comments above the test that failed in last travis run is a component test and fails on master too (i.e. not related to this

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60944411 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,478 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214430311 > @rhtyd My comment regarding the test was more in the context of perf. test. In the DB for regular user I saw ~250 permissions got created. So this means iterating o

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-214417865 @jburwell can I get your LGTM? I will run CI on this again today because some code has changed since the last run. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-214414936 @dmytro-shevchenko We have 2 LGTMs on this and it just needs a CI run. Could you make the change @DaanHoogland requested above regarding the pom.xml and also reba

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214414511 Thanks @DaanHoogland. Travis seems to be upset with a couple errors. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60938011 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,167 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60937993 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,167 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214412952 I will run CI on this today. @rhtyd can you force push again to see if we can get all green lights. @jburwell I see you have been active on this PR, does it have yo

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-214406895 Great thanks... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Jenkins broken?

I have had to ask a lot of people to do this recently, so you are not alone. The builds usually do work on a second attempt. On Apr 25, 2016 9:56 AM, "David Mabry" wrote: > Sure, I give it a shot and let you know the results. > > Thanks, > David Mabry > > > > > > > On 4/25/16, 8:54 AM, "Will Stev

Re: Jenkins broken?

Sure, I give it a shot and let you know the results. Thanks, David Mabry On 4/25/16, 8:54 AM, "Will Stevens" wrote: >Jenkins has been acting up a bit recently. Try doing a force push of your >PR to kick off the run again to see if it still fails. >On Apr 25, 2016 9:14 AM, "David Mabry" wr

Re: Jenkins broken?

Jenkins has been acting up a bit recently. Try doing a force push of your PR to kick off the run again to see if it still fails. On Apr 25, 2016 9:14 AM, "David Mabry" wrote: > Hello everyone, > > Can someone check on Jenkins? It looks like it not able to check out 4.7 > branch and it’s failing

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-214337105 Based on the code review, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

Jenkins broken?

Hello everyone, Can someone check on Jenkins? It looks like it not able to check out 4.7 branch and it’s failing on my pull request. See the logs below: FATAL: Could not checkout 4.7 with start point origin/4.7 hudson.plugins.git.GitException

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-214306315 @koushik-das : I will check it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1518 CLOUDSTACK-9368: Fix for Support configurable NFS version for Secondary Storage mounts ## Description JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9368 This pull reque

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214297629 @swill I started the smoke tests for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214296336 @rhtyd My comment regarding the test was more in the context of perf. test. In the DB for regular user I saw ~250 permissions got created. So this means iterati

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214281121 @koushik-das can you share what you think are the advantages of static role-base api checker? --- If your project is set up for it, you can reply to this email and h

Cannot create issues on JIRA

Hi guys, I wanted to create an issue on JIRA but I can't see Cloudstack project listed in Project field. I was able to see it before lockdown. Can I have permission to create one? Thanks, Nicolas

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60899950 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables-p

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214276787 @koushik-das Yes, all tests run as a regular user too. See the integration test, we're using user api clients (search self.getUserApiClient) to perform tests -- i.e.

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60899216 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60898417 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables-p

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/38 CLOUDSTACK-9299: doc for out-of-band management Admin documentation for out-of-band management feature cc @pdion891 @swill You can merge this pull request into a Git repository

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214269005 @rhtyd Have you ran the tests using a regular user? As per dynamic checker code, for root admin all checks are bypassed. I think a good comparison will be to ru

Re: IPv6 progress in Basic Networking

> Op 25 april 2016 om 12:45 schreef Abhinandan Prateek > : > > > > At shapeblue we are also working towards enabling ipv6 specially for advanced > networking/ospf. > Our approach is more of bottom up where we plan to streamline basic > networking entities and extend them so that they are ipv

Re: mysql-bin log files eating more space and DB server root fs filling up now at 98%

> Op 25 april 2016 om 12:28 schreef anil lakineni > : > > > Hi All, > > In Cloud DB server, the root file system reached to 98% and found that > */var/lib/mysql/* is consumed with more space. > > Inside that specified directory i found that " *mysql bin logs* " are > eating more space and fil

Re: IPv6 progress in Basic Networking

At shapeblue we are also working towards enabling ipv6 specially for advanced networking/ospf. Our approach is more of bottom up where we plan to streamline basic networking entities and extend them so that they are ipv6 aware. This way we ensure that these entities can then be used by both adv

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214257913 Marvin Init Successful === TestName: test_oobm_background_powerstate_sync | Status : SUCCESS === === TestName: test_oobm_change_password | Status

Re: Introduction

Welcome Rashmi ! On 08/04/16, 10:28 AM, "Rashmi Dixit" wrote: >Hello! > >I am Rashmi Dixit and have recently joined the CloudPlatform team in >Accelerite. I have worked on a hybrid cloud management solution supporting >hypervisors such as KVM, Xen, VMware, HyperV and public clouds such as E

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214252922 All tests passes, except for a test that runs only on simulator that sometimes passes, sometimes fails. This issue is due to master and not specific to this PR: =

mysql-bin log files eating more space and DB server root fs filling up now at 98%

Hi All, In Cloud DB server, the root file system reached to 98% and found that */var/lib/mysql/* is consumed with more space. Inside that specified directory i found that " *mysql bin logs* " are eating more space and files are there since one year. My environment has enabled with DB replication

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214249307 @DaanHoogland thanks, if we can migrate to Java8 I won't mind not fixing the issue for 1.7 at all --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890292 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-214246821 @jburwell - sure, I should be able to look at that this week. I'll investigate why the CI build failed as well. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890271 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214243282 @rhtyd I am using 1.8 exclusively atm. I will see if I find any problems in that. may look at 1.7 someday. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-214242715 @swill @jburwell the concerns noted above are taken care off. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214240215 I've fixed all outstanding issues, please comment if you see any outstanding issue. LGTMs welcome, thanks. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214233279 @wido thanks for the comments. It seemed easier to pass the arguments to the oobm subsystem, there is a immutable map of option,string being returned this is why all

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885367 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885329 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214229683 I found this article by Oracle MySQL team useful: https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade --- If your project is s

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1517 engine/schema: fix upgrade path to work with MySQL 5.7 Found this issue when using MySQL 5.7 with Ubuntu 16.04. The upgrade path fix removes an invalid `IGNORE` param that is deprecated now, in t

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60882026 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long getDomainI

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881906 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java --- @@ -70,10 +72,12 @@ @Parameter

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881499 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade() { @Ove

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881018 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880846 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880204 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880231 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880213 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880195 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880160 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60879938 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final Lo

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214212648 @koushik-das this is part of the feature to be able to check access based on rules in DB and be consistent across all mgmt servers. In my local environment with stock

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-214211132 @swill I think this one has enough LGTM and testing and the only question I see remaining has been answerred. @pedro-martins is not responded anymore so let's

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user prashanthvarma commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-214209793 @DaanHoogland, We haven't heard from @pedro-martins in a while. Let's hope, he responds soon (or) someone form the community reviews our code. --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-214208033 @priyankparihar Are you saying that you have tested the fix in all scenarios with different HVs (XS, KVM, Vmware)? Also if HV doesn't allow certain operations it

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-214204041 @nitin-maharana The second dialog is not going away after clicking "yes" even though the API call is issued with forced=true. I don't think this is expected. It