[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

2016-05-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1552#issuecomment-220813347 Does this need CI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

2016-05-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1556#issuecomment-220811376 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 1 Duration: 11h 00m 25s ``` **Summary of the

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-21 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220810829 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 55m 29s ```

[GitHub] cloudstack pull request: Removed unused methods from XenServerConn...

2016-05-21 Thread rodrigo93
GitHub user rodrigo93 opened a pull request: https://github.com/apache/cloudstack/pull/1557 Removed unused methods from XenServerConnectionPool Removed the following methods that are unused from the class _com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool_: -

[GitHub] cloudstack pull request: Removed Unused Void Class

2016-05-21 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/1440#issuecomment-220795597 Thanks for the help! =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

2016-05-21 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1556#issuecomment-220785566 Given our discussion on mailing list and code review, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220784860 I've fixed the English messages. All is green. LGTM level reached. Ready to merge. cc @swill --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220778699 the message is not in good English, other then that LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64134782 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -123,6 +123,8 @@ customCACert= publicIp= hostName= keyStore=$(dirname

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64134773 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -167,7 +169,7 @@ then fi if [ ! -f "$customPrivKey" ] then - printf

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220778455 It seems that even without a custom SSL cert, one needs this PR to be able to download from other https sites (as the realhostip one is always loaded). --- If

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64134745 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -123,6 +123,8 @@ customCACert= publicIp= hostName= keyStore=$(dirname

Re: solidfire in master

2016-05-21 Thread Daan Hoogland
On Sat, May 21, 2016 at 3:05 PM, Daan Hoogland wrote: > Mike, Will, > > Do you recognise this: > [ERROR] COMPILATION ERROR : > [INFO] - > [ERROR] >

solidfire in master

2016-05-21 Thread Daan Hoogland
Mike, Will, Do you recognise this: [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220771292 ping @ustcweizhou , does this suit Leaseweb? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64132615 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -123,6 +123,8 @@ customCACert= publicIp= hostName= keyStore=$(dirname

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64132608 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -167,7 +169,7 @@ then fi if [ ! -f "$customPrivKey" ] then - printf

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220767434 Thanks @milamberspace! I was also looking into this and hacked around a bit. Your solution is nice! Now when a custom cert is used, the other CAs are also

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-21 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220766648 @swill if it's failing for addHost, can you send the mgmt server log, marvin log and the agent log, and details of the environment (as much as possible). I can have

Build failed in Jenkins: build-systemvm64-master #793

2016-05-21 Thread jenkins
See -- Started by timer Started by timer Started by timer Started by timer Started by timer Started by timer Started by timer Started by timer Started by timer [EnvInject] - Loading node

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-21 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220764639 Travis & Jenkins are green. Ready for 2 x LGTM (easy review) cc @DaanHoogland @rhtyd --- If your project is set up for it, you can reply to this

Build failed in Jenkins: build-master-slowbuild #3569

2016-05-21 Thread jenkins
See -- [...truncated 6095 lines...] at org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188) at