Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

[B Prakash]

Please ignore my previous email.   Building offline worked.


Thanks and regards,

 B Prakash



From: B Prakash 
Sent: Sunday, August 28, 2016 3:06 PM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi Rohit, I put-up another vm and built code on it, I got the same error.  I 
downloaded non oss jars and ran a build offline, I still get the same error, 
unable to fix this.


Thanks and regards,

 B Prakash



From: Rohit Yadav 
Sent: Tuesday, August 23, 2016 5:05 AM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi B,


This seems like a network issue to me, you may try changing networks and see if 
that works, or identify if there are any firewall policies in your network 
barring you to access those url resources.


Regards.


From: B Prakash 
Sent: 23 August 2016 10:22:45
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi Rohit,  thank you!  I am using the main master branch.  I have all the 
latest files.  I am having this problem only since last few weeks, earlier my 
build was running fine.I tried this and I still have the same problem.  I 
will will install nonoss deps and try again, meanwhile, following is the build 
error I have now;



Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-client/3.1.3/xmlrpc-client-3.1.3.jar
 (58 KB at 681.0 KB/sec)
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-common/3.1.3/xmlrpc-common-3.1.3.jar
 (107 KB at 1005.4 KB/sec)
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/ws/commons/util/ws-commons-util/1.0.2/ws-commons-util-1.0.2.jar
 (34 KB at 0.0 KB/sec)
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443


Thanks and regards,

 B Prakash



From: Rohit Yadav 
Sent: Monday, August 22, 2016 1:04 PM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi B, how are you building CloudStack? Which branch is it?

Can you try a full clean build: mvn clean install -Dnoredist -Dsimulator -P 
developer,systemvm

You may install nonoss dependencies from here: 
https://github.com/rhtyd/cloudstack-nonoss
[https://avatars1.githubusercontent.com/u/95203?v=3=400]

GitHub - rhtyd/cloudstack-nonoss: Apache CloudStack - Non 
...
github.com

[GitHub] cloudstack pull request #1635: CLOUDSTACK-9451

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1635#discussion_r76550534
  
--- Diff: 
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
 ---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, 
@BeanParam DeploymentPlan plan, E
 boolean stop(String caller) throws ResourceUnavailableException, 
CloudException;
 
 /**
+ * Stop the virtual machine, optionally force
+ *
+ */
+boolean stop(String caller, boolean forced) throws 
ResourceUnavailableException, CloudException;
--- End diff --

@nathanejohnson I wasn't thinking to change any of the existing code.  I am 
just interested in avoiding incurring any more flag argument technical debt.

In terms of testing, this change is not hypervisor specific.  Therefore, a 
test case that utilizes the simulator might be a more fruitful path.  @rhtyd 
may have some thoughts as to how you could accomplish it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@murali-reddy Looking through the Marvin tests, there is a lot of 
boilerplate code and duplicated setup in test cases.  It feels like there is an 
opportunity to introduce one or more base classes that would not only reduce 
the duplication/boilerplate, but make building future VR test cases easier.  Do 
you agree?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@dsclose what is your opinion of the changes in this PR relative to your 
work?  Do you see any gaps or missing pieces?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
@lmrv does this defect impact 4.9 as well?  If so, could you please 
re-target this PR to the 4.9 branch?

Also, why is there a merge commit in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
@PaulAngus does this defect occur in 4.9 as well?  If so, please re-target 
the PR to the 4.9 branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi @nitt10prashant could you please collapse the test 
case and feature PRs?  It is very difficult to test the feature when the tests 
are in a different branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

4.8.2.0/4.9.1.0 RC Status

[John Burwell]

All,

I apologize for being behind getting the 4.8.2.0 and 4.9.1.0 RCs out.  A small 
part of it was due to the RC release dates falling the weekend after being on 
vacation, and a large part of it is due to rookie mistakes as a first time RM.  
Hopefully, the lessons learned will keep things on-time for the 4.9.2.0 and 
4.10.0.0 releases.

The big lesson learned is that we need to watching the candidate PRs for a 
release about 7-10 days in advance of a release.  To that end, we have the 
following are the PRs targeted for 4.8.2.0 and 4.9.1.0 which need to be closed 
before we can cut an RC:

* 1635 [1]: CLOUDSTACK-9451
* 1636 [2]: Fix a quote issue with Spanish L10N (from transifex translation)
* 1654 [3]: Updating pom.xml version numbers for release 4.8.2.0-SNAPSHOT
* 1624 [4]: Fixes regarding VOLUME_DELETE events resulting from account 
deletion

The following are the PRs targeted for 4.9.1.0 which need to be closed be we 
can cut an RC:

* 1621 [5]: [CLOUDSTACK-9444] Fix a little issue from PR1610 if the 
db.properties file hasn't EOL character at the end of file
* 1648 [6]: test/integration: fix tearDown order in list_acl_ tests
* 1663 [7]/1653 [8]: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflection 
attacks (
* 1660 [9]: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affecting 
interaction with vRouter in VmwareResource and HypervDirectConnectResource
* 1665 [10]: Changes database upgrade script names to be consistent for the 
4.9.1.0 release

Please let me know if there is a PR or defect you feel must be addressed in 
order to ship either 4.8.2.0 or 4.9.1.0.  Otherwise, we will be working to get 
these PRs merged ASAP and cut RCs for voting.

Thank you for patience as I stumble through this process for the first time,
-John

[1]: https://github.com/apache/cloudstack/pull/1635
[2]: https://github.com/apache/cloudstack/pull/1636
[3]: https://github.com/apache/cloudstack/pull/1654
[4]: https://github.com/apache/cloudstack/pull/1624
[5]: https://github.com/apache/cloudstack/pull/1621
[6]: https://github.com/apache/cloudstack/pull/1648
[7]: https://github.com/apache/cloudstack/pull/1663
[8]: https://github.com/apache/cloudstack/pull/1653
[9]: https://github.com/apache/cloudstack/pull/1660
[10]: https://github.com/apache/cloudstack/pull/1665


john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack pull request #1665: Changes database upgrade script names consist...

[jburwell]

GitHub user jburwell opened a pull request:

https://github.com/apache/cloudstack/pull/1665

Changes database upgrade script names consistent for the 4.9.1.0 release

  * Changes the names of the schema-490to491* scripts to
  schema-490to4910*
  * Changes the name of the Upgrade490to491 class to Upgrade490to4910
  * Modifies the Marvin setup.py script to use version 4.9.1.0-SNAPSHOT

/cc @rhtyd @karuturi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack jsb/4.9.1.0-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1665


commit 9e57fb7c467563f0604c15f6b89fa21e1502dac3
Author: John Burwell 
Date:   2016-08-29T03:07:53Z

Changes database upgrade script names consistent for the 4.9.1.0 release

  * Changes the names of the schema-490to491* scripts to
  schema-490to4910*
  * Changes the name of the Upgrade490to491 class to Upgrade490to4910
  * Modifies the Marvin setup.py script to use version 4.9.1.0-SNAPSHOT




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1635: CLOUDSTACK-9451

[nathanejohnson]

Github user nathanejohnson commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1635#discussion_r76547668
  
--- Diff: 
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
 ---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, 
@BeanParam DeploymentPlan plan, E
 boolean stop(String caller) throws ResourceUnavailableException, 
CloudException;
 
 /**
+ * Stop the virtual machine, optionally force
+ *
+ */
+boolean stop(String caller, boolean forced) throws 
ResourceUnavailableException, CloudException;
--- End diff --

For better or worse, I was just trying to follow the lead of the actual 
method that does the work in question, namely advanceStop, and some of the 
methods called from advanceStop.  I have no issue changing the name to have 
force in it and skip the bool flag (lest Fowler think I'm a bad programmer), 
but I am not thinking that I'd like to change the signature of advanceStop or 
any other the other methods that eventually get called in the chain where there 
is a bool flag in it.  I think the much bigger issue with this bit of code is 
that the refactor that lead to this issue in the first place abstracted the 
call to advanceStop under so many layers that it made it really hard to notice 
that functionality was reduced in the first place, to the point where the 
author nor anyone reviewing caught it.  If I was to place serious energy into 
refactoring, I'd probably start with undoing a lot of that abstraction, but 
that would require me being familiar with a lot more of the codebase than I
  currently am.  Also, more immediately, I want to come up with a good test for 
this, but so far haven't been able to come up with something reliable / 
reproducible under kvm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[leprechau]

Github user leprechau commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
@jburwell Is there already an existing test for the previous behavior that 
could be modified?  I haven't had a chance to do much with Marvin other than 
briefly browse the tests folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
@leprechau you have expanded the type of networks blocks supported by the 
system.  Therefore, there should be a Marvin test case that attempts to specify 
a CGN network block for a guest network and verifies that the system behaves as 
expected.  In particular, the test should verify that the API calls are 
successful, and that the networks are implemented as expected when a CGN 
network block is specified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@milamberspace could you add a JIRA ticket for this issue and prefix the 
title of the commit message and PR title with the ID?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@nvazquez could you please amend your commit message to explain why/how 
this fix addresses the defect?

Also, verification of this PR is to run ``test_network_acl`` against 
VMware, correct?

@borisstoyanov do you have time to run tests this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1663
  
@NuxRo Any thoughts to add?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546255
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546205
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546182
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546145
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546110
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1663#discussion_r76546049
  
--- Diff: test/integration/smoke/test_router_dns.py ---
@@ -0,0 +1,286 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import dns.resolver
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (ServiceOffering,
+ VirtualMachine,
+ Account,
+ NATRule,
+ FireWallRule,
+ NetworkOffering,
+ Network)
+from marvin.lib.common import (get_zone,
+   get_template,
+   get_domain,
+   list_routers,
+   list_nat_rules,
+   list_publicIP)
+
+
+class TestRouterDns(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.logger = logging.getLogger('TestRouterDns')
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+cls.testClient = super(TestRouterDns, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+
+cls.logger.debug("Creating Admin Account for domain %s on zone %s" 
% (cls.domain.id, cls.zone.id))
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+admin=True,
+domainid=cls.domain.id
+)
+
+cls.logger.debug("Creating Service Offering on zone %s" % 
(cls.zone.id))
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offering"]
+)
+
+cls.logger.debug("Creating Network Offering on zone %s" % 
(cls.zone.id))
+cls.services["isolated_network_offering"]["egress_policy"] = "true"
+cls.network_offering = NetworkOffering.create(cls.api_client,
+   
cls.services["isolated_network_offering"],
+   conservemode=True)
+cls.network_offering.update(cls.api_client, state='Enabled')
+
+cls.logger.debug("Creating Network for Account %s using offering 
%s" % (cls.account.name, cls.network_offering.id))
+cls.network = Network.create(cls.api_client,
+  cls.services["network"],
+  accountid=cls.account.name,
+  domainid=cls.account.domainid,
+  
networkofferingid=cls.network_offering.id,
+  zoneid=cls.zone.id)
+
+cls.logger.debug("Creating guest VM for Account %s using offering 
%s" % (cls.account.name, cls.service_offering.id))
+cls.vm = VirtualMachine.create(cls.api_client,
+ cls.services["virtual_machine"],
+ templateid=cls.template.id,
+ accountid=cls.account.name,
+  

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
@rhtyd thanks for clarification in the commit message -- makes total sense 
now.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1621
  
I would like to get this PR into 4.9.1.0.

@borisstoyanov have you gotten a change to test this PR?

@rhtyd @milamberspace could you investigate the cause of the Travis build 
failure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1591: Updating Alert codes

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1591
  
@rhtyd @dcarbone given that we are trying to get a 4.8 RC cut ASAP (we are 
week late already), I think it is best to push this PR to 4.9.2.0.  Would you 
mind re-pointing it to the 4.9 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
@leprechau following up regarding Marvin tests.  Unless they are ready, we 
are likely going to have to push this PR to 4.9.2.0 since I am trying to get a 
4.8.2.0 RC cut ASAP (we are week late already).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
@ProjectMoon I am trying to cut the 4.8.2.0 RC ASAP.  This PR looks like it 
is not going to make it given the test failures.  Do you mind re-pointing it to 
4.9?  We will make this PR a high priority for 4.9.2.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1624#discussion_r76545408
  
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
 CallContext.unregister();
 }
 
+public UsageEventUtils setupUsageUtils() {
+_usageEventDao = new MockUsageEventDao();
+UsageEventUtils utils = new UsageEventUtils();
+
+Map usageUtilsFields = new HashMap();
+usageUtilsFields.put("usageEventDao", "_usageEventDao");
+usageUtilsFields.put("accountDao", "_accountDao");
+usageUtilsFields.put("dcDao", "_dcDao");
+usageUtilsFields.put("configDao", "_configDao");
--- End diff --

@ProjectMoon I got lost thinking it was in the main code base re-allocating 
a set of static values on every invocation would cause GC churn.  Not a 
significant concern in a test class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1624
  
@ProjectMoon both the Jenkins and Travis builds are failing.  Could you 
please investigate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1635: CLOUDSTACK-9451

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1635#discussion_r76544594
  
--- Diff: 
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
 ---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, 
@BeanParam DeploymentPlan plan, E
 boolean stop(String caller) throws ResourceUnavailableException, 
CloudException;
 
 /**
+ * Stop the virtual machine, optionally force
+ *
+ */
+boolean stop(String caller, boolean forced) throws 
ResourceUnavailableException, CloudException;
--- End diff --

[Flag arguments](http://martinfowler.com/bliki/FlagArgument.html) are a 
nasty code smell/anti-pattern.  Please consider changing method to something 
more descriptive with a flag argument such as ``forceStop(String caller)``.  
The contrasting version of the method already exists on the interface so it 
would be a compatible change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@rhtyd do you any insight about the database schema issue @milamberspace is 
encountering in the Travis build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1654
  
@rhtyd I have updated this PR to reflect version being 4.8.2**.0** rather 
than 4.8.2.  I also added empty migration scripts to maintain consistency with 
previous releases (e.g. 4.8.1).  Could you please test and verify?

@karuturi @abhinandanprateek @murali-reddy could you please provide a code 
review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

[B Prakash]

Hi Rohit, I put-up another vm and built code on it, I got the same error.  I 
downloaded non oss jars and ran a build offline, I still get the same error, 
unable to fix this.


Thanks and regards,

 B Prakash



From: Rohit Yadav 
Sent: Tuesday, August 23, 2016 5:05 AM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi B,


This seems like a network issue to me, you may try changing networks and see if 
that works, or identify if there are any firewall policies in your network 
barring you to access those url resources.


Regards.


From: B Prakash 
Sent: 23 August 2016 10:22:45
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi Rohit,  thank you!  I am using the main master branch.  I have all the 
latest files.  I am having this problem only since last few weeks, earlier my 
build was running fine.I tried this and I still have the same problem.  I 
will will install nonoss deps and try again, meanwhile, following is the build 
error I have now;



Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-client/3.1.3/xmlrpc-client-3.1.3.jar
 (58 KB at 681.0 KB/sec)
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-common/3.1.3/xmlrpc-common-3.1.3.jar
 (107 KB at 1005.4 KB/sec)
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/ws/commons/util/ws-commons-util/1.0.2/ws-commons-util-1.0.2.jar
 (34 KB at 0.0 KB/sec)
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443


Thanks and regards,

 B Prakash



From: Rohit Yadav 
Sent: Monday, August 22, 2016 1:04 PM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi B, how are you building CloudStack? Which branch is it?

Can you try a full clean build: mvn clean install -Dnoredist -Dsimulator -P 
developer,systemvm

You may install nonoss dependencies from here: 
https://github.com/rhtyd/cloudstack-nonoss
[https://avatars1.githubusercontent.com/u/95203?v=3=400]

GitHub - rhtyd/cloudstack-nonoss: Apache CloudStack - Non 
...
github.com
cloudstack-nonoss - Apache CloudStack - Non OSS libraries ... Clone with HTTPS 
Use Git or checkout with SVN using the web URL.





Regards.


From: B Prakash 
Sent: 22 August 2016 21:17:50
To: dev@cloudstack.apache.org
Subject: Compilation error "Execution cloudstack-checklicence of goal 

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@jburwell now both tests passed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76532860
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +198,9 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 
 String result = sbResult.toString();
 
+if (StringUtils.isBlank(result))
+result = IOUtils.toString(stdout);
--- End diff --

Done, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
@nvazquez The Travis build has failed.  Can you investigate? Likely just 
needs to be re-kicked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r76530524
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +198,9 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 
 String result = sbResult.toString();
 
+if (StringUtils.isBlank(result))
+result = IOUtils.toString(stdout);
--- End diff --

Per our coding standards, all conditionals must wrapped in curly braces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[dsclose]

Github user dsclose commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@murali-reddy - thank you for picking this up. Let me know when you think 
it's appropriate to close PR #1519 and I shall do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---