[GitHub] cloudstack pull request #1899: CLOUDSTACK-9650: Allow starting VMs regardles...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1899#discussion_r95524526 --- Diff: api/src/com/cloud/deploy/DeploymentClusterPlanner.java --- @@ -55,7 +55,7 @@ "true", "Enable/Disable cluster

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1899 @koushik-das there are no tests, Java related code changes ought to require regression tests, even if it may appear to not need them. Let's not work towards degrading the branch health. --- If

[GitHub] cloudstack pull request #1899: CLOUDSTACK-9650: Allow starting VMs regardles...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1899#discussion_r95524178 --- Diff: api/src/com/cloud/deploy/DeploymentClusterPlanner.java --- @@ -55,7 +55,7 @@ "true", "Enable/Disable cluster

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1727 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 Trillian test result (tid-775) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36639 seconds Marvin logs:

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1836 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1899: CLOUDSTACK-9650: Allow starting VMs regardles...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 Merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95514039 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95515374 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517419 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517522 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable)

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95514745 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517926 --- Diff: setup/db/db/schema-490to4910.sql --- @@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95516498 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95516609 --- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java --- @@ -80,4 +80,8 @@ public boolean isDisplay() { return display;

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1812 @rhtyd Sure will let you know if trillian tests are needed. In this case XS test results were already there from @cloudmonger. I used the git-pr script but not sure why the merge commit

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1735 @serg38 I had some open questions on code which are not yet answered specifically related to use case of null case and comparison of non comparable properties. Also, For unmanaged

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1735 @mike-tutkowski The only comments in this PR are about deletion of PS with a snapshot copy. I am 100% agree with your statement. This PR excludes destroyed snapshot copies including ones on the

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 Also, I think we need to keep the `Makefile` with an empty `SPHINXOPS` So the default build will be for english version and RTD.org will detect the translation files and will do them

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 @lmrv , I've quickly reviewed the translated content. but I'm wondering why the `make.sh` file is removed? --- If your project is set up for it, you can reply to this email and

Re: [GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

@milamberspace I don't agree. Ubuntu 14.04 isn't EOL for another two years, rhel6 even longer. But users should be given proper directions as to how they can update Java. And we need to fix systemd/Ubuntu 16.04 support Erik tir. 10. jan. 2017 kl. 08.24 skrev milamberspace

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1888 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1747 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1836 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1888 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 JFYI, these are the docker images Trillian uses to build packages for CloudStack, they have all the dependencies and jenv (http://www.jenv.be/) installed to automatically switch between java7 or

Re: [RESULT][VOTE] Apache Cloudstack 4.9.2.0 (RC2)

Thank you everyone who submitted and reviewed PRs, participated in the release effort. Regards. From: Rene Moser Sent: 06 January 2017 14:54:43 To: dev@cloudstack.apache.org Subject: Re: [RESULT][VOTE] Apache Cloudstack 4.9.2.0 (RC2)

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1747 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1727 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1767 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1735 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1735 @mike-tutkowski sorry I don't have the bandwidth for a review, though I can facilitate with running tests. Maybe @anshul1886 and/or @serg38 can comment. Thanks. @blueorangutan test ---

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1836 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1812 @koushik-das You could have pinged me to run tests on Trillian with xen/vmware/kvm to confirm that no regressions were made. Also when you use git-pr, the git-merge commit does not have

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/977 Trillian test result (tid-773) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38115 seconds Marvin logs:

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1900 I don't have the resources in my lab available to perform tests on this at this time, but the code itself LGTM. Thanks for working on this JIRA ticket! --- If your project is

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1735 @serg38 @anshul1886 @rhtyd Maybe someone could take a look at my comments before we check this in and see if they think any of those should be implemented here. Thanks --- If your

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1735 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rhtyd Done, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1735 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1727 @serg38 sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1747 @nvazquez can you squash your change and see why Travis failed, in case of intermittent issue, push -f to rekick Travis. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1735 @serg38 sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1767 @serg38 sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rhtyd Can you kick off tests fro this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1735 @mike-tutkowski @anshul1886 @rhtyd We had enough LGTM and successful test results for this PR. Are there any concern before merging it? --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @koushik-das @rhtyd This PR now supports custom service offerings. Can you review and kick off tests? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1899 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1900 CLOUDSTACK-8862: Introduced new state attaching for volume. This will… … make sure that other attach operation on same volume will fail gracefully without calling access calls for

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1899 LTGM smoke test is not necessary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 @ustcweizhou please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1899: CLOUDSTACK-9650: Allow starting VMs regardles...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1899 CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.… …disablethreshold setting Fixed the scope of configuration flag 'cluster.threshold.enabled' introduced

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/977 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/977 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1812: CLOUDSTACK-9650: Allow starting VMs regardles...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/977 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project