[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message in UI if user ...

[ramkatru]

Github user ramkatru commented on the issue:

https://github.com/apache/cloudstack/pull/1855
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

[ramkatru]

Github user ramkatru commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106313430
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

No problem ;)

It is awesome the changes you have done here. The code became cleaner, with 
good documentation and on top of that, we now have unit tests to guarantee that 
the methods are workings as expected.

Great job @nvazquez, well done!

PS: Sorry if I have been too picky with the code changes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106311985
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

Nice, I agree with you that deleting the line can be removed. Sorry for the 
confusion, I'll try adding some unit tests for this change. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106306374
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

Ah, no this is not what I meant.
I meant only removing the `if` and letting the `while` directly there.
Just deleting line 103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106303439
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

Hi @rafaelweingartner, I assumed that you meant deleting the whole `if` 
block (lines 103-108), is it correct or you mean just deleting line 103 (and 
108)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: More Jira tickets clean up

[Tutkowski, Mike]

Hi,

This one appears to have been fixed a long time ago. I marked it as Fixed and 
closed the ticket.

https://issues.apache.org/jira/browse/CLOUDSTACK-1524

This one is not a big deal. I marked it as Won’t Fix and closed the ticket.

https://issues.apache.org/jira/browse/CLOUDSTACK-1432

I went through all the listed tickets and did not see any others with me listed 
as either the Assignee or Reporter.

Thanks!
Mike

On 3/8/17, 12:15 AM, "Daan Hoogland"  wrote:

Good hard work again Rafael,

I’ll try to find time today to browse through them.

On 07/03/17 18:05, "Rafael Weingärtner"  wrote:

Hi folks,
Today I had gone through another batch of old Jira tickets and we have a
bunch that can be closed again. The following are the ones I have gone
through. Before I close any ticket I would like to check them with you,
especially the ones from a category called “Seemed fixed, but I would 
like
to hear some feedback here”. I will be waiting for your feedback before 
I
proceed to close any ticket.

- Jira tickets that have PRs and were already merged, or at least a 
commit
hash code reference
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9509
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9634
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9540
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9635
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9598
-- https://issues.apache.org/jira/browse/CLOUDSTACK-212
-- https://issues.apache.org/jira/browse/CLOUDSTACK-350
-- https://issues.apache.org/jira/browse/CLOUDSTACK-535
-- https://issues.apache.org/jira/browse/CLOUDSTACK-698
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3054
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7633
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7405
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8976

- Jira ticket linked to a PR that is linked to a series of Jira tickets
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9533 (was this 
solved?)

- Seemed fixed, but I would like to hear some feedback here
-- https://issues.apache.org/jira/browse/CLOUDSTACK-245
-- https://issues.apache.org/jira/browse/CLOUDSTACK-272
-- https://issues.apache.org/jira/browse/CLOUDSTACK-371
-- https://issues.apache.org/jira/browse/CLOUDSTACK-429
-- https://issues.apache.org/jira/browse/CLOUDSTACK-438
-- https://issues.apache.org/jira/browse/CLOUDSTACK-458
-- https://issues.apache.org/jira/browse/CLOUDSTACK-486
-- https://issues.apache.org/jira/browse/CLOUDSTACK-506
-- https://issues.apache.org/jira/browse/CLOUDSTACK-561
-- https://issues.apache.org/jira/browse/CLOUDSTACK-582
-- https://issues.apache.org/jira/browse/CLOUDSTACK-626
-- https://issues.apache.org/jira/browse/CLOUDSTACK-692
-- https://issues.apache.org/jira/browse/CLOUDSTACK-696
-- https://issues.apache.org/jira/browse/CLOUDSTACK-994
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1036
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1306
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5650
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5642
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4870 (naming
conventions on Marvin?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4759 (thoughts here
Daan?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4523
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4365
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4232
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3896
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3477
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3012
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1524 (Mike 
Tutkowski,
is this still happenings? Is it possible for you to check?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1432 (Mike, any
thoughts here?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7379 (title=200MB 
limit
setting too low for network.throttling.rate and 
vm.network.throttling.rate;
isn`t it a question for the operator/administrator to configure the 
default
value?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7167
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7142 (let's open
tickets for specific issues and not for a broad class; then, the 
management
(for us) becomes easier)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7067 (questions 
should
be directed to the 

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill 
first_i_p in json -> firstIP in java. This is formatted by google.gson
it is defined in api/src/com/cloud/agent/api/to/IpAddressTO.java, and used 
in server/src/com/cloud/network/router/CommandSetupHelper.java

so, the issue might be caused by commit 
baac747089ef48ea6627a6aacf27156222862352
not sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Does anyone know what `first_i_p` represents in the `ips.json` dbag?  I am 
assuming it is the Source NAT IP, but I can't find it represented anywhere in 
the code (other than in a test).  If it does represent the Source NAT, then we 
can use it to maintain the order and keep the Source NAT IP as the primary IP 
on the Nic.  That was the bug I was trying to fix in my #1741  PR.

Example with: 1) source nat  2) port forwarding  3) static nat  4) load 
balancer
```
"eth2": [
{
"add": true, 
"broadcast": "192.168.80.255", 
"cidr": "192.168.80.8/24", 
"device": "eth2", 
"first_i_p": true, 
"gateway": "192.168.80.5", 
"netmask": "255.255.255.0", 
"network": "192.168.80.0/24", 
"new_nic": false, 
"nic_dev_id": 2, 
"nw_type": "public", 
"one_to_one_nat": false, 
"public_ip": "192.168.80.8", 
"size": "24", 
"source_nat": true, 
"vif_mac_address": "06:00:44:00:00:23"
}, 
{
"add": true, 
"broadcast": "192.168.80.255", 
"cidr": "192.168.80.9/24", 
"device": "eth2", 
"first_i_p": false, 
"gateway": "192.168.80.5", 
"netmask": "255.255.255.0", 
"network": "192.168.80.0/24", 
"new_nic": false, 
"nic_dev_id": 2, 
"nw_type": "public", 
"one_to_one_nat": false, 
"public_ip": "192.168.80.9", 
"size": "24", 
"source_nat": false, 
"vif_mac_address": "06:34:d1:00:00:23"
}, 
{
"add": true, 
"broadcast": "192.168.80.255", 
"cidr": "192.168.80.10/24", 
"device": "eth2", 
"first_i_p": false, 
"gateway": "192.168.80.5", 
"netmask": "255.255.255.0", 
"network": "192.168.80.0/24", 
"new_nic": false, 
"nic_dev_id": 2, 
"nw_type": "public", 
"one_to_one_nat": true, 
"public_ip": "192.168.80.10", 
"size": "24", 
"source_nat": false, 
"vif_mac_address": "06:34:d1:00:00:23"
}, 
{
"add": true, 
"broadcast": "192.168.80.255", 
"cidr": "192.168.80.11/24", 
"device": "eth2", 
"first_i_p": false, 
"gateway": "192.168.80.5", 
"netmask": "255.255.255.0", 
"network": "192.168.80.0/24", 
"new_nic": false, 
"nic_dev_id": 2, 
"nw_type": "public", 
"one_to_one_nat": false, 
"public_ip": "192.168.80.11", 
"size": "24", 
"source_nat": false, 
"vif_mac_address": "06:34:d1:00:00:23"
}
], 
```
@ustcweizhou @murali-reddy @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106001103
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

I mistyped the lines in my last sentence, it should have been 110-112.
Will it be loaded with a bigger batch size? From my reading, even without 
the `if ` at line 103, if `stIds.length` is smaller than the batch size, the 
`while` is not executed (not even once). Then, the flow proceeds the same as if 
the `if` had been executed. Then, at line 111 the `batch_size` is calculated 
using `stIds.length - curr_index`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Not able to setup source-nat for a regular router yet

[Gabriel Beims Bräscher]

As far as I know, the log exists for a long time. However, I am not 
aware of potential issues.


Hope that someone can share his/her wisdom on this one.


Cheers, Gabriel.


Em 15/03/2017 13:10, Jeff Hair escreveu:

It's coming from the config scripts on the routers, yes. This is version
4.9.2.0 (it's a fork, but should be similar enough to vanilla). I'm not
necessarily noticing problems with it. Connectivity from public IPs on
Isolated networks seem to be working. I'm just wondering what this message
means, and if it can cause problems.

Jeff

On Wed, Mar 15, 2017 at 4:07 PM, Gabriel Beims Bräscher <
gabr...@autonomiccs.com.br> wrote:


Hi Jeff,

Could you please provide more details (e.g. CloudStack version, CloudStack
management log)?
Seems that the log came from [1]. I will check on it.

[1] https://github.com/apache/cloudstack/blob/master/systemvm/
patches/debian/config/opt/cloud/bin/cs/CsAddress.py

Cheers,
Gabriel.


Em 15/03/2017 07:21, Jeff Hair escreveu:


Hi,

I'm seeing this message in the logs when detaching IPs with
disableStaticNat. This is on a network without redundant routers. What
exactly dose "Not able to setup source-nat for a regular router yet" mean?
Does this cause functionality problems for non-redundant routers?

Jeff

Re: Not able to setup source-nat for a regular router yet

[Jeff Hair]

It's coming from the config scripts on the routers, yes. This is version
4.9.2.0 (it's a fork, but should be similar enough to vanilla). I'm not
necessarily noticing problems with it. Connectivity from public IPs on
Isolated networks seem to be working. I'm just wondering what this message
means, and if it can cause problems.

Jeff

On Wed, Mar 15, 2017 at 4:07 PM, Gabriel Beims Bräscher <
gabr...@autonomiccs.com.br> wrote:

> Hi Jeff,
>
> Could you please provide more details (e.g. CloudStack version, CloudStack
> management log)?
> Seems that the log came from [1]. I will check on it.
>
> [1] https://github.com/apache/cloudstack/blob/master/systemvm/
> patches/debian/config/opt/cloud/bin/cs/CsAddress.py
>
> Cheers,
> Gabriel.
>
>
> Em 15/03/2017 07:21, Jeff Hair escreveu:
>
>> Hi,
>>
>> I'm seeing this message in the logs when detaching IPs with
>> disableStaticNat. This is on a network without redundant routers. What
>> exactly dose "Not able to setup source-nat for a regular router yet" mean?
>> Does this cause functionality problems for non-redundant routers?
>>
>> Jeff
>>
>>
>

Re: Not able to setup source-nat for a regular router yet

[Gabriel Beims Bräscher]

Hi Jeff,

Could you please provide more details (e.g. CloudStack version, 
CloudStack management log)?

Seems that the log came from [1]. I will check on it.

[1] 
https://github.com/apache/cloudstack/blob/master/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py


Cheers,
Gabriel.

Em 15/03/2017 07:21, Jeff Hair escreveu:

Hi,

I'm seeing this message in the logs when detaching IPs with
disableStaticNat. This is on a network without redundant routers. What
exactly dose "Not able to setup source-nat for a regular router yet" mean?
Does this cause functionality problems for non-redundant routers?

Jeff

Re: More Jira tickets clean up

[Daan Hoogland]

sorry Rafael, I haven't taken the time to look at more then a few. Go
ahead, for my part

On Wed, Mar 15, 2017 at 4:24 PM, Rafael Weingärtner
 wrote:
> Folks,
> It has been a week. I am assuming that no one knows about these tickets.
>
> In the last years, our workflow has been improved greatly; most of the PRs
> I see have Jira ticket associated and everything seems to be getting better
> by the time; let’s not loose momentum. However, we still have some (a lot?)
> Jira tickets that seem to be left behind.
>
> In 48 ours I will close all of the tickets mentioned here. If I close
> something that should not have been closed, please pardon me ;).
>
> After this, I will proceed with a new batch of tickets. Hopefully, in some
> iterations of this process, we can get rid of these forgotten tickets.
>
> On Wed, Mar 8, 2017 at 2:15 AM, Daan Hoogland 
> wrote:
>
>> Good hard work again Rafael,
>>
>> I’ll try to find time today to browse through them.
>>
>> On 07/03/17 18:05, "Rafael Weingärtner" 
>> wrote:
>>
>> Hi folks,
>> Today I had gone through another batch of old Jira tickets and we have
>> a
>> bunch that can be closed again. The following are the ones I have gone
>> through. Before I close any ticket I would like to check them with you,
>> especially the ones from a category called “Seemed fixed, but I would
>> like
>> to hear some feedback here”. I will be waiting for your feedback
>> before I
>> proceed to close any ticket.
>>
>> - Jira tickets that have PRs and were already merged, or at least a
>> commit
>> hash code reference
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9509
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9634
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9540
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9635
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9598
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-212
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-350
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-535
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-698
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3054
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7633
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7405
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8976
>>
>> - Jira ticket linked to a PR that is linked to a series of Jira tickets
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9533 (was this
>> solved?)
>>
>> - Seemed fixed, but I would like to hear some feedback here
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-245
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-272
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-371
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-429
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-438
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-458
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-486
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-506
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-561
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-582
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-626
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-692
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-696
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-994
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1036
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1306
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5650
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5642
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4870 (naming
>> conventions on Marvin?)
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4759 (thoughts
>> here
>> Daan?)
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4523
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4365
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4232
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3896
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3477
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3012
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1524 (Mike
>> Tutkowski,
>> is this still happenings? Is it possible for you to check?)
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1432 (Mike, any
>> thoughts here?)
>> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7379 (title=200MB
>> limit
>> setting too low for network.throttling.rate and
>> vm.network.throttling.rate;
>> isn`t it a question for the operator/administrator to configure the
>> default
>> value?)
>> 

[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

[olivierlemasle]

GitHub user olivierlemasle opened a pull request:

https://github.com/apache/cloudstack/pull/2008

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be 
consistent with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was 
updated the same day to add the timezone (commit bf967eb622f) except for 
Snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Amysta/cloudstack eventDateTimeTz

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit b37ca77636feb22327d1b819657c6fd3913696fe
Author: Olivier Lemasle 
Date:   2017-03-15T15:29:44Z

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: More Jira tickets clean up

[Rafael Weingärtner]

Folks,
It has been a week. I am assuming that no one knows about these tickets.

In the last years, our workflow has been improved greatly; most of the PRs
I see have Jira ticket associated and everything seems to be getting better
by the time; let’s not loose momentum. However, we still have some (a lot?)
Jira tickets that seem to be left behind.

In 48 ours I will close all of the tickets mentioned here. If I close
something that should not have been closed, please pardon me ;).

After this, I will proceed with a new batch of tickets. Hopefully, in some
iterations of this process, we can get rid of these forgotten tickets.

On Wed, Mar 8, 2017 at 2:15 AM, Daan Hoogland 
wrote:

> Good hard work again Rafael,
>
> I’ll try to find time today to browse through them.
>
> On 07/03/17 18:05, "Rafael Weingärtner" 
> wrote:
>
> Hi folks,
> Today I had gone through another batch of old Jira tickets and we have
> a
> bunch that can be closed again. The following are the ones I have gone
> through. Before I close any ticket I would like to check them with you,
> especially the ones from a category called “Seemed fixed, but I would
> like
> to hear some feedback here”. I will be waiting for your feedback
> before I
> proceed to close any ticket.
>
> - Jira tickets that have PRs and were already merged, or at least a
> commit
> hash code reference
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9509
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9634
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9540
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9635
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9598
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-212
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-350
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-535
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-698
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3054
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7633
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7405
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8976
>
> - Jira ticket linked to a PR that is linked to a series of Jira tickets
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9533 (was this
> solved?)
>
> - Seemed fixed, but I would like to hear some feedback here
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-245
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-272
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-371
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-429
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-438
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-458
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-486
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-506
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-561
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-582
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-626
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-692
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-696
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-994
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1036
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1306
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5650
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5642
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4870 (naming
> conventions on Marvin?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4759 (thoughts
> here
> Daan?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4523
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4365
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4232
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3896
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3477
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3012
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1524 (Mike
> Tutkowski,
> is this still happenings? Is it possible for you to check?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1432 (Mike, any
> thoughts here?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7379 (title=200MB
> limit
> setting too low for network.throttling.rate and
> vm.network.throttling.rate;
> isn`t it a question for the operator/administrator to configure the
> default
> value?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7167
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7142 (let's open
> tickets for specific issues and not for a broad class; then, the
> management
> (for us) becomes easier)
> -- 

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106188366
  
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long 
dataCenterId, Long podId, Long c
 // set up a new alert
 AlertVO newAlert = new AlertVO();
 newAlert.setType(alertType.getType());
-newAlert.setSubject(subject);
+//do not have a seperate column for content.
+//appending the message to the subject for now.
+newAlert.setSubject(subject+content);
--- End diff --

I agree with you that we should not try to save the world in a single day. 
However, comments in the code for me mean nothing (comments and documentation 
are two different things). ACS has a lot of comments saying to improve this or 
that, and they just stay there for days, months and years. So, adding a comment 
like that does not bring any value to the code. My point is that this specific 
case is not a complicated one; it is only a matter of adding a column to a 
table, then a new property in a POJO, and setting the correct value in the 
newly created property.

The same way I understand that we should not try to save the planet at 
once, I also have the philosophy that we should not let to do tomorrow what can 
be done today.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106186279
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
@@ -512,7 +512,11 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 });
 HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
 
-_agentMgr.reconnect(host.getId());
+try {
+_agentMgr.reconnect(host.getId());
+} catch (Exception e ) {
--- End diff --

Got it.
I miss-looked the call for `propagateAgentEvent` method



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106185631
  
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
 
 public void pullAgentOutMaintenance(long hostId);
 
-boolean reconnect(long hostId);
+void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
--- End diff --

Are you talking in a philosophical/ideological way? Because 
`CloudRuntimeException` is a runtime exception, so the compiler will not 
complain if the code calls the method and does not handle the declared 
exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #837: CLOUDSTACK-8855 Improve Error Message for Host...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/837#discussion_r106185108
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java ---
@@ -100,17 +103,18 @@ public Long getInstanceId() {
 @Override
 public void execute() {
 try {
-Host result = _resourceService.reconnectHost(this);
-if (result != null) {
-HostResponse response = 
_responseGenerator.createHostResponse(result);
-response.setResponseName(getCommandName());
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
"Failed to reconnect host");
-}
-} catch (Exception ex) {
-s_logger.warn("Exception: ", ex);
-throw new 
ServerApiException(ApiErrorCode.RESOURCE_UNAVAILABLE_ERROR, ex.getMessage());
+Host result =_resourceService.reconnectHost(this);
--- End diff --

Great, thanks for the explanation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
Awesome! This seems a good approach to deal with the issue.
@jayakarteek and @nvazquez thanks for the effort.

@jayakarteek sorry for all of the stubbornness ;)
You really listened and discussed, and I think we reached a better solution 
here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

[GabrielBrascher]

Github user GabrielBrascher commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
Thanks for the response @anshul1886.

I am sorry, but I disagree with you. I think that it gets more stable and 
readable with less duplicated code. In my humble opinion, it is easier to 
document, test, read and debug when we have lots of small methods than few big 
methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Retirement of midonet plugin

[Jeff Hair]

Complete removal of the plugin was my solution to the problem of the jar
file's dependencies. If it's not used or maintained, then it should be
removed, in my opinion. Disabling it in the build is a good first step.

*Jeff Hair*
Technical Lead and Software Developer

Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com

On Wed, Mar 15, 2017 at 8:18 AM, Rohit Yadav 
wrote:

> +1 as others have noted
>
>
> Disable the plugin from the default build for next few releases and
> eventually deprecate/remove the plugin from the codebase. The roadmap can
> look something like:
>
> - Announce on the MLs that we're planning to do this, send a PR and get it
> accepted
>
> - During the release process RM should make this information available to
> everyone (including voting thread, would be nice to have a shortlog of
> major changes in the voting email?)
>
> - In the release notes and release announcement, note that midonet is no
> longer included in the default build and is planned to be deprecated
>
> - By end of the year, if we've no communication received deprecate and
> remove the plugin with an announcement
>
>
> I think this should be done with Midonet and any other plugins that are
> causing issues and are no longer maintained by anyway.
>
>
> Regards.
>
> 
> From: Sergey Levitskiy 
> Sent: 15 March 2017 07:00:51
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Retirement of midonet plugin
>
> I am for:
>  (i) disable the build for the plugin for the next 2 major release
> followed by
> (ii)  remove everything in ACS 4.12 if no one express regrets by then
>
>
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
nics in database seems ok, so it looks some issue in creating 
ip_associations.json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

[jayakarteek]

Github user jayakarteek commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
@rafaelweingartner  
Tried using both cpuentitlement cpu reservedCapacity but retrieved values 
from vmware are zero.

While going through docs , I saw **summary.runtime.maxCpuUsage** property 
which is max cpu that is allocated per vm, this looks accurate.

If I enable CPU cap in ACS UI , the cpu allocated returned by this property 
matches with the service offering.
If CPU cap is not enabled then cpu allocated value is determined by VMware.


So I am going with the above property using which I will calculate the CPU 
% and populate the POJO.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106138864
  
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
 }
 
 @Override
+public List listAvailableResources(Long 
accountId, Long... domains) {
--- End diff --

Please rewrite this using the standard query builder (SearchBuilder) that 
is available and used in the other methods in this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106142726
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
--- End diff --

Any reason for this check? checkForNonDedicatedResources() is anyway called 
for user and router VMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106145072
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters = 
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
 
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null, 
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly 
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
 
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
 }
-else {
-//The dedicated resource belongs to VM 

[GitHub] cloudstack issue #837: CLOUDSTACK-8855 Improve Error Message for Host Alert ...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/837
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 469
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=3
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_volumes.py

 * test_06_download_detached_volume Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106133214
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
 ---
@@ -191,7 +191,8 @@ public void 
processEvent(ObjectInDataStoreStateMachine.Event event) {
 s_logger.debug("Failed to update state:" + e.toString());
 throw new CloudRuntimeException("Failed to update state: " + 
e.toString());
 } finally {
-if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+DataObjectInStore obj = objectInStoreMgr.findObject(this, 
this.getDataStore());
+if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed && 
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --

Is there a possibility for 'obj' to be null? Can you put some comment as to 
why there is a need to check 'obj' state not in 'Destroying'?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r103894706
  
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -1181,6 +1181,17 @@ public boolean configure(String name, Map params) throws Configu
 
 @Override
 public boolean start() {
+//destroy snapshots in destroying state
+List dsnapshots = 
_snapshotDao.listAllByStatus(Snapshot.State.Destroying);
--- End diff --

Simply use snapshots instead of 'dsnapshots'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106134695
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -194,18 +194,22 @@ protected boolean deleteSnapshotChain(SnapshotInfo 
snapshot) {
 }
 }
 if (!deleted) {
-boolean r = snapshotSvr.deleteSnapshot(snapshot);
-if (r) {
-// delete snapshot in cache if there is
-List cacheSnaps = 
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
-for (SnapshotInfo cacheSnap : cacheSnaps) {
-s_logger.debug("Delete snapshot " + 
snapshot.getId() + " from image cache store: " + 
cacheSnap.getDataStore().getName());
-cacheSnap.delete();
+try {
+boolean r = snapshotSvr.deleteSnapshot(snapshot);
+if (r) {
+// delete snapshot in cache if there is
+List cacheSnaps = 
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
+for (SnapshotInfo cacheSnap : cacheSnaps) {
+s_logger.debug("Delete snapshot " + 
snapshot.getId() + " from image cache store: " + 
cacheSnap.getDataStore().getName());
+cacheSnap.delete();
+}
 }
-}
-if (!resultIsSet) {
-result = r;
-resultIsSet = true;
+if (!resultIsSet) {
+result = r;
+resultIsSet = true;
+}
+} catch (Exception e){
--- End diff --

Can you put a comment here as well as to why there is catch all so that the 
intent is clear? Also there are some minor formatting issues, please fix them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106137098
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
 }
 }
 
+//destroy snapshots in destroying state in 
snapshot_store_ref
+List  ssSnapshots = 
_snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
+for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
+try {
+
_snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(),
 DataStoreRole.Image));
--- End diff --

deleteSnapshot() is going to send an agent command to cleanup the snapshot 
from secondary, if there is any failure will cleanup be retried or the DB entry 
is simply updated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2007: CLOUDSTACK-9834: prepareTemplate API call doe...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2007

CLOUDSTACK-9834: prepareTemplate API call doesn't work well with XenServer 
& Local SR (Db_exn.Uniqueness_constraint_violation)

removed the host uuid from SR label so that any host which has access to
the SR(all the hosts in the same pool) can reuse the same SR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2007


commit 8a976d27350cec2417b596dba311628de56ed13c
Author: Rajani Karuturi 
Date:   2017-03-15T10:29:06Z

CLOUDSTACK-9834: prepareTemplate API call doesn't work well
with XenServer & Local SR (Db_exn.Uniqueness_constraint_violation)

removed the host uuid from SR label so that any host which has access to
the SR(all the hosts in the same pool) can reuse the same SR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1988
  
@ustcweizhou @sebgoa @rhtyd can you review this as a first version of an 
integrated plugin for application clusters. It is still very k8s specific and I 
want to defer making it more generic until we found real use cases for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Not able to setup source-nat for a regular router yet

[Jeff Hair]

Hi,

I'm seeing this message in the logs when detaching IPs with
disableStaticNat. This is on a network without redundant routers. What
exactly dose "Not able to setup source-nat for a regular router yet" mean?
Does this cause functionality problems for non-redundant routers?

Jeff

[GitHub] cloudstack issue #1180: CLOUDSTACK-9112: Deploy VM failing frequently due to...

[harikrishna-patnala]

Github user harikrishna-patnala commented on the issue:

https://github.com/apache/cloudstack/pull/1180
  
Added test for the case where we need to list only clusters which has hosts 
with host tag specified in the offering.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@nvazquez Thanks for testing. I'll check and update accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@karuturi ping? can this be merged as well, this greatly improves the UI 
performance for the existing metrics view feature as well as improves the load 
time of the infrastructure tab
@abhinandanprateek @DaanHoogland - would you like to review this as well, 
thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Retirement of midonet plugin

[Rohit Yadav]

+1 as others have noted


Disable the plugin from the default build for next few releases and eventually 
deprecate/remove the plugin from the codebase. The roadmap can look something 
like:

- Announce on the MLs that we're planning to do this, send a PR and get it 
accepted

- During the release process RM should make this information available to 
everyone (including voting thread, would be nice to have a shortlog of major 
changes in the voting email?)

- In the release notes and release announcement, note that midonet is no longer 
included in the default build and is planned to be deprecated

- By end of the year, if we've no communication received deprecate and remove 
the plugin with an announcement


I think this should be done with Midonet and any other plugins that are causing 
issues and are no longer maintained by anyway.


Regards.


From: Sergey Levitskiy 
Sent: 15 March 2017 07:00:51
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Retirement of midonet plugin

I am for:
 (i) disable the build for the plugin for the next 2 major release followed by
(ii)  remove everything in ACS 4.12 if no one express regrets by then




rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@ustcweizhou 
 - I was able to restart the network with cleanup. New VR came up with 
duplicated eth2 and eth3. 
![screen shot 2017-03-15 at 9 48 33 
am](https://cloud.githubusercontent.com/assets/13551960/23938354/b2cb8398-0964-11e7-8690-4cb0d635ec9c.png)


 - Not sure what you mean by what is my last commit, currently this PR has 
been built and deployed on the physical hosts. 

 - There are 3 nics in the DB for that router. 
```
*** 8. row ***
id: 8
  uuid: 9a2d5343-fbff-487e-a48d-509ae0503687
   instance_id: 4
   mac_address: 02:00:19:89:00:02
   ip4_address: 10.1.1.1
   netmask: 255.255.255.0
   gateway: NULL
   ip_type: NULL
 broadcast_uri: vlan://884
network_id: 204
  mode: Dhcp
 state: Reserved
  strategy: Start
 reserver_name: ExternalGuestNetworkGuru
reservation_id: 2f428f23-afae-4916-a423-4a7452a33138
 device_id: 0
   update_time: 2017-03-14 13:41:23
 isolation_uri: vlan://884
   ip6_address: NULL
   default_nic: 0
   vm_type: DomainRouter
   created: 2017-03-14 09:31:29
   removed: NULL
   ip6_gateway: NULL
  ip6_cidr: NULL
  secondary_ip: 0
   display_nic: 1
*** 9. row ***
id: 9
  uuid: bb36a0a5-ac45-45ac-976f-341e2d2c72be
   instance_id: 4
   mac_address: 0e:00:a9:fe:00:44
   ip4_address: 169.254.0.68
   netmask: 255.255.0.0
   gateway: 169.254.0.1
   ip_type: Ip4
 broadcast_uri: NULL
network_id: 202
  mode: Static
 state: Reserved
  strategy: Start
 reserver_name: ControlNetworkGuru
reservation_id: 2f428f23-afae-4916-a423-4a7452a33138
 device_id: 1
   update_time: 2017-03-14 13:41:23
 isolation_uri: NULL
   ip6_address: NULL
   default_nic: 0
   vm_type: DomainRouter
   created: 2017-03-14 09:31:29
   removed: NULL
   ip6_gateway: NULL
  ip6_cidr: NULL
  secondary_ip: 0
   display_nic: 1
*** 10. row ***
id: 10
  uuid: a4e7691b-b290-4bfe-905e-ddb3c5b1c466
   instance_id: 4
   mac_address: 06:bb:c8:00:00:03
   ip4_address: 10.1.35.83
   netmask: 255.255.224.0
   gateway: 10.1.63.254
   ip_type: NULL
 broadcast_uri: vlan://7
network_id: 200
  mode: Static
 state: Reserved
  strategy: Managed
 reserver_name: PublicNetworkGuru
reservation_id: NULL
 device_id: 2
   update_time: 2017-03-14 13:41:23
 isolation_uri: vlan://7
   ip6_address: NULL
   default_nic: 1
   vm_type: DomainRouter
   created: 2017-03-14 09:31:29
   removed: NULL
   ip6_gateway: NULL
  ip6_cidr: NULL
  secondary_ip: 0
   display_nic: 1
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
code LGTM
 @yvsubhash it would be nice if you can reformat part of the code with java 
code conventions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov moreover, can you please restart the network with cleanup, 
to see if the new VRs can start ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1884: CLOUDSTACK-9699: Add global setting for enabl...

[rashmidixit]

Github user rashmidixit closed the pull request at:

https://github.com/apache/cloudstack/pull/1884


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1884: CLOUDSTACK-9699: Add global setting for enable/disab...

[rashmidixit]

Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1884
  
Closing this based on the new PR  #1944.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Reg : Edit Access

[Rajani Karuturi]

you are in.

~ Rajani

http://cloudplatform.accelerite.com/

On March 14, 2017 at 7:15 PM, Pavan Kumar Aravapalli
(pavankuma...@persistent.com) wrote:

Hi,

I am unable to edit/add pages for the cwiki link
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.9+Design+Documents.
Can some one help me in doing the same.

Cwiki username: pavan4smile

Thanks & Regards
Pavan Kumar Aravapalli.

Re: [DISCUSS] Retirement of midonet plugin

[Daan Hoogland]

Disable with a maven profile to enable? mvn –P withThisOrThat

Delete but only after a time span. A number of releases is not any kind of 
promise in our case.

On 15/03/17 04:40, "Tutkowski, Mike"  wrote:

Disable, then delete works for me, too.

On 3/14/17, 7:49 PM, "Simon Weller"  wrote:

I agree with Sergey and Will. Let's disable it first.

Simon Weller/615-312-6068

-Original Message-
From: Rafael Weingärtner [rafaelweingart...@gmail.com]
Received: Tuesday, 14 Mar 2017, 9:10PM
To: dev@cloudstack.apache.org [dev@cloudstack.apache.org]
Subject: [DISCUSS] Retirement of midonet plugin

Dear ACS fellows,
Recently there have been two threads asking and discussing the “midonet”
integration with Apache CloudStack (ACS) [1-2].

After quite some discussions, we noticed that despite having some people
willing to use it, the plugin has never been fully developed by its 
vendor
(Midokura). Further, nobody else has put the effort on fully testing and
finishing its implementation. It seems that the plugin was incorporated
into our code base without being fully finished. Moreover, I have asked
around at the Midonet community, and the java client they use has 
changed
quite a bit from the one we use.

It begs the question, if it does not work, why do we advertise such
integration? [3]. In my opinion, it would be great if we had such
integration; however, we as a community of individuals cannot bear the
burden with the cost of such task by ourselves.

It seems we have three options; (i) disable the build for the plugin and
let the code create its own mystic throughout time in ACS code base; 
(ii)
remove everything; or (iii) someone that may benefit from this plugin 
jumps
in and concludes the integration with Midonet using their new client.

There maybe other solutions that I am not seeing. So, @Devs yours 
thoughts
and comments are welcome ;)

[1]

http://cloudstack.markmail.org/thread/qyedle5jb2c34gsc#query:+page:1+mid:xn2zq2v3eim5vl2q+state:results
[2]

http://cloudstack.markmail.org/message/rewzk4v7dgzpsxkm?q=midonet+order:date-backward=1#query:midonet%20order%3Adate-backward+page:1+mid:i563khxlginf6smg+state:results
[3] http://docs.cloudstack.apache.org/en/latest/networking/midonet.html


--
Rafael Weingärtner





daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack pull request #2006: CLOUDSTACK-9833: Move configuration parameter...

[harikrishna-patnala]

GitHub user harikrishna-patnala opened a pull request:

https://github.com/apache/cloudstack/pull/2006

CLOUDSTACK-9833: Move configuration parameters from Config.java to use 
configdepot

Following parameters are moved from config.java to configdepot.
This will make the management of configuration parameter easy during 
upgrade and avoid inconsistency of values of parameters for fresh setup and 
upgraded setup.

snapshot.max.hourly
snapshot.max.daily
snapshot.max.weekly
snapshot.max.monthly
enable.secure.session.cookie
json.content.type

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9833

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2006


commit abea001c881e95c7922767aa5f476ab9135b4939
Author: Harikrishna Patnala 
Date:   2017-03-14T09:23:11Z

CLOUDSTACK-9833: Move configuration parameters from Config.java to use 
ConfigDepot
Following parameters are moved to configdepot.
snapshot.max.hourly
snapshot.max.daily
snapshot.max.weekly
snapshot.max.monthly
enable.secure.session.cookie
json.content.type




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---