[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
thank you sir.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-594


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
not sure about the CI tests @swill, I think the easiest way to kick Travis 
tests is the close/reopen the PR.
I'll pick it up as soon as possible. I'll rebuild and run the smoketests. 
@blueorangutan package



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2010: VPC Inline LB - CLOUDSTACK-9282

2017-03-17 Thread urvis
GitHub user urvis opened a pull request:

https://github.com/apache/cloudstack/pull/2010

VPC Inline LB - CLOUDSTACK-9282

BUG-ID: CLOUDSTACK-9282
Design-Doc: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61340894

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nuagenetworks/cloudstack feature/vpc_inline_lb

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2010


commit 5cadc414e6043eac2035ce9cf670c806bbb37ec2
Author: Urvi Shah 
Date:   2016-05-27T12:16:54Z

VPC Inline LB

BUG-ID: CLOUDSTACK-9282
Design-Doc: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61340894




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov alright, this is ready for you to start testing.  Can you 
kick off CI on this as well?

I will be doing testing of this locally as well.  

This implementation is very similar to how it was implemented before my 
original change.  See: 
https://github.com/apache/cloudstack/pull/1741/files#diff-a7d6f7150cca74029f23c19b72ad0622L19

The only change from the original was that if the IP is a `source_nat` IP 
and there are already IPs associated with that dev, it will `prepend` instead 
of `append` so the source nat ip is set as the primary ip on the nic (required 
for VPN).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-17 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@karuturi I added marvin tests to simulate tests performed by 
@mike-tutkowski.

This are results in our env:

[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//011CTF/results.txt
Test primary storage pools - XEN. Not Supported for kvm,hyperv,vmware ... 
SKIP: iscsi primary storage not supported on kvm, VMWare, Hyper-V, or LXC
Test primary storage pools - XEN, KVM, VMWare. Not Supported for hyperv ... 
=== TestName: test_01_primary_storage_nfs | Status : SUCCESS ===
ok
Test Deploy VMS using different Service Offerings with Storage Tags ... === 
TestName: test_01_deploy_vms_storage_tags | Status : SUCCESS ===
ok
Test edit Storage Tags ... === TestName: test_02_edit_primary_storage_tags 
| Status : SUCCESS ===
ok
Test Volume migration options for Storage Pools with different Storage Tags 
... SKIP: Skipping test as it is not running on simulator

--
Ran 5 tests in 295.996s

OK (SKIP=2)


@rafaelweingartner @mike-tutkowski @karuturi can you please review marvin 
tests added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Marco Sinhoreli
Congratulation and welcome aboard Wei and Rene! 

 

Marco Sinhoreli
Managing Consultant
marco.sinhor...@shapeblue.com
mobile: +55 21 98276 3636
 
Praia de Botafogo 501, bloco 1 - sala 101 – Botafogo
Rio de Janeiro, RJ - Brazil - CEP 22250-040
office: + 55 21 2586 6390 | fax: +55 21 2586 6002
http://www.shapeblue.com/ | twitter: @shapeblue

Em 17/03/17 04:06, "Daan Hoogland"  escreveu:

dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks 
to join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 





[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-17 Thread nvazquez
Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1994#discussion_r106724343
  
--- Diff: 
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
 txn.commit();
 }
 
+@Override
+public List searchByIds(Long... stIds) {
+final int detailsBatchSize = getDetailsBatchSize();
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
--- End diff --

Done! Thanks a lot @rafaelweingartner!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Thanks @remibergsma.  I am going to use `source_nat` as it better 
represents what it is I am trying to establish and it seems to always be in the 
object where `first_i_p` does not always seem to be present (look at 
@borisstoyanov's output above for example).

@borisstoyanov I will work on getting you the new implementation today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread remibergsma
Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill FYI if you look for `first_i_p` as seen in the json on the Python 
side, then on the Java side it's called `firstIP`, as the gson lib replaces 
every capital with an underscore and then the lowercase letter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Tutkowski, Mike
Congratulations!

> On Mar 17, 2017, at 8:57 AM, Rafael Weingärtner  
> wrote:
> 
> Congratulation guys!!
> You deserved it for your great contributions.
> 
> Let’s keep the pace making ACS better every single PR ;)
> 
>> On Fri, Mar 17, 2017 at 9:35 AM, Simon Weller  wrote:
>> 
>> Congrats Rene and Wei!
>> 
>> 
>> From: Daan Hoogland 
>> Sent: Friday, March 17, 2017 2:06 AM
>> To: dev@cloudstack.apache.org
>> Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members
>> 
>> dear devs,
>> 
>> The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks
>> to join their ranks. Both have accepted. Please join me in congratulating
>> both, thanking them for their contributions so far and encouraging them to
>> show their best for Apache CloudStack ;) \o/ ...
>> 
>> regards,
>> 
>> 
>> daan.hoogl...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>> 
>> 
>> 
>> 
> 
> 
> -- 
> Rafael Weingärtner


Re: More Jira tickets clean up

2017-03-17 Thread Rafael Weingärtner
Thanks, Mike for the feedback.
No problem Daan ;)

Tickets closed; depending on tickets, some I marked as closed, others as
resolved. I also configured the status of some to invalid, others to
incomplete, and others as fixed and so on.



On Wed, Mar 15, 2017 at 6:38 PM, Tutkowski, Mike 
wrote:

> Hi,
>
> This one appears to have been fixed a long time ago. I marked it as Fixed
> and closed the ticket.
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1524
>
> This one is not a big deal. I marked it as Won’t Fix and closed the ticket.
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1432
>
> I went through all the listed tickets and did not see any others with me
> listed as either the Assignee or Reporter.
>
> Thanks!
> Mike
>
> On 3/8/17, 12:15 AM, "Daan Hoogland"  wrote:
>
> Good hard work again Rafael,
>
> I’ll try to find time today to browse through them.
>
> On 07/03/17 18:05, "Rafael Weingärtner" 
> wrote:
>
> Hi folks,
> Today I had gone through another batch of old Jira tickets and we
> have a
> bunch that can be closed again. The following are the ones I have
> gone
> through. Before I close any ticket I would like to check them with
> you,
> especially the ones from a category called “Seemed fixed, but I
> would like
> to hear some feedback here”. I will be waiting for your feedback
> before I
> proceed to close any ticket.
>
> - Jira tickets that have PRs and were already merged, or at least
> a commit
> hash code reference
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9509
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9634
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9540
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9635
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9598
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-212
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-350
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-535
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-698
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3054
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7633
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7405
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8976
>
> - Jira ticket linked to a PR that is linked to a series of Jira
> tickets
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9533 (was
> this solved?)
>
> - Seemed fixed, but I would like to hear some feedback here
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-245
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-272
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-371
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-429
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-438
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-458
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-486
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-506
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-561
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-582
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-626
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-692
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-696
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-994
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1036
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1306
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5650
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5642
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4870 (naming
> conventions on Marvin?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4759
> (thoughts here
> Daan?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4523
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4365
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4232
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3896
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3477
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3012
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1524 (Mike
> Tutkowski,
> is this still happenings? Is it possible for you to check?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1432 (Mike,
> any
> thoughts here?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7379
> (title=200MB limit
> setting too low for network.throttling.rate and
> vm.network.throttling.rate;
>  

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov could you please test with my suggestion? I think it should 
fix the duplicated nics in VR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

2017-03-17 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1867
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 471
 Hypervisor xenserver
 NetworkType Advanced
 Passed=148
 Failed=17
 Skipped=10

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_vpc_vpn.py

 * test_01_redundant_vpc_site2site_vpn Failing since 2 runs

 * test_01_vpc_site2site_vpn Failing since 2 runs

* test_snapshots.py

 * test_02_list_snapshots_with_removed_data_store Failed

 * test_02_list_snapshots_with_removed_data_store Failing since 2 runs

* test_outofbandmanagement.py

 * test_oobm_background_powerstate_sync Failed

 * test_oobm_enabledisable_across_clusterzones Failed

 * test_oobm_issue_power_cycle Failed

 * test_oobm_issue_power_off Failed

 * test_oobm_issue_power_on Failed

 * test_oobm_issue_power_reset Failed

 * test_oobm_issue_power_soft Failed

 * test_oobm_issue_power_status Failed

 * test_oobm_multiple_mgmt_server_ownership Failed

 * test_oobm_zchange_password Failed

* test_volumes.py

 * ContextSuite context=TestCreateVolume>:setup Failing since 13 runs

* test_internal_lb.py

 * ContextSuite context=TestInternalLb>:setup Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 
2 runs


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_01_primary_storage_iscsi
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_router_nics.py
test_over_provisioning.py
test_global_settings.py
test_guest_vlan_range.py
test_scale_vm.py
test_service_offerings.py
test_router_dhcphosts.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_password_server.py
test_dynamicroles.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

2017-03-17 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106675353
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

ok, in that perspect you have a point absolutely. The sentence would need 
to be rephrased, then. It now spells "example: http://...;!
Ive been going through the, code reviewing every occurrence of 
cloud.com, back in june!!! just before leaving the project to do some paid 
work ;) (hope my boss is alright with this remark)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Will Stevens
Congrats. Both well deserved. :)

On Mar 17, 2017 9:36 AM, "Simon Weller"  wrote:

> Congrats Rene and Wei!
>
> 
> From: Daan Hoogland 
> Sent: Friday, March 17, 2017 2:06 AM
> To: dev@cloudstack.apache.org
> Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members
>
> dear devs,
>
> The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks
> to join their ranks. Both have accepted. Please join me in congratulating
> both, thanking them for their contributions so far and encouraging them to
> show their best for Apache CloudStack ;) \o/ ...
>
> regards,
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-17 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@karuturi I rebased on latest master, is anything else expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Nicolas Vazquez
Congratulations Wei and Rene!

2017-03-17 11:56 GMT-03:00 Rafael Weingärtner :

> Congratulation guys!!
> You deserved it for your great contributions.
>
> Let’s keep the pace making ACS better every single PR ;)
>
> On Fri, Mar 17, 2017 at 9:35 AM, Simon Weller  wrote:
>
> > Congrats Rene and Wei!
> >
> > 
> > From: Daan Hoogland 
> > Sent: Friday, March 17, 2017 2:06 AM
> > To: dev@cloudstack.apache.org
> > Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members
> >
> > dear devs,
> >
> > The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks
> > to join their ranks. Both have accepted. Please join me in congratulating
> > both, thanking them for their contributions so far and encouraging them
> to
> > show their best for Apache CloudStack ;) \o/ ...
> >
> > regards,
> >
> >
> > daan.hoogl...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> Rafael Weingärtner
>


[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

2017-03-17 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106670299
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

I agree that it is out of the scope. I just wanted to ask about the idea of 
starting using notations instead of real URLs as examples.

To tell you the truth I have already seen so many time people not thinking 
while seeing examples like this and using a copy/paste working mode that I try 
to avoid it sometimes, just to force people to change the parameters.

It is nothing that you need to change, I just so it, and I wanted to check 
your opinion ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: Fix datetime format of snapshots events

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: Fix datetime format of snapshots events

2017-03-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: Fix datetime format of snapshots events

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-593


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Rafael Weingärtner
Congratulation guys!!
You deserved it for your great contributions.

Let’s keep the pace making ACS better every single PR ;)

On Fri, Mar 17, 2017 at 9:35 AM, Simon Weller  wrote:

> Congrats Rene and Wei!
>
> 
> From: Daan Hoogland 
> Sent: Friday, March 17, 2017 2:06 AM
> To: dev@cloudstack.apache.org
> Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members
>
> dear devs,
>
> The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks
> to join their ranks. Both have accepted. Please join me in congratulating
> both, thanking them for their contributions so far and encouraging them to
> show their best for Apache CloudStack ;) \o/ ...
>
> regards,
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner


[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...

2017-03-17 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1582#discussion_r106667548
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
 @Parameter(name = ApiConstants.CS_URL,
type = CommandType.STRING,
description = "the API URL including port of the CloudStack 
Management Server example: http://server.cloud.com:8080/client/api?;)
+// leaving cloud.com reference above as it serves only as an example
--- End diff --

I don't see you point Rafael. it would no longer be an example bu a semi 
formal definition.

Also I think it is out of scope to be frank


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: Fix datetime format of snapshots events

2017-03-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: Fix datetime format of snapshots events

2017-03-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
Thanks for this PR @olivierlemasle, could you please add a jira id for this 
change and rename the PR to [JIRA-ID]: Fix datetime ... same as the others
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Hi @swill, could you please let us know when do you expect to address the 
changes you have mentioned, so I could schedule the testing accordingly. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Simon Weller
Congrats Rene and Wei!


From: Daan Hoogland 
Sent: Friday, March 17, 2017 2:06 AM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue





[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-17 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
Hi @karuturi, I've been working on marvin tests, I hope posting them today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1867
  
@koushik-das Failing tests doesn't seems to be related to this patch. 
Rebased against latest master to trigger the build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1853: CLOUDSTACK-9696: Fixed Virtual Router deployment fai...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1853
  
@koushik-das Made the changes as per review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106632802
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters = 
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
 
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null, 
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly 
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
 
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
 }
-else {
-//The dedicated resource belongs to VM 

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106632584
  
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
 }
 
 @Override
+public List listAvailableResources(Long 
accountId, Long... domains) {
--- End diff --

@koushik-das Made the changes using SearchBuilder class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-03-17 Thread sudhansu7
Github user sudhansu7 commented on the issue:

https://github.com/apache/cloudstack/pull/1797
  
@pdion891 removed broadcasturi from api response. Also added marvin test .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-17 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@rajesh-battala I won't accept this PR, sorry to share this but the number 
of commits are simply outrageous.

From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty 
messed-up and it becomes far too difficult to track changes, backport/up-port 
commits/fixes/feature. There have been big PR/features that have been accepted 
and merged with very few overall squashed commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-17 Thread rajesh-battala
Github user rajesh-battala commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Current commits are in the order of some milestones.
As @nitin-maharan told if we squash them into one commit we loose
contributions of induviduals.


On Thu, Mar 16, 2017 at 7:09 PM, Rohit Yadav 
wrote:

> @nitin-maharana  it becomes easier to
> triage changes when changes are confined to a limited number of commits
> (ideally one per PR), please squash the commits based on the author (if 
not
> to a single commit) if you don't agree. Ideally, you can also group/squash
> commits based on the component/framework/architecture.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



-- 
Thanks
Rajesh Battala



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

2017-03-17 Thread olivierlemasle
Github user olivierlemasle closed the pull request at:

https://github.com/apache/cloudstack/pull/2008


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

2017-03-17 Thread olivierlemasle
GitHub user olivierlemasle reopened a pull request:

https://github.com/apache/cloudstack/pull/2008

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be 
consistent with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was 
updated the same day to add the timezone (commit bf967eb622f) except for 
Snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Amysta/cloudstack eventDateTimeTz

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit b37ca77636feb22327d1b819657c6fd3913696fe
Author: Olivier Lemasle 
Date:   2017-03-15T15:29:44Z

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Welcoming Wido as the new ACS VP

2017-03-17 Thread Rene Moser
Thanks Will for all the efforts!

Congrats Wido and I have no doubts you keep up the good work ;)

-Rene


Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Raja Pullela
congratulations Rene and Wei!! 

cheers!
Raja Pullela
Engineering Team,
Accelerite, www.accelerite.com, 
2055 Laurelwood Road,
Santa Clara, CA, 95054

On 3/17/17, 12:36 PM, "Daan Hoogland"  wrote:

dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


Re: Welcoming Wido as the new ACS VP

2017-03-17 Thread Daan Hoogland
Thanks to both of you great Ws. Have a good retirement Will! Good luck in your 
new capacity Wido!

On 17/03/17 08:32, "Paul Angus"  wrote:

Thanks Will for all the great work. And congratulations Wido - good luck.



Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Raja Pullela [mailto:raja.pull...@accelerite.com] 
Sent: 17 March 2017 02:59
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Re: Welcoming Wido as the new ACS VP

Thank you Will for all the great work!  

cheers!
Raja Pullela
Engineering Team,
Accelerite, 2055 Laurelwood Road,
Santa Clara, CA, 95054

On 3/16/17, 10:30 PM, "Will Stevens"  wrote:

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role 
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to 
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has a 
long history with the project and we are happy welcome him into this new role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly 
over many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is 
the property of Accelerite, a Persistent Systems business. It is intended only 
for the use of the individual or entity to which it is addressed. If you are 
not the intended recipient, you are not authorized to read, retain, copy, 
print, distribute or use this message. If you have received this communication 
in error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-17 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2009
  
@rhtyd Can you review the fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-17 Thread karuturi
GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2009

CLOUDSTACK-9369 Fixed Ldap regression

Ldap auto creation of accounts is broken due to the security fix for
CLOUDSTACK-9369.
There was an explicit check to not allow login incase the
user doesnt exist.  removed the same.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2009


commit e2efebadaa9d7e7ec7be3f9638f48c7b97394f5e
Author: Rajani Karuturi 
Date:   2017-02-09T18:43:13Z

Bug-ID:CLOUDSTACK-9369 Fixed Ldap regression

Ldap auto creation of accounts is broken due to the security fix for
CLOUDSTACK-9369.
There was an explicit check to not allow login incase the
user doesnt exist.  removed the same.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-17 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
sorry @karuturi should I update? This is really not on my radar that much 
anymore. I will look at it this afternoon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: Welcoming Wido as the new ACS VP

2017-03-17 Thread Paul Angus
Thanks Will for all the great work. And congratulations Wido - good luck.



Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Raja Pullela [mailto:raja.pull...@accelerite.com] 
Sent: 17 March 2017 02:59
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Re: Welcoming Wido as the new ACS VP

Thank you Will for all the great work!  

cheers!
Raja Pullela
Engineering Team,
Accelerite, 2055 Laurelwood Road,
Santa Clara, CA, 95054

On 3/16/17, 10:30 PM, "Will Stevens"  wrote:

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role and 
have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to 
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has a 
long history with the project and we are happy welcome him into this new role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly over 
many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


RE: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Paul Angus
Congratulations Rene and Wei.

You're great supporters of the CloudStack cause, it's well deserved. 



Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: 17 March 2017 07:06
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
  
 



Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Boris Stoyanov
Congrats Rene and Wei!!! 
Well deserved. 

Thanks,
Boris Stoyanov

boris.stoya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On Mar 17, 2017, at 9:06 AM, Daan Hoogland  
> wrote:
> 
> dear devs,
> 
> The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
> join their ranks. Both have accepted. Please join me in congratulating both, 
> thanking them for their contributions so far and encouraging them to show 
> their best for Apache CloudStack ;) \o/ ...
> 
> regards,
> 
> 
> daan.hoogl...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
> 
> 
> 



[GitHub] cloudstack issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached ...

2017-03-17 Thread mrunalinikankariya
Github user mrunalinikankariya commented on the issue:

https://github.com/apache/cloudstack/pull/1911
  

[ConcurrentSnapshots.docx](https://github.com/apache/cloudstack/files/849895/ConcurrentSnapshots.docx)
 
Attached file contains screenshot of the database quesry and the concurrent 
snapshot created using manual testing as well as marvin script


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Welcoming Wido as the new ACS VP

2017-03-17 Thread Rohit Yadav
Congrats Wido!


Thanks Will for your effort and work.


Regards.


From: Will Stevens 
Sent: 16 March 2017 22:30:02
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Welcoming Wido as the new ACS VP

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
a long history with the project and we are happy welcome him into this new
role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly
over many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



Re: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Rohit Yadav
Congratulations Rene and Wei! Well deserved.


Regards.


From: Daan Hoogland 
Sent: 17 March 2017 12:36:14
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-17 Thread anshul1886
GitHub user anshul1886 reopened a pull request:

https://github.com/apache/cloudstack/pull/1867

CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre…

…ad if they are failed to cleanup during DeleteSnapshot command

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1867


commit e9245d3ac1a888505e9d2c1e05841791e29c51ec
Author: Anshul Gangwar 
Date:   2016-05-09T07:15:31Z

CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thread if 
they are failed to cleanup during DeleteSnapshot command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-17 Thread anshul1886
Github user anshul1886 closed the pull request at:

https://github.com/apache/cloudstack/pull/1867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

2017-03-17 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1867
  
Code changes LGTM
@anshul1886 Please check on travis failure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[ANNOUNCE] Wei Zhou and Rene Moser are now PMC members

2017-03-17 Thread Daan Hoogland
dear devs,

The PMC has invited Rene Moser and Wei Zhou over the last couple of weeks to 
join their ranks. Both have accepted. Please join me in congratulating both, 
thanking them for their contributions so far and encouraging them to show their 
best for Apache CloudStack ;) \o/ ...

regards,


daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-03-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106589966
  
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
 }
 
 @Override
+public List listAvailableResources(Long 
accountId, Long... domains) {
--- End diff --

@anshul1886 Check out SearchBuilder class, it has methods like or(), op(), 
cp() which can be used to construct the query. Also the same field can be used 
in multiple places, search for reference to or(), op() etc. elsewhere in the 
code and you will find how to use them. One such place is QueryManagerImpl.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106590720
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters = 
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
 
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null, 
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly 
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
 
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
 }
-else {
-//The dedicated resource belongs to VM 

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread koushik-das
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106591079
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
--- End diff --

@anshul1886 Got it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---