Just a thanks for the help

2017-03-20 Thread Jeromy Grimmett
Props to everyone for the help over the months and years, a little article I 
wrote on LinkedIn.  Feel free to share as you wish:

https://www.linkedin.com/pulse/underdog-cloud-computing-world-jeromy-grimmett

I'm looking forward to working with you all more.

Regards,
j

Jeromy Grimmett
[cb-sig-logo2]
155 Fleet Street
Portsmouth, NH 03801
Direct: 603.766.3625
Office: 603.766.4908
Fax: 603.766.4729
jer...@cloudbrix.com
www.cloudbrix.com



Re: Survey “Building an autonomic cloud for you”

2017-03-20 Thread Lucas Berri Cristofolini
Dear CloudStack community,

I'd like to thank those of you who've answered the survey so far.
However, we need more data; the questionnaire should take no more than 3
minutes to fill out and is available here: https://goo.gl/forms/vvu0665Ff
Kujn6gP2.  All of the answers are confidential (no company will be
identified in none of our analysis). These data are crucial to focus our
development efforts on features that attend your needs.


To give you a taste of what our platform can do, our agents can,
autonomously, execute virtual machines balancing or consolidation of your
cloud system. For instance, according to our experiments, it is possible to
save up to 30% of energy when a consolidation management model is applied
constantly in a cloud. Also, if you want to know about our virtual machines
balancing experiments, do not hesitate to contact us!


Thanks for your time!
Lucas

On Fri, Mar 10, 2017 at 2:03 PM, Gabriel Beims Bräscher <
gabrasc...@gmail.com> wrote:

> Dear Apache CloudStack community,
>
>
> Without wishing to take the liberty, I would like to ask a bit of your
> precious time to answer a survey. This survey will help us to provide an
> autonomic cloud for you.
>
> Autonomiccs is a Brazilian Startup committed to build solutions that
> autonomically manage and optimize cloud computing infrastructures created
> with Apache CloudStack. Some of you may have seen a bit of our work at
> ApacheCon Europe 2016. We hope to work alongside the Apache CloudStack
> community, leveraging Apache CloudStack to the next level on cloud
> computing orchestration.
>
> We are working hard to understand the needs of CloudStack users. This
> survey can help us to provide Apache CloudStack users with the cloud they
> need, delivering a competitive advantage for the Apache CloudStack
> ecosystem.
>
> If all goes right, we will present the collected data at the CloudStack
> Collaboration Conference in Miami, within the “*Building an Autonomic
> CloudStack*” presentation.
>
>
> Survey link:
> https://docs.google.com/forms/d/e/1FAIpQLSfBhG1KNo_N_nwOBt_18GbHK56_
> DTch1aEMkv4wAJnTDpE2ow/viewform
>
>
> Thanks in advance for your time,
>
> Gabriel.
>


[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-20 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@nvazquez Looks like Travis cant SSH into management server during the test 
.

2017-03-17 19:26:58,672 - DEBUG - mount -t nfs 
nfs:/export/automation/1/testprimary 
/mnt/marvin-1b4190cb-b9f5-4441-9bdc-bd89e9b7567b
2017-03-17 19:27:13,468 - CRITICAL - EXCEPTION: 
test_03_migration_options_storage_tags: ['Traceback (most recent call 
last):\n', '  File "/opt/python/2.7.12/lib/python2.7/unittest/case.py", line 
329, in run\ntestMethod()\n', '  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py",
 line 30, in test_wrapper\nreturn test(self, *args, **kwargs)\n', '  File 
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_primary_storage.py",
 line 559, in test_03_migration_options_storage_tags\n
log_lvl=logging.INFO\n', '  File 
"/home/travis/.local/lib/python2.7/site-packages/marvin/sshClient.py", line 81, 
in __init__\nraise internalError("SSH Connection Failed")\n', 
'internalError: SSH Connection Failed\n']


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
Trillian test result (tid-959)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33646 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1582-t959-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 300.25 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 144.74 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.16 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 235.44 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 284.14 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 488.00 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 505.37 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1432.64 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 528.49 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 743.93 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1264.70 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.41 | test_volumes.py
test_08_resize_volume | Success | 156.36 | test_volumes.py
test_07_resize_fail | Success | 161.42 | test_volumes.py
test_06_download_detached_volume | Success | 156.29 | test_volumes.py
test_05_detach_volume | Success | 155.80 | test_volumes.py
test_04_delete_attached_volume | Success | 146.13 | test_volumes.py
test_03_download_attached_volume | Success | 156.27 | test_volumes.py
test_02_attach_volume | Success | 95.39 | test_volumes.py
test_01_create_volume | Success | 711.05 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.72 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 133.68 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 267.90 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.58 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.85 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.80 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.28 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 30.37 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.22 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 30.35 | test_templates.py
test_10_destroy_cpvm | Success | 191.64 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.08 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.35 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.49 | test_ssvm.py
test_06_stop_cpvm | Success | 131.46 | test_ssvm.py
test_05_stop_ssvm | Success | 163.58 | test_ssvm.py
test_04_cpvm_internals | Success | 1.03 | test_ssvm.py
test_03_ssvm_internals | Success | 3.26 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.09 | test_snapshots.py
test_04_change_offering_small | Success | 209.65 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.07 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
test_01_sys_vm_start | Success 

[GitHub] cloudstack issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots e...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
Trillian test result (tid-961)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27589 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2008-t961-kvm-centos7.zip
Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 305.43 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 155.01 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.15 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 230.65 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 281.79 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 493.39 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 510.93 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1404.00 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 529.02 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 728.24 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1280.56 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.46 | test_volumes.py
test_08_resize_volume | Success | 156.37 | test_volumes.py
test_07_resize_fail | Success | 161.44 | test_volumes.py
test_06_download_detached_volume | Success | 151.40 | test_volumes.py
test_05_detach_volume | Success | 150.75 | test_volumes.py
test_04_delete_attached_volume | Success | 151.23 | test_volumes.py
test_03_download_attached_volume | Success | 156.30 | test_volumes.py
test_02_attach_volume | Success | 89.17 | test_volumes.py
test_01_create_volume | Success | 620.73 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.69 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.72 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 242.50 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.53 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.83 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 126.14 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.38 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 75.64 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 25.33 | test_templates.py
test_10_destroy_cpvm | Success | 131.32 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.62 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.37 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.05 | test_ssvm.py
test_06_stop_cpvm | Success | 101.43 | test_ssvm.py
test_05_stop_ssvm | Success | 133.21 | test_ssvm.py
test_04_cpvm_internals | Success | 0.97 | test_ssvm.py
test_03_ssvm_internals | Success | 2.87 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.12 | test_snapshots.py
test_04_change_offering_small | Success | 204.46 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 

Re: Welcoming Wido as the new ACS VP

2017-03-20 Thread Wido den Hollander

> Op 20 maart 2017 om 8:45 schreef Daan Hoogland :
> 
> 
> You know that means for beer, right?

I fully understand that. Beers in Miami :-)

> 
> On 19/03/17 18:45, "Wido den Hollander"  wrote:
> 
> Thank you Will and all!
> 
> I'll be present at CCC in Miami this year for a 'official' initiation as 
> VP of the CloudStack project :)
> 
> Wido 
> 
> > Op 16 maart 2017 om 18:00 schreef Will Stevens :
> > 
> > 
> > Hello Everyone,
> > It has been a pleasure working with you as the ACS VP over the past 
> year.
> > I would like to say Thank You to everyone who has supported me in this 
> role
> > and have supported the project as a whole.
> > 
> > It is my pleasure to announce that Wido den Hollander has been voted in 
> to
> > replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido 
> has
> > a long history with the project and we are happy welcome him into this 
> new
> > role.
> > 
> > Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> > over many beers.  :)
> > 
> > Cheers,
> > 
> > *Will Stevens*
> > 
> > ​[1] http://us.cloudstackcollab.org/​
> 
> 
> 
> daan.hoogl...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>   
>  
>


Re: Welcoming Wido as the new ACS VP

2017-03-20 Thread Syed Ahmed
Little late to the party :)

First off, thanks to Will for all the hard work you've put in the past
year. I believe the community is growing strongly because of your
efforts.

Congratulations to Wido. I believe we will continue the momentum going
forward with our new leader! Looking forward to meeting you in Miami

-Syed

On Mon, Mar 20, 2017 at 11:09 AM, Ian Rae  wrote:
> +1 re: beer
>
> On Mon, Mar 20, 2017 at 3:45 AM, Daan Hoogland 
> wrote:
>
>> You know that means for beer, right?
>>
>> On 19/03/17 18:45, "Wido den Hollander"  wrote:
>>
>> Thank you Will and all!
>>
>> I'll be present at CCC in Miami this year for a 'official' initiation
>> as VP of the CloudStack project :)
>>
>> Wido
>>
>> > Op 16 maart 2017 om 18:00 schreef Will Stevens :
>> >
>> >
>> > Hello Everyone,
>> > It has been a pleasure working with you as the ACS VP over the past
>> year.
>> > I would like to say Thank You to everyone who has supported me in
>> this role
>> > and have supported the project as a whole.
>> >
>> > It is my pleasure to announce that Wido den Hollander has been voted
>> in to
>> > replace me as the Apache Cloudstack VP in our annual VP rotation.
>> Wido has
>> > a long history with the project and we are happy welcome him into
>> this new
>> > role.
>> >
>> > Be sure to join us at CCC in Miami [1] so we can initiate him
>> correctly
>> > over many beers.  :)
>> >
>> > Cheers,
>> >
>> > *Will Stevens*
>> >
>> > [1] http://us.cloudstackcollab.org/
>>
>>
>>
>> daan.hoogl...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>>
>
>
> --
> Ian Rae
> CEO | PDG
> c: 514.944.4008
>
> CloudOps | Cloud Infrastructure and Networking Solutions
> www.cloudops.com | 420 rue Guy | Montreal | Canada | H3J 1S6


Re: Welcoming Wido as the new ACS VP

2017-03-20 Thread Ian Rae
+1 re: beer

On Mon, Mar 20, 2017 at 3:45 AM, Daan Hoogland 
wrote:

> You know that means for beer, right?
>
> On 19/03/17 18:45, "Wido den Hollander"  wrote:
>
> Thank you Will and all!
>
> I'll be present at CCC in Miami this year for a 'official' initiation
> as VP of the CloudStack project :)
>
> Wido
>
> > Op 16 maart 2017 om 18:00 schreef Will Stevens :
> >
> >
> > Hello Everyone,
> > It has been a pleasure working with you as the ACS VP over the past
> year.
> > I would like to say Thank You to everyone who has supported me in
> this role
> > and have supported the project as a whole.
> >
> > It is my pleasure to announce that Wido den Hollander has been voted
> in to
> > replace me as the Apache Cloudstack VP in our annual VP rotation.
> Wido has
> > a long history with the project and we are happy welcome him into
> this new
> > role.
> >
> > Be sure to join us at CCC in Miami [1] so we can initiate him
> correctly
> > over many beers.  :)
> >
> > Cheers,
> >
> > *Will Stevens*
> >
> > ​[1] http://us.cloudstackcollab.org/​
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Ian Rae
CEO | PDG
c: 514.944.4008

CloudOps | Cloud Infrastructure and Networking Solutions
www.cloudops.com | 420 rue Guy | Montreal | Canada | H3J 1S6


Re:Re: Welcoming Wido as the new ACS VP

2017-03-20 Thread Haijiao
Hi, Wido


Maybe it's a good timing to organize community to discuss and refresh the 
roadmap of ACS in this year. (current one on Wiki is supposed to be updated)


We need prioritze the tasks and concentrate our resource.  That's quite 
important to make ACS successfully evolved IMHO.


Regards,




在2017年03月20 15时45分, "Daan Hoogland"写道:

You know that means for beer, right?

On 19/03/17 18:45, "Wido den Hollander"  wrote:

   Thank you Will and all!
   
   I'll be present at CCC in Miami this year for a 'official' initiation as VP 
of the CloudStack project :)
   
   Wido
   
   > Op 16 maart 2017 om 18:00 schreef Will Stevens :
   >
   >
   > Hello Everyone,
   > It has been a pleasure working with you as the ACS VP over the past year.
   > I would like to say Thank You to everyone who has supported me in this role
   > and have supported the project as a whole.
   >
   > It is my pleasure to announce that Wido den Hollander has been voted in to
   > replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
   > a long history with the project and we are happy welcome him into this new
   > role.
   >
   > Be sure to join us at CCC in Miami [1] so we can initiate him correctly
   > over many beers.  :)
   >
   > Cheers,
   >
   > *Will Stevens*
   >
   > [1] http://us.cloudstackcollab.org/
   


daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
 




[GitHub] cloudstack issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots e...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots e...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
thanks @olivierlemasle that look ok, marvin tests seem to fail, will rerun 
then now.
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots e...

2017-03-20 Thread olivierlemasle
Github user olivierlemasle commented on the issue:

https://github.com/apache/cloudstack/pull/2008
  
@borisstoyanov Thanks, I've renamed the pull request. Do you want me to 
rename to commit as well?

Additionally, the travis checks hit a timeout; I've closed and opened again 
this pull request twice to trigger a new build, with no success.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r106855504
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1764,9 +1765,12 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
 }
 nicNum = 
broadcastUriAllocatedToVM.get(ip.getBroadcastUri());
 
-if (numOfIps == 1 && !ip.isAdd()) {
-vifHotUnPlug(conn, routerName, ip.getVifMacAddress());
-networkUsage(routerIp, "deleteVif", "eth" + nicNum);
+if (lastIp != null && lastIp.equalsIgnoreCase("true") && 
!ip.isAdd()) {
--- End diff --

`StringUtils.equalsIgnoreCase` can check both null and the value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r106856634
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final 
PublicIpAddress o2) {
 associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
 }
 
+// for network if the ips does not have any rules, then only 
last ip
+List userIps = 
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(), 
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false. 
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
+ipsStaticNat++;
+}
+}
+
 final IpAssocCommand cmd = new IpAssocCommand(ipsToSend);
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_IP, 
_routerControlHelper.getRouterControlIp(router.getId()));
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_GUEST_IP, 
_routerControlHelper.getRouterIpInNetwork(associatedWithNetworkId, 
router.getId()));
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_NAME, 
router.getInstanceName());
 final DataCenterVO dcVo = 
_dcDao.findById(router.getDataCenterId());
 cmd.setAccessDetail(NetworkElementCommand.ZONE_NETWORK_TYPE, 
dcVo.getNetworkType().toString());
 
+// if there 1 static nat then it will be checked for remove at 
the resource
+if (ipsWithrules == 0 && ipsStaticNat == 0 ) {
--- End diff --

There's an extraneous space between the `0` and the `)` here. Also, this is 
probably just me misunderstanding the code, but wouldn't you want to check if 
`ipsStaticNat` equals `1` in this case? Or maybe you're checking for both to be 
`0` because if both are 0 we're generating a removal command?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r106855300
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -625,15 +627,20 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
 
 // there is only one ip in this public vlan and removing 
it, so
 // remove the nic
-if (ipsCount == 1 && !ip.isAdd()) {
-removeVif = true;
+if (lastIp != null && lastIp.equalsIgnoreCase("true") && 
!ip.isAdd()) {
--- End diff --

`StringUtils.equalsIgnoreCase` can replace checking both null and the 
value: 
https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringUtils.html#equalsIgnoreCase(java.lang.String,
 java.lang.String)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r106857110
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final 
PublicIpAddress o2) {
 associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
 }
 
+// for network if the ips does not have any rules, then only 
last ip
+List userIps = 
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(), 
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false. 
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
--- End diff --

Similar to the comments about checking if `lastIp` isn't null, I find that 
checking rule state to be null is a bit ... obscure. What is null supposed to 
mean in this context? It seems the `rule_state` column is only changed to 
`Releasing` when releasing an IP and nothing else. I guess that's intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2010: VPC Inline LB - CLOUDSTACK-9282

2017-03-20 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/2010
  
Added Marvin test code PEP8 and PyFlakes compliance:

CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/component/test_vpcinlinelbvm.py
CloudStack$
CloudStack$ pep8 test/integration/component/test_vpcinlinelbvm.py
CloudStack$


Validation:

Marvin test results:

=> Native ACS Environment: 

nosetests --with-marvin --marvin-config=nuage.cfg 
test/integration/component/test_vpcinlinelbvm.py

Test VpcInlineLbVm basic functionality ... === TestName: 
test_01_vpcinlinelbvm | Status : SUCCESS ===
ok
Test VpcInlineLbVm basic functionality with traffic ... === TestName: 
test_02_vpcinlinelbvm_with_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with multiple public IP addresses ... === 
TestName: test_03_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : 
SUCCESS ===
ok
Test VpcInlineLbVm functionality with lb rule events by performing ... === 
TestName: test_04_vpcinlinelbvm_with_lb_rule_events_traffic | Status : SUCCESS 
===
ok
Test VpcInlineLbVm functionality with different LB algorithms by ... === 
TestName: test_05_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with VpcInlineLbVm appliance ... === 
TestName: test_06_vpcinlinelbvm_appliance_operations_traffic | Status : 
EXCEPTION ===
ERROR
Test VpcInlineLbVm provider with network restarts and reboots by ... === 
TestName: test_07_vpcinlinelbvm_with_network_restarts_and_reboots | Status : 
EXCEPTION ===
ERROR
...
Ran 7 tests in 9684.676s

FAILED (errors=2)


[failed_plus_exceptions.txt](https://github.com/apache/cloudstack/files/854289/failed_plus_exceptions.txt)
[results.txt](https://github.com/apache/cloudstack/files/854288/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/854290/runinfo.txt)

Note: The above test failures are due to the bug: 
https://issues.apache.org/jira/browse/CLOUDSTACK-9837


=> ACS + Nuage VSP Environment: 

nosetests --with-marvin --marvin-config=nuage.cfg 
test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py

Test Nuage VSP VpcInlineLbVm basic functionality ... === TestName: 
test_01_nuage_vpcinlinelbvm | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm basic functionality with traffic ... === 
TestName: test_02_nuage_vpcinlinelbvm_with_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with multiple public IP ... === 
TestName: test_03_nuage_vpcinlinelbvm_with_multiple_public_ips_traffic | Status 
: SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with lb rule events by ... === 
TestName: test_04_nuage_vpcinlinelbvm_with_lb_rule_events_traffic | Status : 
FAILED ===
FAIL
Test Nuage VSP VpcInlineLbVm functionality with different LB ... === 
TestName: test_05_nuage_vpcinlinelbvm_with_algorithms_traffic | Status : 
SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with VpcInlineLbVm ... === 
TestName: test_06_nuage_vpcinlinelbvm_appliance_operations_traffic | Status : 
EXCEPTION ===
ERROR
Test Nuage VSP VpcInlineLbVm functionality with network reboots and ... === 
TestName: test_07_nuage_vpcinlinelbvm_with_network_restarts_and_reboots | 
Status : SUCCESS ===
ok

Ran 7 tests in 12848.175s

FAILED (errors=1, failures=1)


[failed_plus_exceptions.txt](https://github.com/apache/cloudstack/files/854302/failed_plus_exceptions.txt)
[results.txt](https://github.com/apache/cloudstack/files/854301/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/854300/runinfo.txt)

Note: The above failure is a random failure on Nuage VSP environment, which 
we are debugging.


=> Concurrency tests

Thread Count: 15

nosetests --with-marvin --marvin-config=nuage.cfg 
test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py

Test Nuage VSP VPC Network Public Load Balancing Rules Concurrency ... === 
TestName: test_01_nuage_vpc_network_public_lb_rules_concurrency | Status : 
SUCCESS ===
ok

--
Ran 1 test in 1606.907s

OK

[results.txt](https://github.com/apache/cloudstack/files/854313/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/854312/runinfo.txt)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please

[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2009
  
I am seeing the same Travis timeout on all the PRs. Will force push again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread karuturi
Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2009#discussion_r106854397
  
--- Diff: 
server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java ---
@@ -166,7 +166,7 @@ public String authenticate(String command, Map params, HttpSes
 throw new CloudAuthenticationException("Unable to find 
the domain from the path " + domain);
 }
 final UserAccount userAccount = 
_accountService.getActiveUserAccount(username[0], domainId);
-if (userAccount == null || 
!(User.Source.UNKNOWN.equals(userAccount.getSource()) || 
User.Source.LDAP.equals(userAccount.getSource( {
+if (userAccount != null && User.Source.SAML2 == 
userAccount.getSource()) {
--- End diff --

in case of LDAP, account will be created if it doesnt already exist.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@DaanHoogland you could review it as well it addressed in 
https://github.com/apache/cloudstack/pull/2011/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-20 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
code LGTM but @ustcweizhou 's patch still makes sense to me. Maybe you can 
add that separately? travis still fails!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-597


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@blueorangutan package



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2009
  
@karuturi done, can you check Travis failure; push -f or close/reopen the 
PR to kick it again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2009: CLOUDSTACK-9369 Fixed Ldap regression

2017-03-20 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2009#discussion_r106849093
  
--- Diff: 
server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java ---
@@ -166,7 +166,7 @@ public String authenticate(String command, Map params, HttpSes
 throw new CloudAuthenticationException("Unable to find 
the domain from the path " + domain);
 }
 final UserAccount userAccount = 
_accountService.getActiveUserAccount(username[0], domainId);
-if (userAccount == null || 
!(User.Source.UNKNOWN.equals(userAccount.getSource()) || 
User.Source.LDAP.equals(userAccount.getSource( {
+if (userAccount != null && User.Source.SAML2 == 
userAccount.getSource()) {
--- End diff --

Why do we need to remove the check `userAccount == null`? Comparision 
against Source.SAML2 is fine as long as there are no other user sources other 
than LDAP, SAML2 and UNKNOWN. (UNKNOWN should be NATIVE though)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@borisstoyanov first 4.9, then merge into master.
this patch can also be applied to master.
```
wget --no-check-certificate 
https://github.com/apache/cloudstack/pull/2011.patch
git am 2011.patch 
(or patch -p1 <2011.patch)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
ping @rhtyd @DaanHoogland @abhinandanprateek @PaulAngus for review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
Hi @ustcweizhou, out of curiosity why 4.9 instead of master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Retirement of midonet plugin

2017-03-20 Thread Daan Hoogland
Don’t worry Marty, non-committers/-coders will be heard here as well.

Good point @swill I think we have enough wording to call this a policy now… As 
so far, no objections of any kind have been raised I also think it is now 
official unless someone now starts shouting. Here is a semi-formal definition 
of the procedure.

Code that is not maintained and breaks the build will be phased out according 
to the following retirement procedure:

1. An announce in our mailing lists the road map of retirement, a data for the 
final removal should be defined and presented in this road map; This will be in 
terms of “The firsts release after /mm/dd”
2. If no objection arises or no one volunteers to maintain the code, a Jira 
ticket to disable of the code is created.
3. A patch to disable the code in the build will be created.
4. The patch is applied and released with the next x.y.0 release.
5. A Jira ticket to execute the final removal of the code is created.
6. A patch for the definite removal of the code is created.
7. The patch will be applied 6 months after the x.y.0 release is announced and 
thus be release with x.(y+n).0 (n probably being 1 but could be higher)


On 19/03/17 18:53, "Marty Godsey"  wrote:

I know that I am not a committer (I am a systems, networking guy, I don’t 
"code") but I agree with Will. Giving the community at large some time to yell 
if they are using is good.

Regards,
Marty Godsey
Principal Engineer
nSource Solutions, LLC

-Original Message-
From: Will Stevens [mailto:williamstev...@gmail.com] 
Sent: Sunday, March 19, 2017 7:39 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Retirement of midonet plugin

I think there needs to be at least 6 months between the disable code being 
released and the delete PR being merged. I feel like the clock has to start 
only when the disable code is generally available in a stable release (not when 
it is merged).

On Mar 19, 2017 6:47 AM, "Daan Hoogland" 
wrote:

> You are spot on. We can add a due date for the final removal I think.
> Let’s not add a target version, I’d say.
>
> On 18/03/17 23:23, "Rafael Weingärtner" 
> wrote:
>
> Sorry the delay guys, I have been swapped these last days.
>
> In summary, everybody that spoke is in favor of the plugin retirement.
> I am
> assuming that people who did not present their opinion agree with 
> the ones
> presented here.
>
> The process to retire this plugin would be the following:
>
>1. Announce in our mailing lists the road map of retirement, a 
> data for
>the final removal should be defined and presented in this road map;
>2. Create a Jira ticket to execute the plugin disabling (is this
>expression right?!), and of course, a PR to disable the build 
> until final
>deletion;
>3. Create a Jira ticket to execute the final removal of the plugin.
> The
>removal should only happen when the defined date comes by;
>4. Wait patiently while time goes by….
>5. When the time comes, create the PR and execute the plugin 
> removal.
>
>
> What date would you guys prefer to execute the plugin removal? 3, 
> 6, or 12
> months from now?
> What do you think of this process? Am I missing something else?
>
>
>
> On Wed, Mar 15, 2017 at 9:13 AM, Jeff Hair 
> wrote:
>
> > Complete removal of the plugin was my solution to the problem of 
> the jar
> > file's dependencies. If it's not used or maintained, then it 
> should be
> > removed, in my opinion. Disabling it in the build is a good 
> first step.
> >
> > *Jeff Hair*
> > Technical Lead and Software Developer
> >
> > Tel: (+354) 415 0200
> > j...@greenqloud.com
> > www.greenqloud.com
> >
> > On Wed, Mar 15, 2017 at 8:18 AM, Rohit Yadav < 
> rohit.ya...@shapeblue.com>
> > wrote:
> >
> > > +1 as others have noted
> > >
> > >
> > > Disable the plugin from the default build for next few releases 
and
> > > eventually deprecate/remove the plugin from the codebase. The 
> roadmap can
> > > look something like:
> > >
> > > - Announce on the MLs that we're planning to do this, send a 
> PR and get
> > it
> > > accepted
> > >
> > > - During the release process RM should make this information 
> available to
> > > everyone (including voting thread, would be nice to have a 
> shortlog of
> > > major changes in the voting email?)
> > >
> > > - In the release 

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-595


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Welcoming Wido as the new ACS VP

2017-03-20 Thread Daan Hoogland
You know that means for beer, right?

On 19/03/17 18:45, "Wido den Hollander"  wrote:

Thank you Will and all!

I'll be present at CCC in Miami this year for a 'official' initiation as VP 
of the CloudStack project :)

Wido 

> Op 16 maart 2017 om 18:00 schreef Will Stevens :
> 
> 
> Hello Everyone,
> It has been a pleasure working with you as the ACS VP over the past year.
> I would like to say Thank You to everyone who has supported me in this 
role
> and have supported the project as a whole.
> 
> It is my pleasure to announce that Wido den Hollander has been voted in to
> replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido 
has
> a long history with the project and we are happy welcome him into this new
> role.
> 
> Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> over many beers.  :)
> 
> Cheers,
> 
> *Will Stevens*
> 
> ​[1] http://us.cloudstackcollab.org/​



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-20 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@blueorangutan package 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2011: CLOUDSTACK-9811: fix duplicated nics on VR ca...

2017-03-20 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/2011

CLOUDSTACK-9811: fix duplicated nics on VR caused by nic name 
pp



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack fix-issue-p55p1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2011


commit cf442b459ae79ff7828c0ae868c4e1af9c078f01
Author: Wei Zhou 
Date:   2017-03-16T10:48:35Z

CLOUDSTACK-9811: fix duplicated nics on VR caused by nic name 
pp




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

2017-03-20 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
Hi @rhtyd,
>From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty 
messed-up and it becomes far too difficult to track changes.

I think everything has its own + and -. Multiple commits  provide more 
insight and clarity on history. Could you please provide some more advantages 
of squashing with proper proof. 

>From my experience

This statement seems very loose. I think it needs some improvement. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---